From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 06/11] DIO: Inline the complete submission path v2 Date: Mon, 08 Aug 2011 14:14:43 -0400 Message-ID: References: <1312259893-4548-1-git-send-email-andi@firstfloor.org> <1312259893-4548-7-git-send-email-andi@firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, Andi Kleen To: Andi Kleen Return-path: In-Reply-To: <1312259893-4548-7-git-send-email-andi@firstfloor.org> (Andi Kleen's message of "Mon, 1 Aug 2011 21:38:08 -0700") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andi Kleen writes: > From: Andi Kleen > > Add inlines to all the submission path functions. While this increases > code size it also gives gcc a lot of optimization opportunities > in this critical hotpath. > > In particular -- together with some other changes -- this > allows gcc to get rid of the unnecessary clearing of > sdio at the beginning and optimize the messy parameter passing. > Any non inlining of a function which takes a sdio parameter > would break this optimization because they cannot be done if the > address of a structure is taken. Do you want to use __always_inline, then? Cheers, Jeff