From: Jeff Moyer <jmoyer@redhat.com>
To: majianpeng <majianpeng@gmail.com>
Cc: axboe <axboe@kernel.dk>, viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] block: Set inode of block_device size to zero when delete gendisk.
Date: Wed, 25 Sep 2013 11:56:12 -0400 [thread overview]
Message-ID: <x49ob7gevz7.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <201309171121587796647@gmail.com> (majianpeng@gmail.com's message of "Tue, 17 Sep 2013 11:22:01 +0800")
majianpeng <majianpeng@gmail.com> writes:
> When remove gendisk, set the size of inode of block_device to zero.
> This is mainly let the vfs know disk removed.
>
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> block/genhd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index dadf42b..9a4c245 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1369,6 +1369,12 @@ int invalidate_partition(struct gendisk *disk, int partno)
> if (bdev) {
> fsync_bdev(bdev);
> res = __invalidate_device(bdev, true);
> + /*
> + * When used buffer-mode on raw blockdevice,the disk removed.
> + * But the vfs don't know.So tell the vfs size of disk
> + * became zero, the buffer write can return
> + */
> + i_size_write(bdev->bd_inode, 0);
> bdput(bdev);
> }
> return res;
prev parent reply other threads:[~2013-09-25 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 3:22 [PATCH V2 1/2] block: Set inode of block_device size to zero when delete gendisk majianpeng
2013-09-25 15:56 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49ob7gevz7.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=majianpeng@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).