From: Jeff Moyer <jmoyer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
Andrea Arcangeli <aarcange@redhat.com>, Jan Kara <jack@suse.cz>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
kosaki.motohiro@jp.fujitsu.com, linux-fsdevel@vger.kernel.org,
lwoodman@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time
Date: Tue, 18 Sep 2012 13:22:40 -0400 [thread overview]
Message-ID: <x49obl3s0tb.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1209181257410.11735@file.rdu.redhat.com> (Mikulas Patocka's message of "Tue, 18 Sep 2012 13:04:58 -0400 (EDT)")
Mikulas Patocka <mpatocka@redhat.com> writes:
> Hi Jeff
>
> Thanks for testing.
>
> It would be interesting ... what happens if you take the patch 3, leave
> "struct percpu_rw_semaphore bd_block_size_semaphore" in "struct
> block_device", but remove any use of the semaphore from fs/block_dev.c? -
> will the performance be like unpatched kernel or like patch 3? It could be
> that the change in the alignment affects performance on your CPU too, just
> differently than on my CPU.
I'll give it a try and report back.
> What is the CPU model that you used for testing?
http://ark.intel.com/products/53570/Intel-Xeon-Processor-E7-2860-%2824M-Cache-2_26-GHz-6_40-GTs-Intel-QPI%29
Cheers,
Jeff
next prev parent reply other threads:[~2012-09-18 17:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 3:04 Crash when IO is being submitted and block size is changed Mikulas Patocka
2012-06-28 11:15 ` Jan Kara
2012-06-28 15:44 ` Mikulas Patocka
2012-06-28 16:53 ` Jan Kara
2012-07-16 0:55 ` Mikulas Patocka
2012-07-17 19:19 ` Jeff Moyer
2012-07-19 2:27 ` Mikulas Patocka
2012-07-19 13:33 ` Jeff Moyer
2012-07-28 16:40 ` [PATCH 1/3] Fix " Mikulas Patocka
2012-07-28 16:41 ` [PATCH 2/3] Introduce percpu rw semaphores Mikulas Patocka
2012-07-28 16:42 ` [PATCH 3/3] blockdev: turn a rw semaphore into a percpu rw semaphore Mikulas Patocka
2012-07-28 20:44 ` [PATCH 2/3] Introduce percpu rw semaphores Eric Dumazet
2012-07-29 5:13 ` [dm-devel] " Mikulas Patocka
2012-07-29 10:10 ` Eric Dumazet
2012-07-29 18:36 ` Eric Dumazet
2012-08-01 20:07 ` Mikulas Patocka
2012-08-01 20:09 ` [PATCH 4/3] " Mikulas Patocka
2012-08-31 18:40 ` [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time Mikulas Patocka
2012-08-31 18:41 ` [PATCH 1/4] Add a lock that will be needed by the next patch Mikulas Patocka
2012-08-31 18:42 ` [PATCH 2/4] blockdev: fix a crash when block size is changed and I/O is issued simultaneously Mikulas Patocka
2012-08-31 18:43 ` [PATCH 3/4] blockdev: turn a rw semaphore into a percpu rw semaphore Mikulas Patocka
2012-08-31 18:43 ` [PATCH 4/4] New percpu lock implementation Mikulas Patocka
2012-08-31 19:27 ` [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time Mikulas Patocka
2012-08-31 20:11 ` Jeff Moyer
2012-08-31 20:34 ` Mikulas Patocka
2012-09-17 21:19 ` Jeff Moyer
2012-09-18 17:04 ` Mikulas Patocka
2012-09-18 17:22 ` Jeff Moyer [this message]
2012-09-18 18:55 ` Mikulas Patocka
2012-09-18 18:58 ` Jeff Moyer
2012-09-18 20:11 ` Jeff Moyer
2012-09-25 17:49 ` Jeff Moyer
2012-09-25 17:59 ` Jens Axboe
2012-09-25 18:11 ` Jens Axboe
2012-09-25 22:49 ` [PATCH 1/2] " Mikulas Patocka
2012-09-26 5:48 ` Jens Axboe
2012-11-16 22:02 ` Jeff Moyer
2012-09-25 22:50 ` [PATCH 2/2] " Mikulas Patocka
2012-09-25 22:58 ` [PATCH 0/4] " Mikulas Patocka
2012-09-26 13:47 ` Jeff Moyer
2012-09-26 14:35 ` Mikulas Patocka
2012-07-30 17:00 ` [dm-devel] [PATCH 2/3] Introduce percpu rw semaphores Paul E. McKenney
2012-07-31 0:00 ` Mikulas Patocka
2012-08-01 17:15 ` Paul E. McKenney
2012-06-29 6:25 ` Crash when IO is being submitted and block size is changed Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49obl3s0tb.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=aarcange@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jack@suse.cz \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mpatocka@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).