From: Jeff Moyer <jmoyer@redhat.com>
To: majianpeng <majianpeng@gmail.com>
Cc: axboe <axboe@kernel.dk>, viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH V2 0/2] Auto stop async-write on block device when device removed.
Date: Mon, 23 Sep 2013 10:47:53 -0400 [thread overview]
Message-ID: <x49r4cfy4py.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <201309171121559232246@gmail.com> (majianpeng@gmail.com's message of "Tue, 17 Sep 2013 11:21:58 +0800")
majianpeng <majianpeng@gmail.com> writes:
> For async-write on block device,if device removed,but the vfs don't know it.
> It will continue to do.
> Patch1 set size of inode of block device to zero when removed disk.By this,vfs know
> disk changed.
> Path2 add size-check on blk_aio_write.If pos of write larger than size of inode,it will
> return zero.So the user can check disk state.
OK, so the basic problem is that __generic_file_aio_write will always
return 0 after device removal, yes? I'm not sure why that's a real
issue, can you explain exactly why you're trying to change this?
As for your patches, I don't think that putting the i_size_write into
invalidate_partitions is a good idea. Consider the case of rescanning
partitions: you will always detect a size change now, which is not good.
Cheers,
Jeff
next prev parent reply other threads:[~2013-09-23 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 3:21 [PATCH V2 0/2] Auto stop async-write on block device when device removed majianpeng
2013-09-23 14:47 ` Jeff Moyer [this message]
2013-09-24 3:07 ` majianpeng
2013-09-24 13:54 ` Jeff Moyer
2013-09-25 1:32 ` majianpeng
2013-09-25 15:44 ` Jeff Moyer
2013-09-29 8:46 ` majianpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49r4cfy4py.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=majianpeng@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).