From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10808C33CAC for ; Thu, 6 Feb 2020 14:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D12B621741 for ; Thu, 6 Feb 2020 14:33:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SWI4TH//" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbgBFOdr (ORCPT ); Thu, 6 Feb 2020 09:33:47 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:37424 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726765AbgBFOdr (ORCPT ); Thu, 6 Feb 2020 09:33:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580999626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ncPmjoEwq7PfrjChe+n1l2nRN+8/UziQd61vGlVP2YY=; b=SWI4TH//ZWynAWPQRPR2KwWpf/X6H7OBp1psZsqX8yyDouc4qPnGFTSRUJV+KFxUJPWSdN CNR65uIOycmC2PS/2vXCLr2yM0unU/ECPQvpaOmScia86sd7n0eq42oi+AKMdbeGr0J+b6 C4zYS3QHzJeWxKMVm1JfuyyncxN03uE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-7qb4itb2PoGbLbtchBfLaw-1; Thu, 06 Feb 2020 09:33:42 -0500 X-MC-Unique: 7qb4itb2PoGbLbtchBfLaw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3746C85EE82; Thu, 6 Feb 2020 14:33:41 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A21526FA9; Thu, 6 Feb 2020 14:33:40 +0000 (UTC) From: Jeff Moyer To: Jan Kara Cc: dan.j.williams@intel.com, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, willy@infradead.org Subject: Re: [patch] dax: pass NOWAIT flag to iomap_apply References: <20200206084740.GE14001@quack2.suse.cz> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 Date: Thu, 06 Feb 2020 09:33:39 -0500 In-Reply-To: <20200206084740.GE14001@quack2.suse.cz> (Jan Kara's message of "Thu, 6 Feb 2020 09:47:40 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Jan Kara writes: > On Wed 05-02-20 14:15:58, Jeff Moyer wrote: >> fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o >> dax". The reason is that the initial pwrite to an empty file with the >> RWF_NOWAIT flag set does not return -EAGAIN. It turns out that >> dax_iomap_rw doesn't pass that flag through to iomap_apply. >> >> With this patch applied, generic/471 passes for me. >> >> Signed-off-by: Jeff Moyer > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara > > BTW, I've just noticed ext4 seems to be buggy in this regard and even this > patch doesn't fix it. So I guess you've been using XFS for testing this? That's right, sorry I didn't mention that. Will you send a patch for ext4, or do you want me to look into it? Thanks! Jeff