From: Jeff Moyer <jmoyer@redhat.com>
To: Alireza Haghdoost <alireza@cs.umn.edu>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org,
Jerry Fredin <jerry.fredin@netapp.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block/aio: Enable sysfs nomerge control for I/O requests in the plug list
Date: Wed, 23 Oct 2013 11:54:51 -0400 [thread overview]
Message-ID: <x49txg8x9ro.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <CAB-428koa_AtGr_sTW0xWZAqNgqmxKkeB5wGBB6QwxKx=qu3uA@mail.gmail.com> (Alireza Haghdoost's message of "Tue, 22 Oct 2013 18:54:25 -0500")
Alireza Haghdoost <alireza@cs.umn.edu> writes:
> This patch enables the sysfs to control I/O request merge
> functionality in the plug list. While this control has been
> implemented for the request queue, it was dismissed in the plug list.
> Therefore, block layer merges requests together (or attempt to merge)
> even if the merge capability was disable using sysfs nomerge parameter
> value 2.
Yeah, this looks like an oversight. Your mailer really munged up the
patch, though. You should fix that and resend (unless Jens just fixes
it up manually). Also, please specify the -p option to diff or just use
git diff.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2013-10-23 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 23:54 [PATCH] block/aio: Enable sysfs nomerge control for I/O requests in the plug list Alireza Haghdoost
2013-10-23 15:54 ` Jeff Moyer [this message]
2013-10-23 16:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49txg8x9ro.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=alireza@cs.umn.edu \
--cc=axboe@kernel.dk \
--cc=jerry.fredin@netapp.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).