From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-fsdevel\@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-block\@vger.kernel.org" <linux-block@vger.kernel.org>,
linux-aio@kvack.org
Subject: Re: [PATCH] fs: kill unused ret2 argument from iocb->ki_complete()
Date: Wed, 20 Oct 2021 15:47:43 -0400 [thread overview]
Message-ID: <x49v91rmqao.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <a60158d1-6ee0-6229-dc62-19ec40674585@kernel.dk> (Jens Axboe's message of "Wed, 20 Oct 2021 13:12:02 -0600")
Jens Axboe <axboe@kernel.dk> writes:
> On 10/20/21 1:11 PM, Jeff Moyer wrote:
>> Jens Axboe <axboe@kernel.dk> writes:
>>
>>> On 10/20/21 12:41 PM, Jens Axboe wrote:
>>>> Working on just changing it to a 64-bit type instead, then we can pass
>>>> in both at once with res2 being the upper 32 bits. That'll keep the same
>>>> API on the aio side.
>>>
>>> Here's that as an incremental. Since we can only be passing in 32-bits
>>> anyway across 32/64-bit, we can just make it an explicit 64-bit instead.
>>> This generates the same code on 64-bit for calling ->ki_complete, and we
>>> can trivially ignore the usb gadget issue as we now can pass in both
>>> values (and fill them in on the aio side).
>>
>> Yeah, I think that should work.
>
> Passed test and allmodconfig sanity check, sent out as v2 :)
It passed the libaio tests on x64. I'll do some more testing and review
the v2 posting.
Thanks!
Jeff
next prev parent reply other threads:[~2021-10-20 19:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 16:49 [PATCH] fs: kill unused ret2 argument from iocb->ki_complete() Jens Axboe
2021-10-20 17:30 ` Christoph Hellwig
2021-10-20 17:35 ` Jens Axboe
2021-10-20 17:49 ` Greg Kroah-Hartman
2021-10-21 16:40 ` John Keeping
2021-10-21 16:56 ` Jens Axboe
2021-10-22 15:44 ` Jens Axboe
2021-10-23 9:09 ` Greg Kroah-Hartman
2021-10-23 14:01 ` Jens Axboe
2021-10-20 18:16 ` Jeff Moyer
2021-10-20 18:21 ` Jens Axboe
2021-10-20 18:37 ` Jeff Moyer
2021-10-20 18:41 ` Jens Axboe
2021-10-20 18:56 ` Jens Axboe
2021-10-20 19:11 ` Jeff Moyer
2021-10-20 19:12 ` Jens Axboe
2021-10-20 19:47 ` Jeff Moyer [this message]
2021-10-20 19:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49v91rmqao.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).