From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Ming Lin <mlin@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO_EOF flags
Date: Fri, 24 Apr 2015 15:47:37 -0400 [thread overview]
Message-ID: <x49vbglxq92.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1429904462-16998-2-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Fri, 24 Apr 2015 21:41:02 +0200")
Christoph Hellwig <hch@lst.de> writes:
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index c2ee937..b0a5bff 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -112,8 +112,6 @@ struct bio {
> * bio flags
> */
> #define BIO_UPTODATE 0 /* ok after I/O completion */
> -#define BIO_RW_BLOCK 1 /* RW_AHEAD set, and read/write would block */
> -#define BIO_EOF 2 /* out-out-bounds error */
> #define BIO_SEG_VALID 3 /* bi_phys_segments valid */
> #define BIO_CLONED 4 /* doesn't own data */
> #define BIO_BOUNCED 5 /* bio is a bounce bio */
Any particular reason you elected to leave a hole in the numbering? I
don't have a preference either way, but I don't think there's any harm
in compressing it.
-Jeff
next prev parent reply other threads:[~2015-04-24 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 19:41 [PATCH 1/2] block: remove BIO_EOPNOTSUPP Christoph Hellwig
2015-04-24 19:41 ` [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO_EOF flags Christoph Hellwig
2015-04-24 19:47 ` Jeff Moyer [this message]
2015-04-24 19:53 ` Christoph Hellwig
2015-04-24 20:33 ` Jeff Moyer
2015-04-24 21:32 ` Tejun Heo
2015-04-24 20:31 ` [PATCH 1/2] block: remove BIO_EOPNOTSUPP Jeff Moyer
2015-04-24 21:31 ` Tejun Heo
2015-05-19 6:39 ` Christoph Hellwig
2015-05-19 15:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49vbglxq92.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlin@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).