From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO_EOF flags Date: Fri, 24 Apr 2015 15:47:37 -0400 Message-ID: References: <1429904462-16998-1-git-send-email-hch@lst.de> <1429904462-16998-2-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain Cc: Jens Axboe , Tejun Heo , Ming Lin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41908 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031295AbbDXTrr (ORCPT ); Fri, 24 Apr 2015 15:47:47 -0400 In-Reply-To: <1429904462-16998-2-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Fri, 24 Apr 2015 21:41:02 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Christoph Hellwig writes: > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index c2ee937..b0a5bff 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -112,8 +112,6 @@ struct bio { > * bio flags > */ > #define BIO_UPTODATE 0 /* ok after I/O completion */ > -#define BIO_RW_BLOCK 1 /* RW_AHEAD set, and read/write would block */ > -#define BIO_EOF 2 /* out-out-bounds error */ > #define BIO_SEG_VALID 3 /* bi_phys_segments valid */ > #define BIO_CLONED 4 /* doesn't own data */ > #define BIO_BOUNCED 5 /* bio is a bounce bio */ Any particular reason you elected to leave a hole in the numbering? I don't have a preference either way, but I don't think there's any harm in compressing it. -Jeff