From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Date: Tue, 16 Sep 2014 17:24:29 -0400 Message-ID: References: <20140916210441.GC24591@infradead.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Milosz Tanski , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo To: Christoph Hellwig Return-path: In-Reply-To: <20140916210441.GC24591@infradead.org> (Christoph Hellwig's message of "Tue, 16 Sep 2014 14:04:41 -0700") Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig writes: >> Again, the right return value for the O_DIRECT case is EINVAL. > > Is it? We define -EAGAIN as it would block, which is defintively true > for O_DIRECT reads. It will *always* block. So I don't think it's valid to ask for a non-blocking read on a file opened with O_DIRECT. What am I missing? Cheers, Jeff -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org