Re: [PATCH 1/5] hfs: update comments on hfs_inode_setattr

[Jan Kara <jack@suse.cz>]

On Wed 25-03-26 07:36:48, Christoph Hellwig wrote:
> The top of function comment about hfs_inode_setattr is severely out
> of date and reference a previous name for this function.  Remove it,
> and update the comments in the file to record the still relevant bits
> directly.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I agree the comments seem really outdated. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/hfs/inode.c | 21 ++-------------------
>  1 file changed, 2 insertions(+), 19 deletions(-)
> 
> diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
> index 878535db64d6..72948eb2fadc 100644
> --- a/fs/hfs/inode.c
> +++ b/fs/hfs/inode.c
> @@ -622,23 +622,6 @@ static int hfs_file_release(struct inode *inode, struct file *file)
>  	return 0;
>  }
>  
> -/*
> - * hfs_notify_change()
> - *
> - * Based very closely on fs/msdos/inode.c by Werner Almesberger
> - *
> - * This is the notify_change() field in the super_operations structure
> - * for HFS file systems.  The purpose is to take that changes made to
> - * an inode and apply then in a filesystem-dependent manner.  In this
> - * case the process has a few of tasks to do:
> - *  1) prevent changes to the i_uid and i_gid fields.
> - *  2) map file permissions to the closest allowable permissions
> - *  3) Since multiple Linux files can share the same on-disk inode under
> - *     HFS (for instance the data and resource forks of a file) a change
> - *     to permissions must be applied to all other in-core inodes which
> - *     correspond to the same HFS file.
> - */
> -
>  int hfs_inode_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
>  		      struct iattr *attr)
>  {
> @@ -646,8 +629,7 @@ int hfs_inode_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
>  	struct hfs_sb_info *hsb = HFS_SB(inode->i_sb);
>  	int error;
>  
> -	error = setattr_prepare(&nop_mnt_idmap, dentry,
> -				attr); /* basic permission checks */
> +	error = setattr_prepare(&nop_mnt_idmap, dentry, attr);
>  	if (error)
>  		return error;
>  
> @@ -663,6 +645,7 @@ int hfs_inode_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
>  		return hsb->s_quiet ? 0 : error;
>  	}
>  
> +	/* map file permissions to the closest allowable permissions in HFS */
>  	if (attr->ia_valid & ATTR_MODE) {
>  		/* Only the 'w' bits can ever change and only all together. */
>  		if (attr->ia_mode & S_IWUSR)
> -- 
> 2.47.3
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR