From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve French Subject: Re: [patch] cifs: use add_to_page_cache_lru Date: Tue, 20 Apr 2010 22:31:39 -0500 Message-ID: References: <20100317062316.GC2869@laptop> <524f69651003181143i67d2fbbdw148619b6065bca88@mail.gmail.com> <20100319011310.GG25636@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: linux-fsdevel@vger.kernel.org, Steve French , linux-cifs-client@lists.samba.org To: Nick Piggin Return-path: In-Reply-To: <20100319011310.GG25636@laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces@lists.samba.org Errors-To: linux-cifs-client-bounces@lists.samba.org List-Id: linux-fsdevel.vger.kernel.org queued up for when the merge window opens ... thx On Thu, Mar 18, 2010 at 8:13 PM, Nick Piggin wrote: > On Thu, Mar 18, 2010 at 01:43:17PM -0500, Steve French wrote: >> Seems reasonable to me (also Shaggy acked this). =A0Any idea how likely >> it would affect performance (and would thus need to run through some >> simple iozone and cthon (timing mode) or similar perf testing) > > It should positively affect LRU ordering, and CPU efficiency, but both > such a tiny amount it should be in the noise. It wouldn't affect IO > patterns (except as a side effect of slightly different pagecache > reclaim, but again in the noise). > > I wouldn't worry about benchmarking it. > > -- = Thanks, Steve