From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: Wrong DIF guard tag on ext2 write Date: Thu, 03 Jun 2010 21:34:18 -0400 Message-ID: References: <20100531112817.GA16260@schmichrtp.mainz.de.ibm.com> <20100531144648.GA19068@schmichrtp.mainz.de.ibm.com> <20100602133748.GA11196@schmichrtp.mainz.de.ibm.com> <20100602232039.GA8287@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christof Schmitt , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Dave Chinner Return-path: In-Reply-To: <20100602232039.GA8287@dastard> (Dave Chinner's message of "Thu, 3 Jun 2010 09:20:39 +1000") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org >>>>> "Dave" == Dave Chinner writes: Dave> If you are running DIF hardware, then XFS is only OK for direct Dave> IO. XFS will still get torn writes if you are overwriting Dave> buffered data (either by write() or mmap()) because there are no Dave> interlocks to prevent cached pages under writeback from being Dave> modified while DMA is being performed..... Didn't you use to wait_on_page_writeback() in page_mkwrite()? -- Martin K. Petersen Oracle Linux Engineering