From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 4/5] brd: Request from fdisk 4k alignment Date: Wed, 05 Nov 2014 09:20:06 -0500 Message-ID: References: <545A2D69.8090003@plexistor.com> <545A2F52.3040303@plexistor.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Jens Axboe , Matthew Wilcox , Dmitry Monakhov , linux-kernel , linux-fsdevel To: Boaz Harrosh Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:49342 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753916AbaKEOU1 (ORCPT ); Wed, 5 Nov 2014 09:20:27 -0500 In-Reply-To: <545A2F52.3040303@plexistor.com> (Boaz Harrosh's message of "Wed, 05 Nov 2014 16:08:18 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: >>>>> "Boaz" == Boaz Harrosh writes: Hey Boaz, Boaz> Note that blk_queue_physical_block_size() also trashes io_min, but Boaz> we can leave this one to be 512. io_min as opposed to Boaz> physical_block_size will actually change Kernel behavior Care to elaborate? Also, fdisk and parted should be aligning on 1MB by default regardless of block size. So I'm also not sure why you need to trick fdisk to align by setting the pbs. -- Martin K. Petersen Oracle Linux Engineering