From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 3/3] blkdev: honor discard_granularity in blkdev_issue_discard()
Date: Mon, 02 May 2011 13:07:27 -0400
Message-ID: <yq1pqo12fqo.fsf@sermon.lab.mkp.net>
References: <1304345841-20063-1-git-send-email-lczerner@redhat.com>
	<1304345841-20063-3-git-send-email-lczerner@redhat.com>
	<yq17ha94175.fsf@sermon.lab.mkp.net>
	<x49aaf5ozge.fsf@segfault.boston.devel.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Lukas Czerner <lczerner@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Monakhov <dmonakhov@openvz.org>,
	Jens Axboe <jaxboe@fusionio.com>
To: Jeff Moyer <jmoyer@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from rcsinet10.oracle.com ([148.87.113.121]:54989 "EHLO
	rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754250Ab1EBRHj (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 2 May 2011 13:07:39 -0400
In-Reply-To: <x49aaf5ozge.fsf@segfault.boston.devel.redhat.com> (Jeff Moyer's
	message of "Mon, 02 May 2011 12:10:41 -0400")
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

>>>>> "Jeff" == Jeff Moyer <jmoyer@redhat.com> writes:

Jeff> Hm, I wonder where it makes sense to document this.  Maybe
Jeff> Documentation/block/queue-sysfs.txt, but I admit I wouldn't have
Jeff> looked there while reviewing this code.

Maybe we could simply add a comment in the kerneldoc header for
blkdev_issue_discard()?

I tried to keep Documentation/ABI/ up to date for the topology stuff but
it looks like the discard portions never got merged. Probably fell
through the cracks. I'll dig up the patch.

But as you say -- I'm sure nobody looks. My only motivation for keeping
the sysfs ABI doc in sync is to avoid gregkh's wrath...

-- 
Martin K. Petersen	Oracle Linux Engineering