From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
David Sterba <dsterba@suse.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yangtao Li <frank.li@vivo.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/5] adfs: rename adfs_notify_change to adfs_setattr
Date: Wed, 25 Mar 2026 12:53:52 +0100 [thread overview]
Message-ID: <zw65s2prif22qhb73aqfv2fonl7fnykhom5wzj7lqyymirrolc@q4xdwyfoubbn> (raw)
In-Reply-To: <20260325063711.3298685-3-hch@lst.de>
On Wed 25-03-26 07:36:49, Christoph Hellwig wrote:
> Make the function name match the method that it implements.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
One typo correction below:
> /*
> * write an existing inode back to the directory, and therefore the disk.
> - * The adfs-specific inode data has already been updated by
> - * adfs_notify_change()
> + * The adfs-specific inode data has already been updated by * adfs_setattr().
^^^ spurious *
> */
> int adfs_write_inode(struct inode *inode, struct writeback_control *wbc)
> {
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2026-03-25 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 6:36 trivial ->setattr cleanups Christoph Hellwig
2026-03-25 6:36 ` [PATCH 1/5] hfs: update comments on hfs_inode_setattr Christoph Hellwig
2026-03-25 11:52 ` Jan Kara
2026-03-25 16:38 ` vdubeyko
2026-03-25 6:36 ` [PATCH 2/5] adfs: rename adfs_notify_change to adfs_setattr Christoph Hellwig
2026-03-25 11:53 ` Jan Kara [this message]
2026-03-25 6:36 ` [PATCH 3/5] affs: rename affs_notify_change to affs_setattr Christoph Hellwig
2026-03-25 11:54 ` Jan Kara
2026-03-25 6:36 ` [PATCH 4/5] proc: rename proc_setattr to proc_nochmod_setattr Christoph Hellwig
2026-03-25 11:56 ` Jan Kara
2026-03-25 6:36 ` [PATCH 5/5] proc: rename proc_notify_change to proc_setattr Christoph Hellwig
2026-03-25 12:12 ` Jan Kara
2026-03-26 14:18 ` trivial ->setattr cleanups Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zw65s2prif22qhb73aqfv2fonl7fnykhom5wzj7lqyymirrolc@q4xdwyfoubbn \
--to=jack@suse.cz \
--cc=brauner@kernel.org \
--cc=dsterba@suse.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox