From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. J. Lu" Subject: PATCH: Don't use empy files in ld-elfvers Date: Tue, 6 May 2003 08:41:19 -0700 Sender: gcc-owner@gcc.gnu.org Message-ID: <20030506084119.A4370@lucon.org> References: <20030505223301.A28436@lucon.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="WhfpMioaduB5tiZL" Return-path: List-Unsubscribe: List-Archive: List-Post: List-Help: Content-Disposition: inline In-Reply-To: ; from aj@suse.de on Tue, May 06, 2003 at 09:17:13AM +0200 List-Id: To: Andreas Jaeger Cc: binutils@sources.redhat.com, gcc@gcc.gnu.org, GNU C Library , Kenneth Albanowski , Mat Hostetter , Warner Losh , linux-mips@linux-mips.org, Ron Guilmette , Ralf Baechle , Linas Vepstas , Leonard Zubkoff , "Steven J. Hill" , linux-gcc@vger.kernel.org --WhfpMioaduB5tiZL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 06, 2003 at 09:17:13AM +0200, Andreas Jaeger wrote: > "H. J. Lu" writes: >=20 > > This is the beta release of binutils 2.14.90.0.1 for Linux, which is > > based on binutils 2003 0505 in CVS on sourecs.redhat.com plus various > > changes. It is purely for Linux. > > > > The Linux/mips support is added. You have to use > > > > # rpm --target=3D[mips|mipsel] -ta binutils-xx.xx.xx.xx.xx.tar.gz > > > > to build it. Or you can read mips/README in the source tree to apply > > the mips patches and build it by hand. > > > > Please report any bugs related to binutils 2.14.90.0.1 to hjl@lucon.org. >=20 > HJ, >=20 > the package is broken, the testsuite fails since the following > (empty!) files from the ld/testsuite are not part of the tarball: >=20 >=20 > ./testsuite/ld-elfvers/vers25b.c > ./testsuite/ld-elfvers/vers25b.dsym > ./testsuite/ld-elfvers/vers25b.ver > ./testsuite/ld-elfvers/vers26b.dsym > ./testsuite/ld-elfvers/vers26b.ver > ./testsuite/ld-elfvers/vers27b.dsym > ./testsuite/ld-elfvers/vers27b.ver > ./testsuite/ld-elfvers/vers27c.c > ./testsuite/ld-elfvers/vers27c.dsym > ./testsuite/ld-elfvers/vers27c.ver >=20 It is not such a good idea to use empty files in CVS. I will check in this patch. Please apply binutils-2.14.90.0.1-empty-test.patch to the Linux binutils 2.14.90.0.1. H.J. --WhfpMioaduB5tiZL Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="binutils-2.14.90.0.1-empty-test.patch" Content-Transfer-Encoding: quoted-printable 2003-05-06 H.J. Lu * ld-elfvers/vers.exp (objdump_versionstuff): Support comment in expected version file. * ld-elfvers/vers25b.c: Add a line of comment. * ld-elfvers/vers25b.dsym: Likwise. * ld-elfvers/vers25b.ver: Likwise. * ld-elfvers/vers26b.dsym: Likwise. * ld-elfvers/vers26b.ver: Likwise. * ld-elfvers/vers27b.dsym: Likwise. * ld-elfvers/vers27b.ver: Likwise. * ld-elfvers/vers27c.c: Likwise. * ld-elfvers/vers27c.dsym: Likwise. * ld-elfvers/vers27c.ver: Likwise. --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers.exp.empty 2003-05-05 = 14:46:50.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers.exp 2003-05-06 08:32:= 18.000000000 -0700 @@ -457,7 +457,11 @@ proc objdump_versionstuff { objdump obje =20 set f1 [open $tmpdir/objdump.out r] set f2 [open $expectfile r] - gets $f2 l2 + while { [gets $f2 l2] !=3D -1 } { + if { ![regexp "^#.*$" $l2] } then { + break + } + }=20 while { [gets $f1 l1] !=3D -1 } { if { [string match $l2 $l1] } then { if { [gets $f2 l2] =3D=3D -1 } then { --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.c.empty 2003-05-06= 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.c 2003-05-06 08:32= :18.000000000 -0700 @@ -0,0 +1 @@ +/* Empty file */ --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.dsym.empty 2003-05= -06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.dsym 2003-05-06 08= :32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file. --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.ver.empty 2003-05-= 06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.ver 2003-05-06 08:= 32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.dsym.empty 2003-05= -06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.dsym 2003-05-06 08= :32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.ver.empty 2003-05-= 06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.ver 2003-05-06 08:= 32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.dsym.empty 2003-05= -06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.dsym 2003-05-06 08= :32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.ver.empty 2003-05-= 06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.ver 2003-05-06 08:= 32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.c.empty 2003-05-06= 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.c 2003-05-06 08:32= :18.000000000 -0700 @@ -0,0 +1 @@ +/* Empty file */ --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.dsym.empty 2003-05= -06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.dsym 2003-05-06 08= :32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.ver.empty 2003-05-= 06 08:32:18.000000000 -0700 +++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.ver 2003-05-06 08:= 32:18.000000000 -0700 @@ -0,0 +1 @@ +# Empty file --WhfpMioaduB5tiZL--