From: Zack Weinberg <zack@codesourcery.com>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: Denis Zaitsev <zzz@anda.ru>,
gcc@gcc.gnu.org, linux-gcc@vger.kernel.org,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] GCC 3.4.3: libobjc build failure
Date: Mon, 20 Dec 2004 13:50:19 -0800 [thread overview]
Message-ID: <87y8fsskpw.wl%zack@codesourcery.com> (raw)
In-Reply-To: <81947436-52CF-11D9-9FB0-000A95D692F4@physics.uc.edu>
At Mon, 20 Dec 2004 16:38:36 -0500,
Andrew Pinski wrote:
>
>
> On Dec 20, 2004, at 4:35 PM, Denis Zaitsev wrote:
>
> > This patch is for exactly the same issue as described in
> >
> > http://gcc.gnu.org/ml/gcc/2002-12/msg00033.html
> >
> > The fix is exactly the same, just another file is the target. Without
> > it libobjc fails to build when --with-objc-gc is given to configure.
>
> This patch is incorrect as noted before. I am going to reject it
> as it was rejected before. Again libobjc has no reason to include
> these headers.
The patch is the Wrong Thing in a formal sense. However, it may be
the correct thing to do in the short term. libobjc files have been
including coretypes.h and tm.h for a very long time; adding a few more
is not the end of the world, especially not on an old release branch!
zw
prev parent reply other threads:[~2004-12-20 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 21:35 [PATCH] GCC 3.4.3: libobjc build failure Denis Zaitsev
2004-12-20 21:38 ` Andrew Pinski
2004-12-20 21:48 ` Denis Zaitsev
2004-12-20 21:53 ` Andrew Pinski
2004-12-20 22:03 ` Andrew Pinski
2004-12-20 22:26 ` Denis Zaitsev
2004-12-20 22:32 ` Andrew Pinski
2004-12-20 22:35 ` Andrew Pinski
2004-12-20 22:46 ` Denis Zaitsev
2004-12-20 22:48 ` Andrew Pinski
2004-12-20 23:14 ` Denis Zaitsev
2004-12-20 22:07 ` Denis Zaitsev
2004-12-20 21:50 ` Zack Weinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y8fsskpw.wl%zack@codesourcery.com \
--to=zack@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=linux-gcc@vger.kernel.org \
--cc=pinskia@physics.uc.edu \
--cc=zzz@anda.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).