From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zack Weinberg Subject: Re: [PATCH] GCC 3.4.3: libobjc build failure Date: Mon, 20 Dec 2004 13:50:19 -0800 Message-ID: <87y8fsskpw.wl%zack@codesourcery.com> References: <20041221023548.A8330@natasha.ward.six> <81947436-52CF-11D9-9FB0-000A95D692F4@physics.uc.edu> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Return-path: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org In-Reply-To: <81947436-52CF-11D9-9FB0-000A95D692F4@physics.uc.edu> List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Pinski Cc: Denis Zaitsev , gcc@gcc.gnu.org, linux-gcc@vger.kernel.org, gcc-patches@gcc.gnu.org At Mon, 20 Dec 2004 16:38:36 -0500, Andrew Pinski wrote: > > > On Dec 20, 2004, at 4:35 PM, Denis Zaitsev wrote: > > > This patch is for exactly the same issue as described in > > > > http://gcc.gnu.org/ml/gcc/2002-12/msg00033.html > > > > The fix is exactly the same, just another file is the target. Without > > it libobjc fails to build when --with-objc-gc is given to configure. > > This patch is incorrect as noted before. I am going to reject it > as it was rejected before. Again libobjc has no reason to include > these headers. The patch is the Wrong Thing in a formal sense. However, it may be the correct thing to do in the short term. libobjc files have been including coretypes.h and tm.h for a very long time; adding a few more is not the end of the world, especially not on an old release branch! zw