Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linusw@kernel.org>,
	Ye Zhang <ye.zhang@rock-chips.com>,
	Jonas Karlman <jonas@kwiboo.se>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506
Date: Sat, 21 Nov 2026 17:09:29 +0100	[thread overview]
Message-ID: <-Gre4owXTw2C51e--4u2UA@sntech.de> (raw)
In-Reply-To: <20261121155810.706866-1-jonas@kwiboo.se>

Am Samstag, 21. November 2026, 16:58:09 Mitteleuropäische Normalzeit schrieb Jonas Karlman:
> rockchip_get_pull() is missing a RK3506 case and instead returns -EINVAL
> for all pins. As a result, the pinconf-pins debugfs file omits the pull
> configuration for all pins on RK3506:
> 
>   pin 0 (gpio0-0): ..., pin output (1 level)
>   pin 1 (gpio0-1): ..., pin output (1 level)
>   pin 2 (gpio0-2): ..., pin output (1 level)
>   pin 3 (gpio0-3): ..., pin output (0 level)
> 
> Add RK3506 to the case that decodes the pull configuration from the
> register value to fix pull configuration readback on RK3506.
> 
> After this the pinconf-pins debugfs file includes pull configuration:
> 
>   pin 0 (gpio0-0): input bias pull up (1 ohms), ..., pin output (1 level)
>   pin 1 (gpio0-1): input bias pull down (1 ohms), ..., pin output (1 level)
>   pin 2 (gpio0-2): input bias pull up (1 ohms), ..., pin output (1 level)
>   pin 3 (gpio0-3): input bias pull down (1 ohms), ..., pin output (0 level)
> 
> Fixes: dbd2317d7b9f ("pinctrl: rockchip: Add rk3506 pinctrl support")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

rockchip_set_pull has that case statenment, rockchip_get_pull is
missing it.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>




      reply	other threads:[~2026-11-21 16:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 15:58 [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506 Jonas Karlman
2026-11-21 16:09 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=-Gre4owXTw2C51e--4u2UA@sntech.de \
    --to=heiko@sntech.de \
    --cc=jonas@kwiboo.se \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=ye.zhang@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox