linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/17] gpio: remove unnecessary OOM messages
@ 2014-04-29  8:29 Jingoo Han
  2014-04-29  8:31 ` [PATCH 01/17] gpio: adp5520: " Jingoo Han
                   ` (18 more replies)
  0 siblings, 19 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:29 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().

Jingoo Han (17):
      gpio: adp5520: remove unnecessary OOM messages
      gpio: adp5588: remove unnecessary OOM messages
      gpio: davinci: remove unnecessary OOM messages
      gpio: em: remove unnecessary OOM messages
      gpio: janz-ttl: remove unnecessary OOM messages
      gpio: lynxpoint: remove unnecessary OOM messages
      gpio: moxart: remove unnecessary OOM messages
      gpio: mvebu: remove unnecessary OOM messages
      gpio: palmas: remove unnecessary OOM messages
      gpio: rc5t583: remove unnecessary OOM messages
      gpio: rcar: remove unnecessary OOM messages
      gpio: rdc321x: remove unnecessary OOM messages
      gpio: SPEAr: remove unnecessary OOM messages
      gpio: tegra: remove unnecessary OOM messages
      gpio: tps6586x: remove unnecessary OOM messages
      gpio: tps65910: remove unnecessary OOM messages
      gpio: zevio: remove unnecessary OOM messages
---
 drivers/gpio/gpio-adp5520.c     |    4 +---
 drivers/gpio/gpio-adp5588.c     |    4 +---
 drivers/gpio/gpio-davinci.c     |    4 +---
 drivers/gpio/gpio-em.c          |    1 -
 drivers/gpio/gpio-janz-ttl.c    |    1 -
 drivers/gpio/gpio-lynxpoint.c   |    4 +---
 drivers/gpio/gpio-moxart.c      |    4 +---
 drivers/gpio/gpio-mvebu.c       |    4 +---
 drivers/gpio/gpio-palmas.c      |    4 +---
 drivers/gpio/gpio-rc5t583.c     |    4 +---
 drivers/gpio/gpio-rcar.c        |    1 -
 drivers/gpio/gpio-rdc321x.c     |    4 +---
 drivers/gpio/gpio-spear-spics.c |    4 +---
 drivers/gpio/gpio-tegra.c       |    4 +---
 drivers/gpio/gpio-tps6586x.c    |    4 +---
 drivers/gpio/gpio-tps65910.c    |    4 +---
 drivers/gpio/gpio-zevio.c       |    4 +---
 17 files changed, 14 insertions(+), 45 deletions(-)


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 01/17] gpio: adp5520: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
@ 2014-04-29  8:31 ` Jingoo Han
  2014-04-29  8:32 ` [PATCH 02/17] gpio: adp5588: " Jingoo Han
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:31 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Michael Hennerich'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-adp5520.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-adp5520.c b/drivers/gpio/gpio-adp5520.c
index 6132659..f1ade8f 100644
--- a/drivers/gpio/gpio-adp5520.c
+++ b/drivers/gpio/gpio-adp5520.c
@@ -106,10 +106,8 @@ static int adp5520_gpio_probe(struct platform_device *pdev)
 	}
 
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-	if (dev == NULL) {
-		dev_err(&pdev->dev, "failed to alloc memory\n");
+	if (dev == NULL)
 		return -ENOMEM;
-	}
 
 	dev->master = pdev->dev.parent;
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 02/17] gpio: adp5588: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
  2014-04-29  8:31 ` [PATCH 01/17] gpio: adp5520: " Jingoo Han
@ 2014-04-29  8:32 ` Jingoo Han
  2014-04-29  8:33 ` [PATCH 03/17] gpio: davinci: " Jingoo Han
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:32 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Michael Hennerich'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-adp5588.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
index d974020..ef19bc3 100644
--- a/drivers/gpio/gpio-adp5588.c
+++ b/drivers/gpio/gpio-adp5588.c
@@ -379,10 +379,8 @@ static int adp5588_gpio_probe(struct i2c_client *client,
 	}
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-	if (dev == NULL) {
-		dev_err(&client->dev, "failed to alloc memory\n");
+	if (dev == NULL)
 		return -ENOMEM;
-	}
 
 	dev->client = client;
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 03/17] gpio: davinci: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
  2014-04-29  8:31 ` [PATCH 01/17] gpio: adp5520: " Jingoo Han
  2014-04-29  8:32 ` [PATCH 02/17] gpio: adp5588: " Jingoo Han
@ 2014-04-29  8:33 ` Jingoo Han
  2014-04-29  8:34 ` [PATCH 04/17] gpio: em: " Jingoo Han
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:33 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Alexander Holler', 'Grygorii Strashko',
	'Santosh Shilimkar'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-davinci.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 339f9da..9f06825 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -230,10 +230,8 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 	chips = devm_kzalloc(dev,
 			     ngpio * sizeof(struct davinci_gpio_controller),
 			     GFP_KERNEL);
-	if (!chips) {
-		dev_err(dev, "Memory allocation failed\n");
+	if (!chips)
 		return -ENOMEM;
-	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 04/17] gpio: em: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (2 preceding siblings ...)
  2014-04-29  8:33 ` [PATCH 03/17] gpio: davinci: " Jingoo Han
@ 2014-04-29  8:34 ` Jingoo Han
  2014-04-29  8:35 ` [PATCH 05/17] gpio: janz-ttl: " Jingoo Han
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:34 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Magnus Damm'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-em.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index 8765bd6..092711b 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -284,7 +284,6 @@ static int em_gio_probe(struct platform_device *pdev)
 
 	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
 	if (!p) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
 		ret = -ENOMEM;
 		goto err0;
 	}
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 05/17] gpio: janz-ttl: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (3 preceding siblings ...)
  2014-04-29  8:34 ` [PATCH 04/17] gpio: em: " Jingoo Han
@ 2014-04-29  8:35 ` Jingoo Han
  2014-04-29  8:36 ` [PATCH 06/17] gpio: lynxpoint: " Jingoo Han
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:35 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Ira W. Snyder'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-janz-ttl.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-janz-ttl.c b/drivers/gpio/gpio-janz-ttl.c
index 2ecd3a0..255806b 100644
--- a/drivers/gpio/gpio-janz-ttl.c
+++ b/drivers/gpio/gpio-janz-ttl.c
@@ -158,7 +158,6 @@ static int ttl_probe(struct platform_device *pdev)
 
 	mod = kzalloc(sizeof(*mod), GFP_KERNEL);
 	if (!mod) {
-		dev_err(dev, "unable to allocate private data\n");
 		ret = -ENOMEM;
 		goto out_return;
 	}
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 06/17] gpio: lynxpoint: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (4 preceding siblings ...)
  2014-04-29  8:35 ` [PATCH 05/17] gpio: janz-ttl: " Jingoo Han
@ 2014-04-29  8:36 ` Jingoo Han
  2014-04-29  8:37 ` [PATCH 07/17] gpio: moxart: " Jingoo Han
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:36 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Mika Westerberg'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-lynxpoint.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index 9a82a90..2bea89b 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -375,10 +375,8 @@ static int lp_gpio_probe(struct platform_device *pdev)
 	int ret = -ENODEV;
 
 	lg = devm_kzalloc(dev, sizeof(struct lp_gpio), GFP_KERNEL);
-	if (!lg) {
-		dev_err(dev, "can't allocate lp_gpio chip data\n");
+	if (!lg)
 		return -ENOMEM;
-	}
 
 	lg->pdev = pdev;
 	platform_set_drvdata(pdev, lg);
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 07/17] gpio: moxart: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (5 preceding siblings ...)
  2014-04-29  8:36 ` [PATCH 06/17] gpio: lynxpoint: " Jingoo Han
@ 2014-04-29  8:37 ` Jingoo Han
  2014-04-29  8:38 ` [PATCH 08/17] gpio: mvebu: " Jingoo Han
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:37 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Jonas Jensen'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-moxart.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
index ccd4570..4661e18 100644
--- a/drivers/gpio/gpio-moxart.c
+++ b/drivers/gpio/gpio-moxart.c
@@ -113,10 +113,8 @@ static int moxart_gpio_probe(struct platform_device *pdev)
 	int ret;
 
 	mgc = devm_kzalloc(dev, sizeof(*mgc), GFP_KERNEL);
-	if (!mgc) {
-		dev_err(dev, "can't allocate GPIO chip container\n");
+	if (!mgc)
 		return -ENOMEM;
-	}
 	mgc->gpio = moxart_template_chip;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 08/17] gpio: mvebu: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (6 preceding siblings ...)
  2014-04-29  8:37 ` [PATCH 07/17] gpio: moxart: " Jingoo Han
@ 2014-04-29  8:38 ` Jingoo Han
  2014-04-29 11:25   ` Jason Cooper
  2014-04-29  8:39 ` [PATCH 09/17] gpio: palmas: " Jingoo Han
                   ` (10 subsequent siblings)
  18 siblings, 1 reply; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:38 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Thomas Petazzoni', 'Jason Cooper'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-mvebu.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index d425094..4d398ff 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -574,10 +574,8 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
 		soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION;
 
 	mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip), GFP_KERNEL);
-	if (!mvchip) {
-		dev_err(&pdev->dev, "Cannot allocate memory\n");
+	if (!mvchip)
 		return -ENOMEM;
-	}
 
 	if (of_property_read_u32(pdev->dev.of_node, "ngpios", &ngpios)) {
 		dev_err(&pdev->dev, "Missing ngpios OF property\n");
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 09/17] gpio: palmas: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (7 preceding siblings ...)
  2014-04-29  8:38 ` [PATCH 08/17] gpio: mvebu: " Jingoo Han
@ 2014-04-29  8:39 ` Jingoo Han
  2014-04-29  8:39 ` [PATCH 10/17] gpio: rc5t583: " Jingoo Han
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:39 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Laxman Dewangan'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-palmas.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c
index da9d332..a5ec602 100644
--- a/drivers/gpio/gpio-palmas.c
+++ b/drivers/gpio/gpio-palmas.c
@@ -173,10 +173,8 @@ static int palmas_gpio_probe(struct platform_device *pdev)
 
 	palmas_gpio = devm_kzalloc(&pdev->dev,
 				sizeof(*palmas_gpio), GFP_KERNEL);
-	if (!palmas_gpio) {
-		dev_err(&pdev->dev, "Could not allocate palmas_gpio\n");
+	if (!palmas_gpio)
 		return -ENOMEM;
-	}
 
 	palmas_gpio->palmas = palmas;
 	palmas_gpio->gpio_chip.owner = THIS_MODULE;
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 10/17] gpio: rc5t583: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (8 preceding siblings ...)
  2014-04-29  8:39 ` [PATCH 09/17] gpio: palmas: " Jingoo Han
@ 2014-04-29  8:39 ` Jingoo Han
  2014-04-29  8:40 ` [PATCH 11/17] gpio: rcar: " Jingoo Han
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:39 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Laxman Dewangan'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-rc5t583.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c
index 9b42317..562b0c4 100644
--- a/drivers/gpio/gpio-rc5t583.c
+++ b/drivers/gpio/gpio-rc5t583.c
@@ -119,10 +119,8 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
 
 	rc5t583_gpio = devm_kzalloc(&pdev->dev, sizeof(*rc5t583_gpio),
 					GFP_KERNEL);
-	if (!rc5t583_gpio) {
-		dev_warn(&pdev->dev, "Mem allocation for rc5t583_gpio failed");
+	if (!rc5t583_gpio)
 		return -ENOMEM;
-	}
 
 	rc5t583_gpio->gpio_chip.label = "gpio-rc5t583",
 	rc5t583_gpio->gpio_chip.owner = THIS_MODULE,
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 11/17] gpio: rcar: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (9 preceding siblings ...)
  2014-04-29  8:39 ` [PATCH 10/17] gpio: rc5t583: " Jingoo Han
@ 2014-04-29  8:40 ` Jingoo Han
  2014-04-30  1:04   ` Laurent Pinchart
  2014-04-29  8:42 ` [PATCH 12/17] gpio: rdc321x: " Jingoo Han
                   ` (7 subsequent siblings)
  18 siblings, 1 reply; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:40 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Laurent Pinchart', 'Magnus Damm'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-rcar.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index bfcfeee..0c9f803 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -363,7 +363,6 @@ static int gpio_rcar_probe(struct platform_device *pdev)
 
 	p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);
 	if (!p) {
-		dev_err(dev, "failed to allocate driver data\n");
 		ret = -ENOMEM;
 		goto err0;
 	}
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 12/17] gpio: rdc321x: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (10 preceding siblings ...)
  2014-04-29  8:40 ` [PATCH 11/17] gpio: rcar: " Jingoo Han
@ 2014-04-29  8:42 ` Jingoo Han
  2014-04-29  8:42 ` [PATCH 13/17] gpio: SPEAr: " Jingoo Han
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:42 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Florian Fainelli'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-rdc321x.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-rdc321x.c b/drivers/gpio/gpio-rdc321x.c
index 7a319e5..9fa7e53 100644
--- a/drivers/gpio/gpio-rdc321x.c
+++ b/drivers/gpio/gpio-rdc321x.c
@@ -143,10 +143,8 @@ static int rdc321x_gpio_probe(struct platform_device *pdev)
 
 	rdc321x_gpio_dev = devm_kzalloc(&pdev->dev, sizeof(struct rdc321x_gpio),
 					GFP_KERNEL);
-	if (!rdc321x_gpio_dev) {
-		dev_err(&pdev->dev, "failed to allocate private data\n");
+	if (!rdc321x_gpio_dev)
 		return -ENOMEM;
-	}
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_IO, "gpio-reg1");
 	if (!r) {
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 13/17] gpio: SPEAr: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (11 preceding siblings ...)
  2014-04-29  8:42 ` [PATCH 12/17] gpio: rdc321x: " Jingoo Han
@ 2014-04-29  8:42 ` Jingoo Han
  2014-04-29  8:47   ` Viresh Kumar
  2014-04-29  8:44 ` [PATCH 14/17] gpio: tegra: " Jingoo Han
                   ` (5 subsequent siblings)
  18 siblings, 1 reply; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:42 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Shiraz Hashim', 'Viresh Kumar'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-spear-spics.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
index 30bcc53..353263c 100644
--- a/drivers/gpio/gpio-spear-spics.c
+++ b/drivers/gpio/gpio-spear-spics.c
@@ -129,10 +129,8 @@ static int spics_gpio_probe(struct platform_device *pdev)
 	int ret;
 
 	spics = devm_kzalloc(&pdev->dev, sizeof(*spics), GFP_KERNEL);
-	if (!spics) {
-		dev_err(&pdev->dev, "memory allocation fail\n");
+	if (!spics)
 		return -ENOMEM;
-	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	spics->base = devm_ioremap_resource(&pdev->dev, res);
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 14/17] gpio: tegra: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (12 preceding siblings ...)
  2014-04-29  8:42 ` [PATCH 13/17] gpio: SPEAr: " Jingoo Han
@ 2014-04-29  8:44 ` Jingoo Han
  2014-04-29  8:44 ` [PATCH 15/17] gpio: tps6586x: " Jingoo Han
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:44 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Thierry Reding'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-tegra.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 2b49f87..c6bdc2e 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -458,10 +458,8 @@ static int tegra_gpio_probe(struct platform_device *pdev)
 	tegra_gpio_banks = devm_kzalloc(&pdev->dev,
 			tegra_gpio_bank_count * sizeof(*tegra_gpio_banks),
 			GFP_KERNEL);
-	if (!tegra_gpio_banks) {
-		dev_err(&pdev->dev, "Couldn't allocate bank structure\n");
+	if (!tegra_gpio_banks)
 		return -ENODEV;
-	}
 
 	irq_domain = irq_domain_add_linear(pdev->dev.of_node,
 					   tegra_gpio_chip.ngpio,
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 15/17] gpio: tps6586x: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (13 preceding siblings ...)
  2014-04-29  8:44 ` [PATCH 14/17] gpio: tegra: " Jingoo Han
@ 2014-04-29  8:44 ` Jingoo Han
  2014-04-29  8:45 ` [PATCH 16/17] gpio: tps65910: " Jingoo Han
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:44 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Laxman Dewangan'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-tps6586x.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c
index 8994dfa..a69fbea 100644
--- a/drivers/gpio/gpio-tps6586x.c
+++ b/drivers/gpio/gpio-tps6586x.c
@@ -97,10 +97,8 @@ static int tps6586x_gpio_probe(struct platform_device *pdev)
 	pdata = dev_get_platdata(pdev->dev.parent);
 	tps6586x_gpio = devm_kzalloc(&pdev->dev,
 				sizeof(*tps6586x_gpio), GFP_KERNEL);
-	if (!tps6586x_gpio) {
-		dev_err(&pdev->dev, "Could not allocate tps6586x_gpio\n");
+	if (!tps6586x_gpio)
 		return -ENOMEM;
-	}
 
 	tps6586x_gpio->parent = pdev->dev.parent;
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 16/17] gpio: tps65910: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (14 preceding siblings ...)
  2014-04-29  8:44 ` [PATCH 15/17] gpio: tps6586x: " Jingoo Han
@ 2014-04-29  8:45 ` Jingoo Han
  2014-04-29  8:46 ` [PATCH 17/17] gpio: zevio: " Jingoo Han
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:45 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Laxman Dewangan'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-tps65910.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
index b6e818e..e2f8cda 100644
--- a/drivers/gpio/gpio-tps65910.c
+++ b/drivers/gpio/gpio-tps65910.c
@@ -123,10 +123,8 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
 
 	tps65910_gpio = devm_kzalloc(&pdev->dev,
 				sizeof(*tps65910_gpio), GFP_KERNEL);
-	if (!tps65910_gpio) {
-		dev_err(&pdev->dev, "Could not allocate tps65910_gpio\n");
+	if (!tps65910_gpio)
 		return -ENOMEM;
-	}
 
 	tps65910_gpio->tps65910 = tps65910;
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 17/17] gpio: zevio: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (15 preceding siblings ...)
  2014-04-29  8:45 ` [PATCH 16/17] gpio: tps65910: " Jingoo Han
@ 2014-04-29  8:46 ` Jingoo Han
  2014-04-29  9:21 ` [PATCH 00/17] gpio: " Javier Martinez Canillas
  2014-05-09  8:56 ` Linus Walleij
  18 siblings, 0 replies; 23+ messages in thread
From: Jingoo Han @ 2014-04-29  8:46 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
	'Fabian Vogt'

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-zevio.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index f20941c..112a107d 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -182,10 +182,8 @@ static int zevio_gpio_probe(struct platform_device *pdev)
 	int status, i;
 
 	controller = devm_kzalloc(&pdev->dev, sizeof(*controller), GFP_KERNEL);
-	if (!controller) {
-		dev_err(&pdev->dev, "not enough free memory\n");
+	if (!controller)
 		return -ENOMEM;
-	}
 
 	/* Copy our reference */
 	controller->chip.gc = zevio_gpio_chip;
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 13/17] gpio: SPEAr: remove unnecessary OOM messages
  2014-04-29  8:42 ` [PATCH 13/17] gpio: SPEAr: " Jingoo Han
@ 2014-04-29  8:47   ` Viresh Kumar
  0 siblings, 0 replies; 23+ messages in thread
From: Viresh Kumar @ 2014-04-29  8:47 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Linus Walleij, Alexandre Courbot, linux-gpio, Shiraz Hashim

On 29 April 2014 14:12, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/gpio/gpio-spear-spics.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 00/17] gpio: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (16 preceding siblings ...)
  2014-04-29  8:46 ` [PATCH 17/17] gpio: zevio: " Jingoo Han
@ 2014-04-29  9:21 ` Javier Martinez Canillas
  2014-05-09  8:56 ` Linus Walleij
  18 siblings, 0 replies; 23+ messages in thread
From: Javier Martinez Canillas @ 2014-04-29  9:21 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Linus Walleij, Alexandre Courbot, Linux GPIO List

On Tue, Apr 29, 2014 at 10:29 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
>

Not necessary indeed since besides the dump_stack(), a more complete
message is printed by warn_alloc_failed() in mm/page_alloc.c.

For the complete series:

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 08/17] gpio: mvebu: remove unnecessary OOM messages
  2014-04-29  8:38 ` [PATCH 08/17] gpio: mvebu: " Jingoo Han
@ 2014-04-29 11:25   ` Jason Cooper
  0 siblings, 0 replies; 23+ messages in thread
From: Jason Cooper @ 2014-04-29 11:25 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Linus Walleij', 'Alexandre Courbot', linux-gpio,
	'Thomas Petazzoni'

On Tue, Apr 29, 2014 at 05:38:21PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/gpio/gpio-mvebu.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

thx,

Jason.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 11/17] gpio: rcar: remove unnecessary OOM messages
  2014-04-29  8:40 ` [PATCH 11/17] gpio: rcar: " Jingoo Han
@ 2014-04-30  1:04   ` Laurent Pinchart
  0 siblings, 0 replies; 23+ messages in thread
From: Laurent Pinchart @ 2014-04-30  1:04 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Linus Walleij', 'Alexandre Courbot', linux-gpio,
	'Magnus Damm'

Hi Jingoo,

Thank you for the patch.

On Tuesday 29 April 2014 17:40:59 Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpio/gpio-rcar.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index bfcfeee..0c9f803 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -363,7 +363,6 @@ static int gpio_rcar_probe(struct platform_device *pdev)
> 
>  	p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);
>  	if (!p) {
> -		dev_err(dev, "failed to allocate driver data\n");
>  		ret = -ENOMEM;
>  		goto err0;
>  	}

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 00/17] gpio: remove unnecessary OOM messages
  2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
                   ` (17 preceding siblings ...)
  2014-04-29  9:21 ` [PATCH 00/17] gpio: " Javier Martinez Canillas
@ 2014-05-09  8:56 ` Linus Walleij
  18 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2014-05-09  8:56 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org

On Tue, Apr 29, 2014 at 10:29 AM, Jingoo Han <jg1.han@samsung.com> wrote:

> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().

All 17 patches applied, thanks!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2014-05-09  8:56 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29  8:29 [PATCH 00/17] gpio: remove unnecessary OOM messages Jingoo Han
2014-04-29  8:31 ` [PATCH 01/17] gpio: adp5520: " Jingoo Han
2014-04-29  8:32 ` [PATCH 02/17] gpio: adp5588: " Jingoo Han
2014-04-29  8:33 ` [PATCH 03/17] gpio: davinci: " Jingoo Han
2014-04-29  8:34 ` [PATCH 04/17] gpio: em: " Jingoo Han
2014-04-29  8:35 ` [PATCH 05/17] gpio: janz-ttl: " Jingoo Han
2014-04-29  8:36 ` [PATCH 06/17] gpio: lynxpoint: " Jingoo Han
2014-04-29  8:37 ` [PATCH 07/17] gpio: moxart: " Jingoo Han
2014-04-29  8:38 ` [PATCH 08/17] gpio: mvebu: " Jingoo Han
2014-04-29 11:25   ` Jason Cooper
2014-04-29  8:39 ` [PATCH 09/17] gpio: palmas: " Jingoo Han
2014-04-29  8:39 ` [PATCH 10/17] gpio: rc5t583: " Jingoo Han
2014-04-29  8:40 ` [PATCH 11/17] gpio: rcar: " Jingoo Han
2014-04-30  1:04   ` Laurent Pinchart
2014-04-29  8:42 ` [PATCH 12/17] gpio: rdc321x: " Jingoo Han
2014-04-29  8:42 ` [PATCH 13/17] gpio: SPEAr: " Jingoo Han
2014-04-29  8:47   ` Viresh Kumar
2014-04-29  8:44 ` [PATCH 14/17] gpio: tegra: " Jingoo Han
2014-04-29  8:44 ` [PATCH 15/17] gpio: tps6586x: " Jingoo Han
2014-04-29  8:45 ` [PATCH 16/17] gpio: tps65910: " Jingoo Han
2014-04-29  8:46 ` [PATCH 17/17] gpio: zevio: " Jingoo Han
2014-04-29  9:21 ` [PATCH 00/17] gpio: " Javier Martinez Canillas
2014-05-09  8:56 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).