From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"maz@kernel.org" <maz@kernel.org>,
Ben Brown <Ben.Brown@alliedtelesis.co.nz>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Avoid side effects in gpio_is_visible()
Date: Mon, 15 May 2023 21:01:23 +0000 [thread overview]
Message-ID: <00b3447d-ead2-c5c6-c38f-94d38fc8040b@alliedtelesis.co.nz> (raw)
In-Reply-To: <ZGHUjUpI-5JWNCAf@surfacebook>
On 15/05/23 18:43, andy.shevchenko@gmail.com wrote:
> Sun, May 14, 2023 at 09:57:58PM +0000, Chris Packham kirjoitti:
>> On 12/05/23 19:24, Johan Hovold wrote:
>>> On Fri, May 12, 2023 at 04:28:06PM +1200, Chris Packham wrote:
> ...
>
>>> You need a better explanation as to why this is an issue. What does the
>>> warning look like for example?
>> Ironically I had that in my first attempt to address the issue but was
>> told it was too much detail. So now I've gone too far the other way.
>> I'll include it in the response I'm about to send to LinusW.
> You have been (implicitly) told to reduce the scope of the details to have
> the only important ones, removing the traceback completely wasn't on the
> table.
>
> Citation: "Besides the very noisy traceback in the commit message (read
> https://kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages"
Yes fair point. I just over compensated an thought the explanation of
warning in gpiochip_disable_irq() was sufficient.
next prev parent reply other threads:[~2023-05-15 21:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 4:28 [PATCH] gpiolib: Avoid side effects in gpio_is_visible() Chris Packham
2023-05-12 7:24 ` Johan Hovold
2023-05-14 21:57 ` Chris Packham
2023-05-15 6:43 ` andy.shevchenko
2023-05-15 21:01 ` Chris Packham [this message]
2023-05-12 7:56 ` Linus Walleij
2023-05-14 22:27 ` Chris Packham
2023-05-16 13:57 ` Linus Walleij
2023-05-16 22:19 ` Chris Packham
2023-05-16 22:47 ` Kent Gibson
2023-05-16 23:50 ` Chris Packham
2023-05-17 0:47 ` Kent Gibson
2023-05-17 1:05 ` Kent Gibson
2023-05-17 1:07 ` Chris Packham
2023-05-17 1:21 ` Kent Gibson
2023-05-17 8:54 ` Andy Shevchenko
2023-05-17 9:10 ` Kent Gibson
2023-05-17 21:30 ` Chris Packham
2023-05-23 16:38 ` andy.shevchenko
2023-05-23 21:17 ` Chris Packham
2023-05-24 5:41 ` Kent Gibson
2023-05-24 23:53 ` using libgpiod to replace sysfs ABI (was Re: [PATCH] gpiolib: Avoid side effects in gpio_is_visible()) Chris Packham
2023-05-25 1:19 ` Kent Gibson
2023-05-25 9:13 ` Andy Shevchenko
2023-05-25 14:35 ` Bartosz Golaszewski
2023-05-26 12:46 ` [PATCH] gpiolib: Avoid side effects in gpio_is_visible() Bartosz Golaszewski
2023-05-28 21:04 ` Chris Packham
2023-05-29 9:19 ` Linus Walleij
2023-05-29 15:07 ` Andrew Lunn
2023-05-29 9:07 ` Linus Walleij
2023-05-29 22:00 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00b3447d-ead2-c5c6-c38f-94d38fc8040b@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=Ben.Brown@alliedtelesis.co.nz \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).