AW: [PATCH v3] i2c: i2c-gpio: Enhance driver for buses with shared SCL

["Markus Stockhausen" <markus.stockhausen@gmx.de>]

Hi all,

> Von: Bartosz Golaszewski <brgl@kernel.org> 
> Gesendet: Donnerstag, 21. Mai 2026 10:59
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Betreff: Re: [PATCH v3] i2c: i2c-gpio: Enhance driver for buses with shared SCL
> ...
> >  /*
> >   * Toggle SDA by changing the output value of the pin. This is only
> >   * valid for pins configured as open drain (i.e. setting the value @@ 
> > -53,7 +72,7 @@ static void i2c_gpio_setscl_val(void *data, int state)  
> > {
> >         struct i2c_gpio_private_data *priv = data;
> >
> > -       gpiod_set_value_cansleep(priv->scl, state);
> > +       gpiod_set_value_cansleep(priv->scl->gpio, state);
> 
> That one bothers me a bit. We're driving a clock line but may 
> end up sleeping? That doesn't sound right. We typically do:
>
> setscl();
> udelay();
>
> I know it's been like this before and maybe I'm not understanding 
> the whole picture so feel free to disregard the comment.

ATM I can only ignore that because I have no idea what this code 
is about. Maybe soneone in CC can advise how to handle Bartosz's
question.

> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Thanks for that.

Markus