From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
mazziesaccount@gmail.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: pinctrl: cy8x95x0: Minor fix & update
Date: Tue, 30 Jan 2024 13:31:37 +0100 [thread overview]
Message-ID: <021f3f6f-0aa9-41c2-a220-b1e6efad2880@linaro.org> (raw)
In-Reply-To: <CABqG17in2+0eHMRBvyunWKizgSBpYPq+CGsMO7FQo13pApPvaw@mail.gmail.com>
On 30/01/2024 13:26, Naresh Solanki wrote:
> Hi Krzysztof,
>
> On Tue, 30 Jan 2024 at 17:49, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 30/01/2024 13:08, Naresh Solanki wrote:
>>> Update maxItems to 60 for gpio-reserved-ranges to allow multiple gpio
>>> reserved ranges.
>>> Add input-enable property to allow configuring a pin as input.
>>> Rearrange allOf
>>
>> Why?
> allOf is aligned with other implementations.
Which ones? example-schema and other implementations have it in
different place. If you align some parts of the code, please align to
match the correct code, not other incorrect. How to find it?
example-schema is the reference, recent commits are also sometimes good
indication.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-30 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 12:08 [PATCH v2] dt-bindings: pinctrl: cy8x95x0: Minor fix & update Naresh Solanki
2024-01-30 12:19 ` Krzysztof Kozlowski
2024-01-30 12:26 ` Naresh Solanki
2024-01-30 12:31 ` Krzysztof Kozlowski [this message]
2024-01-30 12:35 ` Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=021f3f6f-0aa9-41c2-a220-b1e6efad2880@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).