linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Kconfig dangling references (BZ 216748)
@ 2025-12-08  2:04 Randy Dunlap
  2025-12-08  8:04 ` Matti Vaittinen
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Randy Dunlap @ 2025-12-08  2:04 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: Andy Shevchenko, Arnd Bergmann, andrew.jones, linux-omap, openbmc,
	linux-sound, Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, Paul Kocialkowski,
	chrome-platform, Paul Cercueil, linux-stm32, Linux ARM,
	linux-gpio, Srinivas Kandagatla, Philipp Zabel, Matti Vaittinen,
	Jonathan Cameron, Vaibhav Hiremath, linux-sh, x86, Max Filippov

from  https://bugzilla.kernel.org/show_bug.cgi?id=216748

The bugzilla entry includes a Perl script and a shell script.
This is the edited result of running them (I removed some entries that were noise).

I'll try to Cc: all of the relevant mailing lists or individuals.


ARCH_HAS_HOLES_MEMORYMODEL ---
arch/arm/mach-omap1/Kconfig:7:	select ARCH_HAS_HOLES_MEMORYMODEL

ARM_ERRATA_794072 ---
arch/arm/mach-npcm/Kconfig:33:	select ARM_ERRATA_794072

ARM_SMC_MBOX ---
arch/arm64/Kconfig.platforms:375:	select ARM_SMC_MBOX

CLK_FIXED_FCH ---
sound/soc/amd/Kconfig:11:	select CLK_FIXED_FCH
sound/soc/amd/Kconfig:48:	select CLK_FIXED_FCH
sound/soc/amd/acp/Kconfig:107:	select CLK_FIXED_FCH

CONFIG_STM ---
drivers/hwtracing/stm/Kconfig:16:	default CONFIG_STM  # should be STM
drivers/hwtracing/stm/Kconfig:31:	default CONFIG_STM

CPU_HAS_LOAD_STORE_LR ---
arch/mips/Kconfig:1411:	select CPU_HAS_LOAD_STORE_LR

DRM_KMS_DMA_HELPER ---
drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER

EXTCON_TCSS_CROS_EC ---
drivers/usb/typec/ucsi/Kconfig:76:	depends on !EXTCON_TCSS_CROS_EC

MACH_JZ4755 ---
drivers/clk/ingenic/Kconfig:20:	default MACH_JZ4755
drivers/pinctrl/pinctrl-ingenic.c:158:	IS_ENABLED(CONFIG_MACH_JZ4755) << ID_JZ4755 |
drivers/pinctrl/pinctrl-ingenic.c:4616:		.data = IF_ENABLED(CONFIG_MACH_JZ4755, &jz4755_chip_info)

MACH_JZ4760 ---
drivers/clk/ingenic/Kconfig:40:	default MACH_JZ4760
drivers/pinctrl/pinctrl-ingenic.c:159:	IS_ENABLED(CONFIG_MACH_JZ4760) << ID_JZ4760 |
drivers/pinctrl/pinctrl-ingenic.c:4620:		.data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
drivers/pinctrl/pinctrl-ingenic.c:4624:		.data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)

MACH_STM32MP25 ---
drivers/pinctrl/stm32/Kconfig:58:	default MACH_STM32MP25 || (ARCH_STM32 && ARM64)

MFD_AIROHA_AN8855 ---
drivers/nvmem/Kconfig:33:	depends on MFD_AIROHA_AN8855 || COMPILE_TEST

MFD_TN48M_CPLD ---
drivers/gpio/Kconfig:1624:	depends on MFD_TN48M_CPLD || COMPILE_TEST
drivers/reset/Kconfig:365:	depends on MFD_TN48M_CPLD || COMPILE_TEST
drivers/reset/Kconfig:366:	default MFD_TN48M_CPLD

MIPS_BAIKAL_T1 ---
drivers/ata/Kconfig:197:	select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
drivers/bus/Kconfig:43:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
drivers/bus/Kconfig:58:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
drivers/clk/baikal-t1/Kconfig:4:	depends on (MIPS_BAIKAL_T1 && OF) || COMPILE_TEST
drivers/clk/baikal-t1/Kconfig:5:	default MIPS_BAIKAL_T1
drivers/clk/baikal-t1/Kconfig:20:	default MIPS_BAIKAL_T1
drivers/clk/baikal-t1/Kconfig:33:	default MIPS_BAIKAL_T1
drivers/clk/baikal-t1/Kconfig:45:	default MIPS_BAIKAL_T1
drivers/hwmon/Kconfig:462:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
drivers/i2c/busses/Kconfig:589:	select MFD_SYSCON if MIPS_BAIKAL_T1
drivers/memory/Kconfig:69:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
drivers/mtd/maps/Kconfig:81:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
drivers/pci/controller/dwc/Kconfig:89:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
drivers/spi/Kconfig:370:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST

PINCTRL_MILBEAUT ---
arch/arm/mach-milbeaut/Kconfig:16:	select PINCTRL_MILBEAUT

SND_SOC_AC97_BUS_NEW ---
sound/soc/pxa/Kconfig:21:	select SND_SOC_AC97_BUS_NEW

SND_SOC_CS35L56_CAL_SYSFS_COMMON ---
sound/soc/codecs/Kconfig:920:	select SND_SOC_CS35L56_CAL_SYSFS_COMMON

TEST_KUNIT_DEVICE_HELPERS ---
drivers/iio/test/Kconfig:11:	select TEST_KUNIT_DEVICE_HELPERS

USB_HSIC_USB3613 ---
drivers/staging/greybus/Kconfig:209:	depends on USB_HSIC_USB3613 || COMPILE_TEST
drivers/staging/greybus/arche-platform.c:26:#if IS_ENABLED(CONFIG_USB_HSIC_USB3613)

USB_OHCI_SH ---
arch/sh/Kconfig:334:	select USB_OHCI_SH if USB_OHCI_HCD
arch/sh/Kconfig:344:	select USB_OHCI_SH if USB_OHCI_HCD
arch/sh/Kconfig:429:	select USB_OHCI_SH if USB_OHCI_HCD
arch/sh/Kconfig:455:	select USB_OHCI_SH if USB_OHCI_HCD
arch/sh/configs/sh7757lcr_defconfig:61:CONFIG_USB_OHCI_SH=y

X86_P6_NOP ---
arch/x86/Kconfig.cpufeatures:41:	depends on X86_64 || X86_P6_NOP
arch/x86/Makefile_32.cpu:48:ifneq ($(CONFIG_X86_P6_NOP),y)

XTENSA_PLATFORM_ESP32 ---
drivers/tty/serial/Kconfig:1598:	depends on XTENSA_PLATFORM_ESP32 || (COMPILE_TEST && OF)
drivers/tty/serial/Kconfig:1611:	depends on XTENSA_PLATFORM_ESP32 || (COMPILE_TEST && OF)


-- 
~Randy


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08  2:04 Kconfig dangling references (BZ 216748) Randy Dunlap
@ 2025-12-08  8:04 ` Matti Vaittinen
  2025-12-08  8:55 ` Arnd Bergmann
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: Matti Vaittinen @ 2025-12-08  8:04 UTC (permalink / raw)
  To: Randy Dunlap, Linux Kernel Mailing List
  Cc: Andy Shevchenko, Arnd Bergmann, andrew.jones, linux-omap, openbmc,
	linux-sound, Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, Paul Kocialkowski,
	chrome-platform, Paul Cercueil, linux-stm32, Linux ARM,
	linux-gpio, Srinivas Kandagatla, Philipp Zabel, Jonathan Cameron,
	Vaibhav Hiremath, linux-sh, x86, Max Filippov

On 08/12/2025 04:04, Randy Dunlap wrote:
> from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> 
> The bugzilla entry includes a Perl script and a shell script.
> This is the edited result of running them (I removed some entries that were noise).
> 
> I'll try to Cc: all of the relevant mailing lists or individuals.
> 

Thanks Randy! This is good.

> TEST_KUNIT_DEVICE_HELPERS ---
> drivers/iio/test/Kconfig:11:	select TEST_KUNIT_DEVICE_HELPERS
This is a config for stuff that never went upstream. It was replaced by 
more sophisticated kunit_device, which I believe is behind the 
'CONFIG_KUNIT'. So, this should be dropped, thanks!

Yours,
	-- Matti

---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08  2:04 Kconfig dangling references (BZ 216748) Randy Dunlap
  2025-12-08  8:04 ` Matti Vaittinen
@ 2025-12-08  8:55 ` Arnd Bergmann
  2025-12-08  9:48   ` [Linux-stm32] " Antonio Borneo
  2025-12-08  9:06 ` Takashi Iwai
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2025-12-08  8:55 UTC (permalink / raw)
  To: Randy Dunlap, Linux Kernel Mailing List
  Cc: Andy Shevchenko, andrew.jones, Linux-OMAP, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, Paul Kocialkowski,
	chrome-platform, Paul Cercueil, linux-stm32, Linux ARM,
	open list:GPIO SUBSYSTEM, Srinivas Kandagatla, Philipp Zabel,
	Matti Vaittinen, Jonathan Cameron, Vaibhav Hiremath, linux-sh,
	x86, Max Filippov

On Mon, Dec 8, 2025, at 03:04, Randy Dunlap wrote:
> from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
>
> The bugzilla entry includes a Perl script and a shell script.
> This is the edited result of running them (I removed some entries that 
> were noise).
>
> I'll try to Cc: all of the relevant mailing lists or individuals.
>
>
> ARCH_HAS_HOLES_MEMORYMODEL ---
> arch/arm/mach-omap1/Kconfig:7:	select ARCH_HAS_HOLES_MEMORYMODEL

My mistake, this was a botched rebase.

> ARM_ERRATA_794072 ---
> arch/arm/mach-npcm/Kconfig:33:	select ARM_ERRATA_794072

This apparently never made it upstream because it was unreliable
https://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/244343.html

> MACH_JZ4755 ---
> drivers/clk/ingenic/Kconfig:20:	default MACH_JZ4755
> drivers/pinctrl/pinctrl-ingenic.c:158:	IS_ENABLED(CONFIG_MACH_JZ4755) 
> << ID_JZ4755 |
> drivers/pinctrl/pinctrl-ingenic.c:4616:		.data = 
> IF_ENABLED(CONFIG_MACH_JZ4755, &jz4755_chip_info)
>
> MACH_JZ4760 ---
> drivers/clk/ingenic/Kconfig:40:	default MACH_JZ4760
> drivers/pinctrl/pinctrl-ingenic.c:159:	IS_ENABLED(CONFIG_MACH_JZ4760) 
> << ID_JZ4760 |
> drivers/pinctrl/pinctrl-ingenic.c:4620:		.data = 
> IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
> drivers/pinctrl/pinctrl-ingenic.c:4624:		.data = 
> IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
>
> MACH_STM32MP25 ---
> drivers/pinctrl/stm32/Kconfig:58:	default MACH_STM32MP25 || (ARCH_STM32 
> && ARM64)

This was likely intended for 32-bit kernels on 64-bit STM32MP25
chips, which we don't support. I think this can go.

> MIPS_BAIKAL_T1 ---
> drivers/ata/Kconfig:197:	select MFD_SYSCON if (MIPS_BAIKAL_T1 || 
> COMPILE_TEST)
> drivers/bus/Kconfig:43:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> drivers/bus/Kconfig:58:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> drivers/clk/baikal-t1/Kconfig:4:	depends on (MIPS_BAIKAL_T1 && OF) || 

I don't think we'll merge the rest of Baikal, we should probably
remove the entire platform.

> PINCTRL_MILBEAUT ---
> arch/arm/mach-milbeaut/Kconfig:16:	select PINCTRL_MILBEAUT

Same for Milbeaut

> USB_OHCI_SH ---
> arch/sh/Kconfig:334:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/Kconfig:344:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/Kconfig:429:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/Kconfig:455:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/configs/sh7757lcr_defconfig:61:CONFIG_USB_OHCI_SH=y

Should have been removed as part of 7518f0763ecd ("sh: convert
boards to use the OHCI platform driver")

> X86_P6_NOP ---
> arch/x86/Kconfig.cpufeatures:41:	depends on X86_64 || X86_P6_NOP
> arch/x86/Makefile_32.cpu:48:ifneq ($(CONFIG_X86_P6_NOP),y)

I missed this in f388f60ca904 ("x86/cpu: Drop configuration options
for early 64-bit CPUs"). Both references can be removed, because
p6-nop was already disallowed for 32-bit CPUs at the time.

I don't know if any supported binutils still require -mtune=generic32

> XTENSA_PLATFORM_ESP32 ---
> drivers/tty/serial/Kconfig:1598:	depends on XTENSA_PLATFORM_ESP32 || 
> (COMPILE_TEST && OF)
> drivers/tty/serial/Kconfig:1611:	depends on XTENSA_PLATFORM_ESP32 || 
> (COMPILE_TEST && OF)

Max is still working on esp32 support as far as I know, it's just
slow progress, see
https://github.com/jcmvbkbc/linux-xtensa/commits/xtensa-6.16-esp32

       Arnd

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08  2:04 Kconfig dangling references (BZ 216748) Randy Dunlap
  2025-12-08  8:04 ` Matti Vaittinen
  2025-12-08  8:55 ` Arnd Bergmann
@ 2025-12-08  9:06 ` Takashi Iwai
  2025-12-09  9:36   ` Richard Fitzgerald
  2025-12-08 18:13 ` Paul Kocialkowski
  2025-12-10 13:06 ` Paul Cercueil
  4 siblings, 1 reply; 11+ messages in thread
From: Takashi Iwai @ 2025-12-08  9:06 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, Andy Shevchenko, Arnd Bergmann,
	andrew.jones, linux-omap, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, Paul Kocialkowski,
	chrome-platform, Paul Cercueil, linux-stm32, Linux ARM,
	linux-gpio, Srinivas Kandagatla, Philipp Zabel, Matti Vaittinen,
	Jonathan Cameron, Vaibhav Hiremath, linux-sh, x86, Max Filippov

On Mon, 08 Dec 2025 03:04:09 +0100,
Randy Dunlap wrote:
> 
> SND_SOC_AC97_BUS_NEW ---
> sound/soc/pxa/Kconfig:21:	select SND_SOC_AC97_BUS_NEW

This must be a bogus entry added in commit 1c8bc7b3de5e ("ASoC: pxa:
switch to new ac97 bus support"), which can be dropped.

> SND_SOC_CS35L56_CAL_SYSFS_COMMON ---
> sound/soc/codecs/Kconfig:920:	select SND_SOC_CS35L56_CAL_SYSFS_COMMON

The buggy commit was 32172cf3cb54 ("ASoC: cs35l56: Allow restoring
factory calibration through ALSA control").
This looks like a fallout at changing from sysfs to debugfs, so this
should be SND_SOC_CS35L56_CAL_DEBUGFS_COMMON instead.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Linux-stm32] Kconfig dangling references (BZ 216748)
  2025-12-08  8:55 ` Arnd Bergmann
@ 2025-12-08  9:48   ` Antonio Borneo
  0 siblings, 0 replies; 11+ messages in thread
From: Antonio Borneo @ 2025-12-08  9:48 UTC (permalink / raw)
  To: Arnd Bergmann, Randy Dunlap, Linux Kernel Mailing List
  Cc: linux-sh, Alexander Shishkin, Vaibhav Hiremath,
	dri-devel@lists.freedesktop.org, andrew.jones, Paul Cercueil,
	Max Filippov, linux-stm32, chrome-platform, openbmc, x86,
	Andy Shevchenko, Matti Vaittinen, Philipp Zabel,
	Paul Kocialkowski, linux-sound, open list:GPIO SUBSYSTEM,
	Linux-OMAP, Linux ARM, linux-mips, asahi, Srinivas Kandagatla,
	Jonathan Cameron

On Mon, 2025-12-08 at 09:55 +0100, Arnd Bergmann wrote:
> On Mon, Dec 8, 2025, at 03:04, Randy Dunlap wrote:
> > from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> > 
> > The bugzilla entry includes a Perl script and a shell script.
> > This is the edited result of running them (I removed some entries that 
> > were noise).
> > 
> > I'll try to Cc: all of the relevant mailing lists or individuals.
> > 
> > ...
> > 
> > MACH_STM32MP25 ---
> > drivers/pinctrl/stm32/Kconfig:58:       default MACH_STM32MP25 || (ARCH_STM32 
> > && ARM64)
> 
> This was likely intended for 32-bit kernels on 64-bit STM32MP25
> chips, which we don't support. I think this can go.

Yes, I fully agree!

I have a series pinctrl stm32 to be rebased on v6.19-rc1 and I can include the
drop of MACH_STM32MP25 inside it.

Thanks,
Antonio

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08  2:04 Kconfig dangling references (BZ 216748) Randy Dunlap
                   ` (2 preceding siblings ...)
  2025-12-08  9:06 ` Takashi Iwai
@ 2025-12-08 18:13 ` Paul Kocialkowski
  2025-12-08 18:39   ` Randy Dunlap
  2025-12-08 20:05   ` Janne Grunau
  2025-12-10 13:06 ` Paul Cercueil
  4 siblings, 2 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2025-12-08 18:13 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, Andy Shevchenko, Arnd Bergmann,
	andrew.jones, linux-omap, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, chrome-platform, Paul Cercueil,
	linux-stm32, Linux ARM, linux-gpio, Srinivas Kandagatla,
	Philipp Zabel, Matti Vaittinen, Jonathan Cameron,
	Vaibhav Hiremath, linux-sh, x86, Max Filippov

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Hi Randy,

On Sun 07 Dec 25, 18:04, Randy Dunlap wrote:
> from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> 
> The bugzilla entry includes a Perl script and a shell script.
> This is the edited result of running them (I removed some entries that were noise).

[...]

> DRM_KMS_DMA_HELPER ---
> drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
> drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER

For these two, the symbol was removed in commit
09717af7d13d63df141ae6e71686289989d17efd but these two drivers either were
missed by the batch rename or were introduced a bit later.

Since the symbol selected DRM_GEM_CMA_HELPER (which is still needed by the
drivers), it should be replaced with DRM_GEM_CMA_HELPER.

Are you expecting to craft a patch for fixing this or should I do it myself?

All the best,

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08 18:13 ` Paul Kocialkowski
@ 2025-12-08 18:39   ` Randy Dunlap
  2025-12-08 20:05   ` Janne Grunau
  1 sibling, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2025-12-08 18:39 UTC (permalink / raw)
  To: Paul Kocialkowski
  Cc: Linux Kernel Mailing List, Andy Shevchenko, Arnd Bergmann,
	andrew.jones, linux-omap, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, chrome-platform, Paul Cercueil,
	linux-stm32, Linux ARM, linux-gpio, Srinivas Kandagatla,
	Philipp Zabel, Matti Vaittinen, Jonathan Cameron,
	Vaibhav Hiremath, linux-sh, x86, Max Filippov



On 12/8/25 10:13 AM, Paul Kocialkowski wrote:
> Hi Randy,
> 
> On Sun 07 Dec 25, 18:04, Randy Dunlap wrote:
>> from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
>>
>> The bugzilla entry includes a Perl script and a shell script.
>> This is the edited result of running them (I removed some entries that were noise).
> 
> [...]
> 
>> DRM_KMS_DMA_HELPER ---
>> drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
>> drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER
> 
> For these two, the symbol was removed in commit
> 09717af7d13d63df141ae6e71686289989d17efd but these two drivers either were
> missed by the batch rename or were introduced a bit later.
> 
> Since the symbol selected DRM_GEM_CMA_HELPER (which is still needed by the
> drivers), it should be replaced with DRM_GEM_CMA_HELPER.
> 
> Are you expecting to craft a patch for fixing this or should I do it myself?

Hi Paul,
Please take care of it yourself.

Thanks.
-- 
~Randy


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08 18:13 ` Paul Kocialkowski
  2025-12-08 18:39   ` Randy Dunlap
@ 2025-12-08 20:05   ` Janne Grunau
  2025-12-10 22:09     ` Paul Kocialkowski
  1 sibling, 1 reply; 11+ messages in thread
From: Janne Grunau @ 2025-12-08 20:05 UTC (permalink / raw)
  To: Paul Kocialkowski
  Cc: Randy Dunlap, Linux Kernel Mailing List, Andy Shevchenko,
	Arnd Bergmann, andrew.jones, linux-omap, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, chrome-platform, Paul Cercueil,
	linux-stm32, Linux ARM, linux-gpio, Srinivas Kandagatla,
	Philipp Zabel, Matti Vaittinen, Jonathan Cameron,
	Vaibhav Hiremath, linux-sh, x86, Max Filippov

On Mon, Dec 08, 2025 at 07:13:50PM +0100, Paul Kocialkowski wrote:
> Hi Randy,
> 
> On Sun 07 Dec 25, 18:04, Randy Dunlap wrote:
> > from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> > 
> > The bugzilla entry includes a Perl script and a shell script.
> > This is the edited result of running them (I removed some entries that were noise).
> 
> [...]
> 
> > DRM_KMS_DMA_HELPER ---
> > drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
> > drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER
> 
> For these two, the symbol was removed in commit
> 09717af7d13d63df141ae6e71686289989d17efd

That commit removed DRM_KMS_CMA_HELPER. Later commit 6bcfe8eaeef0
("drm/fb: rename FB CMA helpers to FB DMA helpers") renamed
DRM_KMS_CMA_HELPER erroneously to DRM_KMS_DMA_HELPER.

> but these two drivers either were
> missed by the batch rename or were introduced a bit later.

In the case of drivers/gpu/drm/adp/Kconfig it was missed much later
during review (but iirc went through the same rename out of tree).

> Since the symbol selected DRM_GEM_CMA_HELPER (which is still needed by the
> drivers), it should be replaced with DRM_GEM_CMA_HELPER.

That symbol doesn't exist anymore either. It's now DRM_GEM_DMA_HELPER
which is already present in both files.

So the "select DRM_KMS_DMA_HELPER" lines can be removed from both files.

Janne

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08  9:06 ` Takashi Iwai
@ 2025-12-09  9:36   ` Richard Fitzgerald
  0 siblings, 0 replies; 11+ messages in thread
From: Richard Fitzgerald @ 2025-12-09  9:36 UTC (permalink / raw)
  To: Takashi Iwai, Randy Dunlap
  Cc: Linux Kernel Mailing List, Andy Shevchenko, Arnd Bergmann,
	andrew.jones, linux-omap, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, Paul Kocialkowski,
	chrome-platform, Paul Cercueil, linux-stm32, Linux ARM,
	linux-gpio, Srinivas Kandagatla, Philipp Zabel, Matti Vaittinen,
	Jonathan Cameron, Vaibhav Hiremath, linux-sh, x86, Max Filippov

On 08/12/2025 9:06 am, Takashi Iwai wrote:
> On Mon, 08 Dec 2025 03:04:09 +0100,
> Randy Dunlap wrote:
>>
>> SND_SOC_AC97_BUS_NEW ---
>> sound/soc/pxa/Kconfig:21:	select SND_SOC_AC97_BUS_NEW
> 
> This must be a bogus entry added in commit 1c8bc7b3de5e ("ASoC: pxa:
> switch to new ac97 bus support"), which can be dropped.
> 
>> SND_SOC_CS35L56_CAL_SYSFS_COMMON ---
>> sound/soc/codecs/Kconfig:920:	select SND_SOC_CS35L56_CAL_SYSFS_COMMON
> 
> The buggy commit was 32172cf3cb54 ("ASoC: cs35l56: Allow restoring
> factory calibration through ALSA control").
> This looks like a fallout at changing from sysfs to debugfs, so this
> should be SND_SOC_CS35L56_CAL_DEBUGFS_COMMON instead.
> 
> 

Oh! I checked multiple times that I'd changed all the sysfs to debugfs
and this STILL got through. I'll send a fix.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08  2:04 Kconfig dangling references (BZ 216748) Randy Dunlap
                   ` (3 preceding siblings ...)
  2025-12-08 18:13 ` Paul Kocialkowski
@ 2025-12-10 13:06 ` Paul Cercueil
  4 siblings, 0 replies; 11+ messages in thread
From: Paul Cercueil @ 2025-12-10 13:06 UTC (permalink / raw)
  To: Randy Dunlap, Linux Kernel Mailing List
  Cc: Andy Shevchenko, Arnd Bergmann, andrew.jones, linux-omap, openbmc,
	linux-sound, Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, Paul Kocialkowski,
	chrome-platform, linux-stm32, Linux ARM, linux-gpio,
	Srinivas Kandagatla, Philipp Zabel, Matti Vaittinen,
	Jonathan Cameron, Vaibhav Hiremath, linux-sh, x86, Max Filippov

Hi Randy,

Le dimanche 07 décembre 2025 à 18:04 -0800, Randy Dunlap a écrit :
> from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> 
> The bugzilla entry includes a Perl script and a shell script.
> This is the edited result of running them (I removed some entries
> that were noise).
> 
> I'll try to Cc: all of the relevant mailing lists or individuals.
> 
> 
> ARCH_HAS_HOLES_MEMORYMODEL ---
> arch/arm/mach-omap1/Kconfig:7:	select ARCH_HAS_HOLES_MEMORYMODEL
> 
> ARM_ERRATA_794072 ---
> arch/arm/mach-npcm/Kconfig:33:	select ARM_ERRATA_794072
> 
> ARM_SMC_MBOX ---
> arch/arm64/Kconfig.platforms:375:	select ARM_SMC_MBOX
> 
> CLK_FIXED_FCH ---
> sound/soc/amd/Kconfig:11:	select CLK_FIXED_FCH
> sound/soc/amd/Kconfig:48:	select CLK_FIXED_FCH
> sound/soc/amd/acp/Kconfig:107:	select CLK_FIXED_FCH
> 
> CONFIG_STM ---
> drivers/hwtracing/stm/Kconfig:16:	default CONFIG_STM  # should
> be STM
> drivers/hwtracing/stm/Kconfig:31:	default CONFIG_STM
> 
> CPU_HAS_LOAD_STORE_LR ---
> arch/mips/Kconfig:1411:	select CPU_HAS_LOAD_STORE_LR
> 
> DRM_KMS_DMA_HELPER ---
> drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
> drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER
> 
> EXTCON_TCSS_CROS_EC ---
> drivers/usb/typec/ucsi/Kconfig:76:	depends on
> !EXTCON_TCSS_CROS_EC
> 
> MACH_JZ4755 ---
> drivers/clk/ingenic/Kconfig:20:	default MACH_JZ4755
> drivers/pinctrl/pinctrl-
> ingenic.c:158:	IS_ENABLED(CONFIG_MACH_JZ4755) << ID_JZ4755 |
> drivers/pinctrl/pinctrl-ingenic.c:4616:		.data =
> IF_ENABLED(CONFIG_MACH_JZ4755, &jz4755_chip_info)
> 
> MACH_JZ4760 ---
> drivers/clk/ingenic/Kconfig:40:	default MACH_JZ4760
> drivers/pinctrl/pinctrl-
> ingenic.c:159:	IS_ENABLED(CONFIG_MACH_JZ4760) << ID_JZ4760 |
> drivers/pinctrl/pinctrl-ingenic.c:4620:		.data =
> IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
> drivers/pinctrl/pinctrl-ingenic.c:4624:		.data =
> IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)

Those were added when upstreaming support for the JZ4755/JZ4760, but
the DTS files and actual support in arch/mips/ was never sent.

Instead of dropping those, I'll try to upstream the basic support for
those SoCs in the coming days.

Cheers,
-Paul

> 
> MACH_STM32MP25 ---
> drivers/pinctrl/stm32/Kconfig:58:	default MACH_STM32MP25 ||
> (ARCH_STM32 && ARM64)
> 
> MFD_AIROHA_AN8855 ---
> drivers/nvmem/Kconfig:33:	depends on MFD_AIROHA_AN8855 ||
> COMPILE_TEST
> 
> MFD_TN48M_CPLD ---
> drivers/gpio/Kconfig:1624:	depends on MFD_TN48M_CPLD ||
> COMPILE_TEST
> drivers/reset/Kconfig:365:	depends on MFD_TN48M_CPLD ||
> COMPILE_TEST
> drivers/reset/Kconfig:366:	default MFD_TN48M_CPLD
> 
> MIPS_BAIKAL_T1 ---
> drivers/ata/Kconfig:197:	select MFD_SYSCON if (MIPS_BAIKAL_T1
> || COMPILE_TEST)
> drivers/bus/Kconfig:43:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> drivers/bus/Kconfig:58:	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> drivers/clk/baikal-t1/Kconfig:4:	depends on (MIPS_BAIKAL_T1
> && OF) || COMPILE_TEST
> drivers/clk/baikal-t1/Kconfig:5:	default MIPS_BAIKAL_T1
> drivers/clk/baikal-t1/Kconfig:20:	default MIPS_BAIKAL_T1
> drivers/clk/baikal-t1/Kconfig:33:	default MIPS_BAIKAL_T1
> drivers/clk/baikal-t1/Kconfig:45:	default MIPS_BAIKAL_T1
> drivers/hwmon/Kconfig:462:	depends on MIPS_BAIKAL_T1 ||
> COMPILE_TEST
> drivers/i2c/busses/Kconfig:589:	select MFD_SYSCON if MIPS_BAIKAL_T1
> drivers/memory/Kconfig:69:	depends on MIPS_BAIKAL_T1 ||
> COMPILE_TEST
> drivers/mtd/maps/Kconfig:81:	depends on MIPS_BAIKAL_T1 ||
> COMPILE_TEST
> drivers/pci/controller/dwc/Kconfig:89:	depends on MIPS_BAIKAL_T1 ||
> COMPILE_TEST
> drivers/spi/Kconfig:370:	depends on MIPS_BAIKAL_T1 ||
> COMPILE_TEST
> 
> PINCTRL_MILBEAUT ---
> arch/arm/mach-milbeaut/Kconfig:16:	select PINCTRL_MILBEAUT
> 
> SND_SOC_AC97_BUS_NEW ---
> sound/soc/pxa/Kconfig:21:	select SND_SOC_AC97_BUS_NEW
> 
> SND_SOC_CS35L56_CAL_SYSFS_COMMON ---
> sound/soc/codecs/Kconfig:920:	select
> SND_SOC_CS35L56_CAL_SYSFS_COMMON
> 
> TEST_KUNIT_DEVICE_HELPERS ---
> drivers/iio/test/Kconfig:11:	select TEST_KUNIT_DEVICE_HELPERS
> 
> USB_HSIC_USB3613 ---
> drivers/staging/greybus/Kconfig:209:	depends on USB_HSIC_USB3613
> || COMPILE_TEST
> drivers/staging/greybus/arche-platform.c:26:#if
> IS_ENABLED(CONFIG_USB_HSIC_USB3613)
> 
> USB_OHCI_SH ---
> arch/sh/Kconfig:334:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/Kconfig:344:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/Kconfig:429:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/Kconfig:455:	select USB_OHCI_SH if USB_OHCI_HCD
> arch/sh/configs/sh7757lcr_defconfig:61:CONFIG_USB_OHCI_SH=y
> 
> X86_P6_NOP ---
> arch/x86/Kconfig.cpufeatures:41:	depends on X86_64 ||
> X86_P6_NOP
> arch/x86/Makefile_32.cpu:48:ifneq ($(CONFIG_X86_P6_NOP),y)
> 
> XTENSA_PLATFORM_ESP32 ---
> drivers/tty/serial/Kconfig:1598:	depends on
> XTENSA_PLATFORM_ESP32 || (COMPILE_TEST && OF)
> drivers/tty/serial/Kconfig:1611:	depends on
> XTENSA_PLATFORM_ESP32 || (COMPILE_TEST && OF)
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Kconfig dangling references (BZ 216748)
  2025-12-08 20:05   ` Janne Grunau
@ 2025-12-10 22:09     ` Paul Kocialkowski
  0 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2025-12-10 22:09 UTC (permalink / raw)
  To: Janne Grunau
  Cc: Randy Dunlap, Linux Kernel Mailing List, Andy Shevchenko,
	Arnd Bergmann, andrew.jones, linux-omap, openbmc, linux-sound,
	Alexander Shishkin, linux-mips, asahi,
	dri-devel@lists.freedesktop.org, chrome-platform, Paul Cercueil,
	linux-stm32, Linux ARM, linux-gpio, Srinivas Kandagatla,
	Philipp Zabel, Matti Vaittinen, Jonathan Cameron,
	Vaibhav Hiremath, linux-sh, x86, Max Filippov

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

Hi Janne,

Le Mon 08 Dec 25, 21:05, Janne Grunau a écrit :
> On Mon, Dec 08, 2025 at 07:13:50PM +0100, Paul Kocialkowski wrote:
> > Hi Randy,
> > 
> > On Sun 07 Dec 25, 18:04, Randy Dunlap wrote:
> > > from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> > > 
> > > The bugzilla entry includes a Perl script and a shell script.
> > > This is the edited result of running them (I removed some entries that were noise).
> > 
> > [...]
> > 
> > > DRM_KMS_DMA_HELPER ---
> > > drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
> > > drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER
> > 
> > For these two, the symbol was removed in commit
> > 09717af7d13d63df141ae6e71686289989d17efd
> 
> That commit removed DRM_KMS_CMA_HELPER. Later commit 6bcfe8eaeef0
> ("drm/fb: rename FB CMA helpers to FB DMA helpers") renamed
> DRM_KMS_CMA_HELPER erroneously to DRM_KMS_DMA_HELPER.
> 
> > but these two drivers either were
> > missed by the batch rename or were introduced a bit later.
> 
> In the case of drivers/gpu/drm/adp/Kconfig it was missed much later
> during review (but iirc went through the same rename out of tree).
> 
> > Since the symbol selected DRM_GEM_CMA_HELPER (which is still needed by the
> > drivers), it should be replaced with DRM_GEM_CMA_HELPER.
> 
> That symbol doesn't exist anymore either. It's now DRM_GEM_DMA_HELPER
> which is already present in both files.

Thanks for the details! It seems that I was looking at an older tree.

> So the "select DRM_KMS_DMA_HELPER" lines can be removed from both files.

Good, then I'll craft a patch removing these two lines.

All the best,

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-12-10 22:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-08  2:04 Kconfig dangling references (BZ 216748) Randy Dunlap
2025-12-08  8:04 ` Matti Vaittinen
2025-12-08  8:55 ` Arnd Bergmann
2025-12-08  9:48   ` [Linux-stm32] " Antonio Borneo
2025-12-08  9:06 ` Takashi Iwai
2025-12-09  9:36   ` Richard Fitzgerald
2025-12-08 18:13 ` Paul Kocialkowski
2025-12-08 18:39   ` Randy Dunlap
2025-12-08 20:05   ` Janne Grunau
2025-12-10 22:09     ` Paul Kocialkowski
2025-12-10 13:06 ` Paul Cercueil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).