* [PATCH 2/7] gpio: mcp23s08: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
@ 2014-05-07 9:05 ` Jingoo Han
2014-05-09 8:59 ` Linus Walleij
2014-05-07 9:06 ` [PATCH 3/7] gpio: mvebu: " Jingoo Han
` (6 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Jingoo Han @ 2014-05-07 9:05 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-mcp23s08.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index 3d53fd6..4d677f1 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -714,7 +714,7 @@ fail:
#ifdef CONFIG_OF
#ifdef CONFIG_SPI_MASTER
-static struct of_device_id mcp23s08_spi_of_match[] = {
+static const struct of_device_id mcp23s08_spi_of_match[] = {
{
.compatible = "microchip,mcp23s08",
.data = (void *) MCP_TYPE_S08,
@@ -738,7 +738,7 @@ MODULE_DEVICE_TABLE(of, mcp23s08_spi_of_match);
#endif
#if IS_ENABLED(CONFIG_I2C)
-static struct of_device_id mcp23s08_i2c_of_match[] = {
+static const struct of_device_id mcp23s08_i2c_of_match[] = {
{
.compatible = "microchip,mcp23008",
.data = (void *) MCP_TYPE_008,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/7] gpio: mvebu: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
2014-05-07 9:05 ` [PATCH 2/7] gpio: mcp23s08: " Jingoo Han
@ 2014-05-07 9:06 ` Jingoo Han
2014-05-09 9:01 ` Linus Walleij
2014-05-07 9:06 ` [PATCH 4/7] gpio: palmas: " Jingoo Han
` (5 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Jingoo Han @ 2014-05-07 9:06 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Jason Cooper', 'Thomas Petazzoni'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-mvebu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index d425094..b5d8645 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -535,7 +535,7 @@ static void mvebu_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
#define mvebu_gpio_dbg_show NULL
#endif
-static struct of_device_id mvebu_gpio_of_match[] = {
+static const struct of_device_id mvebu_gpio_of_match[] = {
{
.compatible = "marvell,orion-gpio",
.data = (void *) MVEBU_GPIO_SOC_VARIANT_ORION,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/7] gpio: palmas: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
2014-05-07 9:05 ` [PATCH 2/7] gpio: mcp23s08: " Jingoo Han
2014-05-07 9:06 ` [PATCH 3/7] gpio: mvebu: " Jingoo Han
@ 2014-05-07 9:06 ` Jingoo Han
2014-05-07 9:07 ` [PATCH 5/7] gpio: tegra: " Jingoo Han
` (4 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Jingoo Han @ 2014-05-07 9:06 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Laxman Dewangan'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-palmas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c
index da9d332..0860b74 100644
--- a/drivers/gpio/gpio-palmas.c
+++ b/drivers/gpio/gpio-palmas.c
@@ -148,7 +148,7 @@ static const struct palmas_device_data tps80036_dev_data = {
.ngpio = 16,
};
-static struct of_device_id of_palmas_gpio_match[] = {
+static const struct of_device_id of_palmas_gpio_match[] = {
{ .compatible = "ti,palmas-gpio", .data = &palmas_dev_data,},
{ .compatible = "ti,tps65913-gpio", .data = &palmas_dev_data,},
{ .compatible = "ti,tps65914-gpio", .data = &palmas_dev_data,},
--
1.7.10.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/7] gpio: tegra: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
` (2 preceding siblings ...)
2014-05-07 9:06 ` [PATCH 4/7] gpio: palmas: " Jingoo Han
@ 2014-05-07 9:07 ` Jingoo Han
2014-05-09 9:02 ` Linus Walleij
2014-05-07 9:08 ` [PATCH 6/7] gpio: xilinx: " Jingoo Han
` (3 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Jingoo Han @ 2014-05-07 9:07 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Stephen Warren'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 2b49f87..c2ea6f4 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -408,7 +408,7 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
.upper_offset = 0x80,
};
-static struct of_device_id tegra_gpio_of_match[] = {
+static const struct of_device_id tegra_gpio_of_match[] = {
{ .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
{ .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
{ },
--
1.7.10.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 6/7] gpio: xilinx: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
` (3 preceding siblings ...)
2014-05-07 9:07 ` [PATCH 5/7] gpio: tegra: " Jingoo Han
@ 2014-05-07 9:08 ` Jingoo Han
2014-05-07 11:25 ` Michal Simek
2014-05-09 9:03 ` Linus Walleij
2014-05-07 9:09 ` [PATCH 7/7] gpio: zevio: " Jingoo Han
` (2 subsequent siblings)
7 siblings, 2 replies; 15+ messages in thread
From: Jingoo Han @ 2014-05-07 9:08 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Michal Simek'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-xilinx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 792a05a..1248186 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -289,7 +289,7 @@ static int xgpio_of_probe(struct device_node *np)
return 0;
}
-static struct of_device_id xgpio_of_match[] = {
+static const struct of_device_id xgpio_of_match[] = {
{ .compatible = "xlnx,xps-gpio-1.00.a", },
{ /* end of list */ },
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 6/7] gpio: xilinx: Make of_device_id array const
2014-05-07 9:08 ` [PATCH 6/7] gpio: xilinx: " Jingoo Han
@ 2014-05-07 11:25 ` Michal Simek
2014-05-09 9:03 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Michal Simek @ 2014-05-07 11:25 UTC (permalink / raw)
To: Jingoo Han, 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On 05/07/2014 11:08 AM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/gpio/gpio-xilinx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 792a05a..1248186 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -289,7 +289,7 @@ static int xgpio_of_probe(struct device_node *np)
> return 0;
> }
>
> -static struct of_device_id xgpio_of_match[] = {
> +static const struct of_device_id xgpio_of_match[] = {
> { .compatible = "xlnx,xps-gpio-1.00.a", },
> { /* end of list */ },
> };
>
Reviewed-by: Michal Simek <monstr@monstr.eu>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 6/7] gpio: xilinx: Make of_device_id array const
2014-05-07 9:08 ` [PATCH 6/7] gpio: xilinx: " Jingoo Han
2014-05-07 11:25 ` Michal Simek
@ 2014-05-09 9:03 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2014-05-09 9:03 UTC (permalink / raw)
To: Jingoo Han; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, Michal Simek
On Wed, May 7, 2014 at 11:08 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with Michal's Review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 7/7] gpio: zevio: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
` (4 preceding siblings ...)
2014-05-07 9:08 ` [PATCH 6/7] gpio: xilinx: " Jingoo Han
@ 2014-05-07 9:09 ` Jingoo Han
2014-05-09 9:04 ` Linus Walleij
2014-05-07 12:01 ` [PATCH 1/7] gpio: grgpio: " Andreas Larsson
2014-05-09 8:58 ` Linus Walleij
7 siblings, 1 reply; 15+ messages in thread
From: Jingoo Han @ 2014-05-07 9:09 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Fabian Vogt'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-zevio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index f20941c..23a7669 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -208,7 +208,7 @@ static int zevio_gpio_probe(struct platform_device *pdev)
return 0;
}
-static struct of_device_id zevio_gpio_of_match[] = {
+static const struct of_device_id zevio_gpio_of_match[] = {
{ .compatible = "lsi,zevio-gpio", },
{ },
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 1/7] gpio: grgpio: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
` (5 preceding siblings ...)
2014-05-07 9:09 ` [PATCH 7/7] gpio: zevio: " Jingoo Han
@ 2014-05-07 12:01 ` Andreas Larsson
2014-05-09 8:58 ` Linus Walleij
7 siblings, 0 replies; 15+ messages in thread
From: Andreas Larsson @ 2014-05-07 12:01 UTC (permalink / raw)
To: Jingoo Han, 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio
On 2014-05-07 11:03, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Andreas Larsson <andreas@gaisler.com>
> ---
> drivers/gpio/gpio-grgpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index 84d2478..3c3f515 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -481,7 +481,7 @@ out:
> return ret;
> }
>
> -static struct of_device_id grgpio_match[] = {
> +static const struct of_device_id grgpio_match[] = {
> {.name = "GAISLER_GPIO"},
> {.name = "01_01a"},
> {},
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/7] gpio: grgpio: Make of_device_id array const
2014-05-07 9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
` (6 preceding siblings ...)
2014-05-07 12:01 ` [PATCH 1/7] gpio: grgpio: " Andreas Larsson
@ 2014-05-09 8:58 ` Linus Walleij
7 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2014-05-09 8:58 UTC (permalink / raw)
To: Jingoo Han; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, Andreas Larsson
On Wed, May 7, 2014 at 11:03 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with Andreas' ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread