From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>,
bleung@chromium.org, groeck@chromium.org,
linus.walleij@linaro.org, brgl@bgdev.pl,
hverkuil-cisco@xs4all.nl, mchehab@kernel.org, sre@kernel.org
Cc: chrome-platform@lists.linux.dev, pmalani@chromium.org,
linux-gpio@vger.kernel.org, linux-media@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 5/6] platform/chrome: cros_kbd_led_backlight: shrink the driver name
Date: Mon, 1 Apr 2024 12:19:16 +0200 [thread overview]
Message-ID: <026eed23-d75b-4ad9-a359-03a3870fbdae@kernel.org> (raw)
In-Reply-To: <ffac342d-5b3e-49fb-ad0b-858cd36f3164@kernel.org>
On 01/04/2024 12:02, Krzysztof Kozlowski wrote:
> On 01/04/2024 05:00, Tzung-Bi Shih wrote:
>> Prepare to provide platform_device_id table. Shrink the driver name for
>> fitting to [1].
>
> Instead of linking to external resources, please describe the problem
> and the bug you are fixing here.
>
>>
>> [1]: https://elixir.bootlin.com/linux/v6.8/source/include/linux/mod_devicetable.h#L608
>>
>> Reviewed-by: Benson Leung <bleung@chromium.org>
>> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
>
> Missing fixes tag and Cc-stable.
Ah, now I read your answer to v1 discussion. So this was not a bug in
the first place? Hm, then probably my comment was not really correct and
we should not split it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-01 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 3:00 [PATCH v2 0/6] provide ID table for avoiding fallback match Tzung-Bi Shih
2024-04-01 3:00 ` [PATCH v2 1/6] media: platform: cros-ec: " Tzung-Bi Shih
2024-04-08 7:36 ` Hans Verkuil
2024-04-01 3:00 ` [PATCH v2 2/6] gpio: " Tzung-Bi Shih
2024-04-02 8:58 ` Bartosz Golaszewski
2024-04-01 3:00 ` [PATCH v2 3/6] power: supply: cros_usbpd: " Tzung-Bi Shih
2024-04-01 3:00 ` [PATCH v2 4/6] power: supply: cros_pchg: " Tzung-Bi Shih
2024-04-01 3:00 ` [PATCH v2 5/6] platform/chrome: cros_kbd_led_backlight: shrink the driver name Tzung-Bi Shih
2024-04-01 10:02 ` Krzysztof Kozlowski
2024-04-01 10:19 ` Krzysztof Kozlowski [this message]
2024-04-01 10:42 ` Tzung-Bi Shih
2024-04-01 3:00 ` [PATCH v2 6/6] platform/chrome: cros_kbd_led_backlight: provide ID table for avoiding fallback match Tzung-Bi Shih
2024-04-01 10:03 ` Krzysztof Kozlowski
2024-04-01 9:45 ` (subset) [PATCH v2 0/6] " Sebastian Reichel
2024-05-27 2:55 ` patchwork-bot+chrome-platform
2024-05-27 3:07 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=026eed23-d75b-4ad9-a359-03a3870fbdae@kernel.org \
--to=krzk@kernel.org \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pmalani@chromium.org \
--cc=sre@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).