From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A111B548F2 for ; Thu, 14 Mar 2024 14:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710426918; cv=none; b=GMLftty9iOv5hyQknl+wvbrzOGo2QVy0IMwQofHb8eZFWuVigMIWkq7heTc2uwz9W5rGr7y+oUnzIlv4h5qSEcM619xazGnqRwM3b48dv1M16oJ10hHAya4ef4IVcfPa+Gc64RMLPvDyN9LTpzYgIojdRzLa0qN539yxmlTTafI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710426918; c=relaxed/simple; bh=ADBh9YibRLgJRYob/1rW3aS+FG3zpqR0Xph5ndKNCAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tZLuaLmZDyQxJR+zhVUYkpSxiVd7ItY1Mhr3/HjrRDFs6u9WouBgaRTwVpCsufoOYEWl55BAVfLtCj7VB3Mj1lig63kaHmRKUoKxJQyTbA7AGmqdIS70+R7LYv6CtM27bJOq/PHR7lX2NtKvNQqvJnKD4POgDkpVYz5FBPPokbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=gMVq9Xp3; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="gMVq9Xp3" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-56829f41f81so1402750a12.2 for ; Thu, 14 Mar 2024 07:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1710426915; x=1711031715; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=axdW4v18nIUnyQiLKKJXBxP/Lw0GVm9nBviRq+44A7A=; b=gMVq9Xp3iIOtVStc1Rk/uReG1wltgabzvEICElpxAXXYAKRd9y4fEn2ND89K4O6ImM CWMD8b76N22TwtEl3qgXfUl9iBD+fVYd99gCK90bqu7c4QCd85A0MEK/83G9VEuRQ/eH oUKPojfM1dArnOIVIRwLMtUuC5E20XnpBDkQF3N0zKSv9yMuG8RPQ9u6oPPhBhvbKRws iyXiJcUwqRC3tFvbBJWjctyVNoQ/5rgO6Cr1klxBEJY82KT6NKcfbjxHjiotpBMAt3ry EbexeL7MXJuiPg2xZAJ/sQwCEfaRCAxC3069dwO5UQ8e7Pxi4W3WhXPWO66tm+Mou0kv 4l9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710426915; x=1711031715; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=axdW4v18nIUnyQiLKKJXBxP/Lw0GVm9nBviRq+44A7A=; b=ifg/XPDnnly72+zTpHDzH0rVFBMd2QNA+YRpVlTl06f/8Kc0L53EPtkAK6o/T71nQ/ TgzQn+3nPw2PXG7yKZS+f9PIV3FFegdQWPWpeoO3WBkjT9QWmG7gXhlqeXjnfYdWkowN 3U2iE85JaWGO/8xtc65KHad7Sb69Pqp0oB948gXIBTALO7Fky26EPhQO4aJwUjnaKFnM +qy0cbAkeXDEJOQeOXglWZAja4VsbgGO98GJIUpA107PZQATaT+uw4nTLUThM91sRTPu 292FNRGQFFK0OgJkx9I7K4qdyS6NY+2Pug00vF+wzC2Givc1HNq2PQAWngIEs9LOkKsj D/2w== X-Forwarded-Encrypted: i=1; AJvYcCU4Bta2sboLvwdv+Bu1+/5TvaBfSByMSF03zYO0hxO8BTNhs/rQlRoy4ahKpZs57LGhybFEWiMQMPvuVO0GyoPeUJGnBiZffZ6x/w== X-Gm-Message-State: AOJu0YzwNvfkRLHhLhgjD7un7zkCLQ/bT1B7M/9ID0+PyEtxNTUsm705 fHmKR0j+Qouo+AVOAgf2yT6tNpsWiyUvt+XGpncsnmvXGFMftMbimK0Uq/pThVk= X-Google-Smtp-Source: AGHT+IFSlOL+Ts8Nmv1jHT+0qtRQeIM5wTh5Txsp0n0sk9VCn8HaKd8RKJDlwXgo0lwsxy5YcyQhBQ== X-Received: by 2002:a05:6402:380b:b0:568:9b13:77fc with SMTP id es11-20020a056402380b00b005689b1377fcmr581261edb.36.1710426914916; Thu, 14 Mar 2024 07:35:14 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id y14-20020aa7ccce000000b005653c441a20sm766627edt.34.2024.03.14.07.35.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 07:35:14 -0700 (PDT) Message-ID: <03d20c1a-cbdf-46ec-963f-6c5b8305e5f3@tuxon.dev> Date: Thu, 14 Mar 2024 16:35:13 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: renesas: rzg2l: Execute atomically the interrupt configuration Content-Language: en-US To: Geert Uytterhoeven Cc: linus.walleij@linaro.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20240307112452.74220-1-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14.03.2024 16:31, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Thu, Mar 14, 2024 at 3:11 PM claudiu beznea wrote: >> On 14.03.2024 15:21, Geert Uytterhoeven wrote: >>> On Thu, Mar 7, 2024 at 12:25 PM Claudiu wrote: >>>> From: Claudiu Beznea >>>> >>>> Lockdep detects a possible deadlock as listed below. This is because it >>>> detects the IA55 interrupt controller .irq_eoi() API is called from >>>> interrupt context while configuration-specific API (e.g., .irq_enable()) >>>> could be called from process context on resume path (by calling >>>> rzg2l_gpio_irq_restore()). To avoid this, protect the call of >>>> rzg2l_gpio_irq_enable() with spin_lock_irqsave()/spin_unlock_irqrestore(). >>>> With this the same approach that is available in __setup_irq() is mimicked >>>> to pinctrl IRQ resume function. >>> >>> You mean __setup_irq() in kernel/irq/manage.c? >> >> Yes! >> >>> That one uses the raw spinlock methods? >> >> Yes! Would you prefer to have raw spinlock here, too? > > Most pin control driver needing protection in an irq_enable > method use raw spinlock, so I think it makes sense to follow that. Ok, I'll update it, thanks! > > Gr{oetje,eeting}s, > > Geert >