From: Fenglin Wu <fenglinw@codeaurora.org>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
collinsd@codeaurora.org, aghayal@codeaurora.org,
wruan@codeaurora.org, kgunda@codeaurora.org
Subject: Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Add support for qcom,gpios-disallowed property
Date: Tue, 29 Aug 2017 10:04:07 +0800 [thread overview]
Message-ID: <0446a53f-3d78-39be-8cea-d39e39453910@codeaurora.org> (raw)
In-Reply-To: <20170829015112.GK3685@dragon>
On 8/29/2017 9:51 AM, Shawn Guo wrote:
> On Tue, Aug 29, 2017 at 09:03:02AM +0800, Fenglin Wu wrote:
>> I agree the GPIO's ownership is configurable and it always configured at
>> the very beginning of the device boot up which is not visible by linux
>> kernel drivers/image. Normally, this configuration is fixed in one
>> platform and it's been protected and not allowed to be configured in
>> linux kernel driver. So from linux driver point of view, this is a
>> hardware configuration. I agree the coming patch "spmi: pmic-arb: Move
>> the ownership check to irq_chip callback" would fix the pinctrl-
>> spmi-gpio driver probe failure caused by the ownership mismatch, but
>> this is just hiding the mistake of the kernel configured the GPIOs which
>> not owned by APPS processor.
>
> The kernel does everything just right, using the GPIO that device tree
> tells to use. If there is something wrong about ownership check, it
> should be fault of that device tree specifies the wrong GPIO, or
> firmware doesn't configure ownership as needed.
> > Shawn
>
If you thought that the driver registers pins for the GPIOs not owned by
APPS processor is correct, then this patch is no needed.
I agreed with others.
Thanks
Fenglin
>> And these GPIOs will be registered
>> successfully as pinctrl pins and any APPS processor consumer drivers
>> could use this pins. This is not correct even the select_state operation
>> for these pins would failed due to the mode protection in spmi write_cmd
>> calling. I am thinking that not allowing these pins to be register as
>> pinctrl pins should be more straightforward and easy understanding. So I
>> think this patch still have value even the probe failure has been fixed
>> by the coming spmi patch.
--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2017-08-29 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 7:17 [PATCH V1] pinctrl: qcom: spmi-gpio: Add support for qcom,gpios-disallowed property fenglinw-sgV2jX0FEOL9JmXXK+q4OQ
2017-07-24 19:09 ` Rob Herring
2017-07-25 1:05 ` Fenglin Wu
[not found] ` <4bb5757c-44b0-c760-2d70-df0e607de0d7-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-25 1:11 ` Fenglin Wu
2017-08-28 14:54 ` Shawn Guo
2017-08-29 1:03 ` Fenglin Wu
2017-08-29 1:51 ` Shawn Guo
2017-08-29 2:04 ` Fenglin Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0446a53f-3d78-39be-8cea-d39e39453910@codeaurora.org \
--to=fenglinw@codeaurora.org \
--cc=aghayal@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wruan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).