From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH v2] pinctrl: msm: fix gpio-hog related boot issues Date: Fri, 4 May 2018 14:34:05 +0530 Message-ID: <044eab94-fd5f-884f-8e60-047c40344aad@nvidia.com> References: <20180402121005.10080-1-chunkeey@gmail.com> <3524410.JrO1DEFpQ1@debian64> <2265923.XhyVMjVhWR@debian64> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2265923.XhyVMjVhWR@debian64> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Christian Lamparter , Linus Walleij Cc: "open list:GPIO SUBSYSTEM" , linux-arm-msm@vger.kernel.org, Stephen Warren , Bjorn Andersson , David Brown , Sven Eckelmann , Andy Gross , Linux ARM List-Id: linux-gpio@vger.kernel.org On Thursday 03 May 2018 11:13 PM, Christian Lamparter wrote: > On Mittwoch, 2. Mai 2018 14:14:39 CEST Linus Walleij wrote: >> On Thu, Apr 26, 2018 at 11:47 PM, Christian Lamparter >> wrote: >>> On Thu, Apr 26, 2018 11:12:21 CEST Linus Walleij wrote: >>>> I think I replied in some other mail that I think we need to >>>> be backwards compatible and it's not too hard to do >>>> both. (Correct me if I'm wrong.) >>> I think so too, I looked around and found that the nvidia pinctrl was >>> doing something similar with of_find_property(): >>> >>> | has_prop = of_find_property(np, "gpio-ranges", NULL); >>> >>> However this looks kinda funny, since "has_prob" is declared as a bool >>> and of_find_property() returns a pointer to a "struct property".... >>> Tell you what: If nobody beats me to it, I'll sent a patch for this after >>> the pinctrl-msm's gpio-hog has been dealt with. :) >> Yeah the nVidia driver is one of the oldest and also at the time >> DT was kind of new. I haven't heard from Stephen for a while >> but I bet he will pop up, else check with Laxman, he's got >> a good grip on nVidia pinctrl+GPIO as well. > All in good time. > > But first @Bjorn and @Andy or @David can you please look and > review v4 "pinctrl: msm: fix gpio-hog related boot issues" > Agree with the patch as by adding gpio-ranges, we add the gpio range part of gpiochip_add(), called by of_gpiochip_add()->of_gpiochip_add_pin_range(). and so does not need to explicitly call of the gpiochip_add_pin_range(). Please add ack in above patch. Acked-by: Laxman Dewangan