From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F43C77B73 for ; Wed, 31 May 2023 09:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235286AbjEaJVV (ORCPT ); Wed, 31 May 2023 05:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234937AbjEaJVU (ORCPT ); Wed, 31 May 2023 05:21:20 -0400 Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74251BE; Wed, 31 May 2023 02:21:16 -0700 (PDT) X-QQ-mid: Yeas44t1685524789t455t56494 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [183.159.96.128]) X-QQ-SSF: 00400000000000F0FOF000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 10707911515186658702 To: "'Russell King \(Oracle\)'" Cc: , , , , , , , , , , , , "'Piotr Raczynski'" References: <20230524091722.522118-6-jiawenwu@trustnetic.com> <202305261959.mnGUW17n-lkp@intel.com> <02dd01d991d2$2120fcf0$6362f6d0$@trustnetic.com> <03ac01d992d2$67c1ec90$3745c5b0$@trustnetic.com> In-Reply-To: <03ac01d992d2$67c1ec90$3745c5b0$@trustnetic.com> Subject: RE: [PATCH net-next v9 5/9] net: txgbe: Add SFP module identify Date: Wed, 31 May 2023 17:19:47 +0800 Message-ID: <046e01d993a1$0b8f51e0$22adf5a0$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFlCTXCD0V13/nxYaH3lJLB+zCPMgFguorBARt7XSgCWWopnAJhtNzYsCNyvSA= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tuesday, May 30, 2023 4:41 PM, Jiawen Wu wrote: > On Monday, May 29, 2023 10:06 AM, Jiawen Wu wrote: > > On Friday, May 26, 2023 7:37 PM, Russell King (Oracle) wrote: > > > On Fri, May 26, 2023 at 07:30:45PM +0800, kernel test robot wrote: > > > > Kconfig warnings: (for reference only) > > > > WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM > > > > Depends on [n]: I2C [=n] && HAS_IOMEM [=y] && (ACPI && COMMON_CLK [=y] || !ACPI) > > > > Selected by [y]: > > > > - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] > > > > WARNING: unmet direct dependencies detected for SFP > > > > Depends on [n]: NETDEVICES [=y] && PHYLIB [=y] && I2C [=n] && PHYLINK [=y] && (HWMON [=n] || HWMON [=n]=n) > > > > Selected by [y]: > > > > - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] > > > > > > ... and is basically caused by "select SFP". No. Do not do this unless > > > you look at the dependencies for SFP and ensure that those are also > > > satisfied - because if you don't you create messes like the above > > > build errors. > > > > So how do I make sure that the module I need compiles and loads correctly, > > rely on the user to manually select it? > > When I changed the TXGBE config to: > ... > depends on SFP > select PCS_XPCS > ... > the compilation gave an error: > > drivers/net/phy/Kconfig:16:error: recursive dependency detected! > drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by PHYLINK > drivers/net/phy/Kconfig:6: symbol PHYLINK is selected by PCS_XPCS > drivers/net/pcs/Kconfig:8: symbol PCS_XPCS is selected by TXGBE > drivers/net/ethernet/wangxun/Kconfig:40: symbol TXGBE depends on SFP > drivers/net/phy/Kconfig:63: symbol SFP depends on PHYLIB > For a resolution refer to Documentation/kbuild/kconfig-language.rst > subsection "Kconfig recursive dependency limitations" > > Seems deleting "depends on SFP" is the correct way. But is this normal? > How do we ensure the dependency between TXGBE and SFP? Hi Russell, Could you please give me some suggestions? I checked "kconfig-language" doc, the practical solution is that swap all "select FOO" to "depends on FOO" or swap all "depends on FOO" to "select FOO". Config PCS_XPCS has to be selected in order to load modules properly, so how should I fix the warning?