Re: [PATCH v3 00/22] mfd: adp5585: support keymap events and drop legacy Input driver

["Nuno Sá" <noname.nuno@gmail.com>]

On Wed, 2025-05-14 at 09:25 +0100, Lee Jones wrote:
> On Mon, 12 May 2025, Nuno Sá via B4 Relay wrote:
> 
> > Hi all,
> > 
> > Here it goes v3. There was some major refactoring in this version due to
> > Lee's and Laurent's feedback. There are some splits (and some explicit
> > requests) resulting in new patches being added. The biggest change is the
> > effort in trying to minimize the usage of specific child device bits in
> > the top level device (mainly stuff related to the keymap). I think now
> > it's fairly self contained and the only thing that we really need to
> > handle in the top device are the unlock and reset events as those can be
> > supported through both the input and gpio devices (via gpio_keys). This
> > results in a bit of more runtime complexity but well, that's life...
> > 
> > Another change is Lee's suggestion of making use of templates (for
> > regmap and chip specific data) and fill things up at probe.
> > 
> > I also refactored a bit the event handling so it's more generic now.
> > There were lot's of changes so odds are that I might have forgotten some
> > feedback and so, my apologies in advance :).
> > 
> > I also dropped the tags in:
> > 
> > patch 16/22 ("gpio: adp5585: support gpi events") as it has some
> > significant changes (replacing .init_valid_masks() with .request() and
> > .free())
> 
> Please run this set through checkpatch.pl before submitting again.
> 

I've done that... It gave some issues but not sure there's anything to be done:

● 26ffbc19b2ce: mfd: adp5585: refactor how regmap defaults are handled
  ● checkpatch.pl: drivers/mfd/adp5585.c:94: WARNING: struct regmap_config
should normally be const
  ● checkpatch.pl: drivers/mfd/adp5585.c:149: WARNING: struct regmap_config
should normally be const

The above is something we need given that we want to fill reg defaults during
probe. Maybe we can go around that but not sure if it's worth it.

● 6183fc9ef938: gpio: adp5585: add support for the adp5589 expander
  ● checkpatch.pl: drivers/gpio/gpio-adp5585.c:26: CHECK: Macro argument reuse
'n' - possible side-effects?

Again, not sure it's worth it to "fix" it and it was just copy pasted from the
header.

● 3e0f3ba80ea5: Input: adp5589: remove the driver
  ● checkpatch.pl: drivers/input/keyboard/adp5589-keys.c:14: WARNING: added,
moved or deleted file(s), does MAINTAINERS need updating?

the above is lack of an entry in the original file...



> Not sure if we've discussed this, but W=1 wouldn't hurt either.

I used the kernel test bot... I assume W=1 is part of the builds.

- Nuno Sá