From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jim Liu <jim.t90615@gmail.com>,
JJLIU0@nuvoton.com, KWLIU@nuvoton.com, linus.walleij@linaro.org,
brgl@bgdev.pl, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v5 3/3] dt-bindings: gpio: add NPCM sgpio driver bindings
Date: Wed, 15 Mar 2023 08:54:44 +0100 [thread overview]
Message-ID: <064b170a-c26e-f9a6-9d17-01edeeec55a8@linaro.org> (raw)
In-Reply-To: <bfb04dde-8429-215f-3aae-7e3823ee154c@linaro.org>
On 14/03/2023 19:45, Krzysztof Kozlowski wrote:
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + gpio8: gpio@101000 {
>> + compatible = "nuvoton,npcm750-sgpio";
>> + reg = <0x101000 0x200>;
>> + clocks = <&clk NPCM7XX_CLK_APB3>;
>> + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + nuvoton,input-ngpios = <64>;
>> + nuvoton,output-ngpios = <64>;
>> + status = "disabled";
>
> So this is fifth reminder...
>
> https://lore.kernel.org/all/d56c24c2-a017-8468-0b3a-bd93d6024c69@linaro.org/
>
> https://lore.kernel.org/all/39efdb85-f881-12ab-e258-61175f209b4c@linaro.org/
>
> https://lore.kernel.org/all/9fc4d874-a0d0-6c5c-aeee-61ab817fdd9f@linaro.org/
>
> This is a not-that-friendly-anymore reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
BTW, you never responded that my comment is unclear, but I can imagine
that this was the cause of some misunderstanding. Therefore just in case
let's be clear: drop the "status line". Entire line.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-15 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 9:23 [PATCH v5 0/3]Add Nuvoton NPCM SGPIO feature Jim Liu
2023-03-14 9:23 ` [PATCH v5 1/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver Jim Liu
2023-03-14 11:46 ` Paul Menzel
2023-07-24 3:04 ` Jim Liu
2023-07-24 14:44 ` Paul Menzel
2023-07-25 9:12 ` Jim Liu
2023-03-14 18:38 ` Linus Walleij
2023-03-14 18:48 ` Krzysztof Kozlowski
2023-03-14 9:23 ` [PATCH v5 2/3] arm: dts: nuvoton: npcm: Add sgpio feature Jim Liu
2023-03-14 18:47 ` Krzysztof Kozlowski
2023-03-14 18:49 ` Krzysztof Kozlowski
2023-03-14 9:23 ` [PATCH v5 3/3] dt-bindings: gpio: add NPCM sgpio driver bindings Jim Liu
2023-03-14 18:45 ` Krzysztof Kozlowski
2023-03-15 7:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=064b170a-c26e-f9a6-9d17-01edeeec55a8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jim.t90615@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).