linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Breathitt Gray <william.gray@linaro.org>
To: linus.walleij@linaro.org, brgl@bgdev.pl
Cc: broonie@kernel.org, andriy.shevchenko@linux.intel.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	William Breathitt Gray <william.gray@linaro.org>
Subject: [PATCH v2 2/6] gpio: 104-dio-48e: Utilize no_status regmap-irq flag
Date: Mon, 27 Feb 2023 11:45:23 -0500	[thread overview]
Message-ID: <06fd817ac5549d039e9d04b227ca7b310f36aedb.1677515341.git.william.gray@linaro.org> (raw)
In-Reply-To: <cover.1677515341.git.william.gray@linaro.org>

The 104-DIO-48E lacks an IRQ status register. Rather than use the Clear
Interrupt register as the status register, set the no_status flag to
true and thus avoid such a hack.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
---
 drivers/gpio/gpio-104-dio-48e.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c
index a3846faf3780..fe3c93bfe4bd 100644
--- a/drivers/gpio/gpio-104-dio-48e.c
+++ b/drivers/gpio/gpio-104-dio-48e.c
@@ -195,13 +195,9 @@ static int dio48e_probe(struct device *dev, unsigned int id)
 		return -ENOMEM;
 
 	chip->name = name;
-	/* No IRQ status register so use CLEAR_INTERRUPT register instead */
-	chip->status_base = DIO48E_CLEAR_INTERRUPT;
 	chip->mask_base = DIO48E_ENABLE_INTERRUPT;
 	chip->ack_base = DIO48E_CLEAR_INTERRUPT;
-	/* CLEAR_INTERRUPT doubles as status register so we need it cleared */
-	chip->clear_ack = true;
-	chip->status_invert = true;
+	chip->no_status = true;
 	chip->num_regs = 1;
 	chip->irqs = dio48e_regmap_irqs;
 	chip->num_irqs = ARRAY_SIZE(dio48e_regmap_irqs);
-- 
2.39.2


  parent reply	other threads:[~2023-02-27 16:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 16:45 [PATCH v2 0/6] Migrate IDIO-16 GPIO drivers to regmap API William Breathitt Gray
2023-02-27 16:45 ` [PATCH v2 1/6] regmap-irq: Add no_status support William Breathitt Gray
2023-03-06 10:11   ` Bartosz Golaszewski
2023-03-10 12:01     ` William Breathitt Gray
2023-03-15 13:28   ` Mark Brown
2023-02-27 16:45 ` William Breathitt Gray [this message]
2023-02-27 16:45 ` [PATCH v2 3/6] gpio: idio-16: Migrate to the regmap API William Breathitt Gray
2023-02-27 16:45 ` [PATCH v2 4/6] gpio: 104-idio-16: " William Breathitt Gray
2023-02-27 16:45 ` [PATCH v2 5/6] gpio: pci-idio-16: " William Breathitt Gray
2023-03-22 16:37   ` Bartosz Golaszewski
2023-02-27 16:45 ` [PATCH v2 6/6] gpio: idio-16: Remove unused legacy interface William Breathitt Gray
2023-03-06 14:09 ` (subset) [PATCH v2 0/6] Migrate IDIO-16 GPIO drivers to regmap API Mark Brown
2023-03-06 14:12 ` Linus Walleij
2023-03-15 10:02   ` Bartosz Golaszewski
2023-03-15 10:14     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06fd817ac5549d039e9d04b227ca7b310f36aedb.1677515341.git.william.gray@linaro.org \
    --to=william.gray@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).