From: Marek Vasut <marex@denx.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Roman Guskov <rguskov@dh-electronics.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] Revert "gpiolib: generalize devprop_gpiochip_set_names() for device properties"
Date: Fri, 5 Mar 2021 11:51:02 +0100 [thread overview]
Message-ID: <07802215-0ab4-ac2d-f742-178fb04470fd@denx.de> (raw)
In-Reply-To: <YEILjTOApl2gMw4P@smile.fi.intel.com>
On 3/5/21 11:44 AM, Andy Shevchenko wrote:
> On Fri, Mar 05, 2021 at 12:09:56AM +0100, Marek Vasut wrote:
>> This reverts 7cba1a4d5e162 ("gpiolib: generalize devprop_gpiochip_set_names()
>> for device properties") because this breaks OF "gpio-line-names" behavior on
>> STM32MP1 platform.
>>
>> On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, see
>> arch/arm/boot/dts/stm32mp151.dtsi. The driver for pin-controller@50002000
>> is in drivers/pinctrl/stm32/pinctrl-stm32.c and iterates over all of its DT
>> subnodes when registering each GPIO bank gpiochip. Each gpiochip has:
>> - gpio_chip.parent = dev where dev is the device node of the pin controller
>> - gpio_chip.of_node = np which is the OF node of the GPIO bank
>> Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node) , i.e.
>> pin-controller@50002000 != pin-controller@50002000/gpio@5000*000.
>>
>> The original code behaved correctly, as it extracted the "gpio-line-names"
>> from of_fwnode_handle(chip.of_node) = pin-controller@50002000/gpio@5000*000.
>> This patch reinstates the original correct behavior.
>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Reported-by: Roman Guskov <rguskov@dh-electronics.com>
>
> Thanks for the report and a fix!
> However I think the revert is not an option. We may do much better.
The revert is pretty much also the minimal change to reinstate the
original behavior. What better option do you have in mind, please do
elaborate in detail. Thank you.
next prev parent reply other threads:[~2021-03-05 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 23:09 [PATCH] Revert "gpiolib: generalize devprop_gpiochip_set_names() for device properties" Marek Vasut
2021-03-05 10:44 ` Andy Shevchenko
2021-03-05 10:51 ` Marek Vasut [this message]
2021-03-05 12:03 ` Andy Shevchenko
2021-03-05 12:12 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07802215-0ab4-ac2d-f742-178fb04470fd@denx.de \
--to=marex@denx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rguskov@dh-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).