From: "Andreas Färber" <afaerber@suse.de>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins
Date: Thu, 8 Jun 2017 15:58:05 +0200 [thread overview]
Message-ID: <07b2ff66-6ac1-5e20-b70f-4dec2e050337@suse.de> (raw)
In-Reply-To: <1496930016.3552.45.camel@baylibre.com>
Am 08.06.2017 um 15:53 schrieb Jerome Brunet:
> On Thu, 2017-06-08 at 15:49 +0200, Andreas Färber wrote:
>> Am 08.06.2017 um 15:09 schrieb Jerome Brunet:
>>> Add Tsin A pins to bank DV and X.
>>> We don't have a driver for the tsin yet but since the tsin A pinmux is
>>> enabled by default at boot time, declaring this pinmux is required to
>>> properly operate on GPIOX.
>>>
>>> Without this change, GPIOX 8, 9, 10 and 11 can't be driven as GPIO output
>>> as the tsin A seems to have priority.
>>
>> Should this get a Fixes header then for stable backports?
>
> Nothing is wrong with what is already in. This is merely an addition.
Your above description of not being able to use GPIOs on e.g. the GXL
based Khadas Vim devboard sounded like a bug to me.
> If we go that way, all commit to this file should have a Fixes to the
> initial commit. This seems a bit extreme to me ...
Thought it might have been just an oversight.
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-06-08 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 13:09 [PATCH] pinctrl: meson-gxl: add tsin_a pins Jerome Brunet
2017-06-08 13:49 ` Andreas Färber
2017-06-08 13:53 ` Jerome Brunet
2017-06-08 13:58 ` Andreas Färber [this message]
2017-06-08 14:05 ` Jerome Brunet
2017-06-09 9:54 ` Neil Armstrong
2017-06-16 9:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b2ff66-6ac1-5e20-b70f-4dec2e050337@suse.de \
--to=afaerber@suse.de \
--cc=carlo@caione.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).