From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zheng, Qi" Subject: RE: [PATCH 1/3] pinctrl: Intel: add RX invertion config Date: Mon, 14 Mar 2016 08:56:04 +0000 Message-ID: <0DD381DBF8F68D419C32ACFCEB28EB2521D10643@SHSMSX101.ccr.corp.intel.com> References: <1457715962-108484-1-git-send-email-qipeng.zha@intel.com> <20160311093856.GN1796@lahna.fi.intel.com> <0DD381DBF8F68D419C32ACFCEB28EB2521D1032C@SHSMSX101.ccr.corp.intel.com> <20160314085002.GY1796@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from mga01.intel.com ([192.55.52.88]:44138 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbcCNJAI convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2016 05:00:08 -0400 In-Reply-To: <20160314085002.GY1796@lahna.fi.intel.com> Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "Westerberg, Mika" Cc: "Zha, Qipeng" , "linux-gpio@vger.kernel.org" , "linus.walleij@linaro.org" BRs On Mon, Mar 14, 2016 at 03:10:07AM +0200, Zheng, Qi wrote: > On Sat, Mar 12, 2016 at 01:06:00AM +0800, Qipeng Zha wrote: > > Some module need to enable RX invertion config on BXT platform. > > > > Signed-off-by: Qi Zheng > > Signed-off-by: Qipeng Zha > > > Can I ask what module might need this? I'm not so certain we want to add anything like this to the driver to be honest. > > The "pi330532" device on Broxton requires this function to manually trigger an GPIO input interrupt. > > That is to say, actually no signal change on the pin but toggling this > RX inversion bit to make the GPIO controller believes there is voltage > change on the pin thus triggering the interrupt. > That sounds rather hackish thing and definitely should not be part of the driver IMHO. > I'm pretty sure there are better ways to do what you are doing. We have gone through this requirement from CHT to BXT, there was no other better way to simulate the GPIO interrupt for the use of those devices. If you insist it is not OK, I am fine to keep it on Intel local branch. Thanks.