From: Shreeya Patel <shreeya.patel@collabora.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel test robot <lkp@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
krisman@collabora.com, kbuild-all@lists.01.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH v2] gpio: Restrict usage of gc irq members before initialization
Date: Wed, 16 Mar 2022 00:12:44 +0530 [thread overview]
Message-ID: <0a011be5-6f08-a9dc-3e62-f9296c7b9d2e@collabora.com> (raw)
In-Reply-To: <CAHp75Vcsxn+8H-tpkN_ipjW4XGsfnhd7NA5Rz+cvGt7T4C9xfQ@mail.gmail.com>
On 15/03/22 11:35 pm, Andy Shevchenko wrote:
> On Tue, Mar 15, 2022 at 7:38 PM kernel test robot <lkp@intel.com> wrote:
>> Hi Shreeya,
>>
>> Thank you for the patch! Yet something to improve:
>
>> All errors (new ones prefixed by >>):
>>
>> drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
>>>> drivers/gpio/gpiolib.c:3068:29: error: 'struct gpio_chip' has no member named 'irq'
>> 3068 | if (gc->to_irq && gc->irq.gc_irq_initialized) {
>> | ^~
> Exactly, because this check should go under ifdeffery.
Makes sense to me now. gc->irq.initialized must be checked inside
gpiochip_to_irq() wrapped around an ifdef CONFIG_GPIOLIB_IRQCHIP
Thanks Andy, I'll send a v3 with this change.
Shreeya Patel
next prev parent reply other threads:[~2022-03-15 18:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:38 [PATCH v2] gpio: Restrict usage of gc irq members before initialization Shreeya Patel
2022-03-15 11:00 ` Andy Shevchenko
2022-03-15 12:32 ` Shreeya Patel
2022-03-15 13:45 ` Andy Shevchenko
2022-03-15 17:30 ` kernel test robot
2022-03-15 18:05 ` Andy Shevchenko
2022-03-15 18:42 ` Shreeya Patel [this message]
2022-03-15 18:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a011be5-6f08-a9dc-3e62-f9296c7b9d2e@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=kbuild-all@lists.01.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).