From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B28C4167B for ; Tue, 29 Nov 2022 16:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236164AbiK2QEx (ORCPT ); Tue, 29 Nov 2022 11:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235781AbiK2QEe (ORCPT ); Tue, 29 Nov 2022 11:04:34 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CE571F2C9 for ; Tue, 29 Nov 2022 08:02:44 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id u27so11727777lfc.9 for ; Tue, 29 Nov 2022 08:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=13+qbJOmWTqxbFOdDOLgCT6uW4S43S5+kJ0NK9uACko=; b=eFbk+HGJxPawBYhTluxHbS2J74enMGNbBWPwjZnYQ/CWkejbCh/CQwm7RT79kNoj4V 26fei0JhV0J1NsodfAftlgIIS7xDdt/QA51zN29aHc/+AnUmU7cYMno6t72DjXbtdjfC jonXr6tyqeXSXj17TU1/lroRd1ZFQebUiNEHvRw88JSpFwClmZ/Hrcss3A+3XvsUHTUO J5lRk5BZ2JVrGGCH1/ponGmfnIJNNg6pj5xFJtrYtJAunfy/6Fm2Ndp9/XB+m6xXXaix z/xG/Ryq0S/NoARPexwy4IvXPc21KD7C+B46voVXGO2VbNQul00ARFNX4nveIjPKCIJb L0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=13+qbJOmWTqxbFOdDOLgCT6uW4S43S5+kJ0NK9uACko=; b=O6f+rLArIRyF5DFAU9I6sN/i9w+iZJtXGq58LQfgWSBxQii74sbvJFziZFeu+z3haR AXguGIqaY4swvgydMxiC5slhsDt697dLPX+t+xZcfBZdNm9yk0HllUpmc8xovrqnjJN0 N3cQXzyVuNZK2Ivhx0I5VSa64Nvgl6hFzJdZRompKxZyNH7Ua4EQty2X8zJB3hj/Lfkb 42g5flGPTfO77z56p8AlmeVo205kFdfcIQPHW0j5XJG9tguw1bWlz2a+0fsECNEYwAf5 SQnnG8MWX1N6POM81NWJfYynKBSHPvBKYs5OYgYXD/qZppHNPKSiSt2izRXoT52zqM9E jIbA== X-Gm-Message-State: ANoB5pnvDOVkNsHMSCpJcHmVOTMdGbGvf8Gm2wihD79jOJKZ6x/iVCAF sWJT6IoQd4K55D4X4F3Pcc0aUQ== X-Google-Smtp-Source: AA0mqf47BgiluiyNP/9thR/1gKkiA3+Yk8TNqaH4cPXqRpLVYA73Z5o8kzd7SJcWMxMO4FCNHl26ww== X-Received: by 2002:ac2:4bd0:0:b0:4af:ad36:7a85 with SMTP id o16-20020ac24bd0000000b004afad367a85mr19013323lfq.617.1669737761605; Tue, 29 Nov 2022 08:02:41 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w18-20020a2e9992000000b00278e7800715sm1570514lji.16.2022.11.29.08.02.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 08:02:41 -0800 (PST) Message-ID: <0a8c3ed4-c16a-4014-94f6-cf177630e605@linaro.org> Date: Tue, 29 Nov 2022 17:02:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/5] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions Content-Language: en-US To: Jianlong Huang , Hal Feng , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Cc: Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Linus Walleij , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20221118011108.70715-1-hal.feng@starfivetech.com> <20221118011108.70715-2-hal.feng@starfivetech.com> <08db0f3b-5222-9460-26ba-0e6380d16583@linaro.org> <0ceba170-f844-e733-a49e-e67746f9f836@starfivetech.com> <093ea507-4c42-1af9-4896-64c1a918432e@linaro.org> <30c21787-0c48-ff50-1d63-8e69bdcdbe30@starfivetech.com> <339be655-aee7-e1a4-51be-28ea20de6792@linaro.org> <3db802d6-114f-097a-6c69-e7b40e4d2764@starfivetech.com> <8677051a-604a-210c-066c-75db444d6f09@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <8677051a-604a-210c-066c-75db444d6f09@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 29/11/2022 16:58, Jianlong Huang wrote: >>> >>> Drivers rarely reference macros directly, mostly parsing dts and writing them to registers. >> >> So drivers do not use macros? Then there is no reason to store them in >> bindings? What do you "bind" if there is no usage (and we do not talk >> about DTS...)? >> > > Where do you suggest to store these macros used in DTS? Sometimes they do not need storing. If they are worth, then in the DTS headers. Few platforms (Samsung, All of NXP, Mediatek, Sama5/Atmel) are doing it already. Best regards, Krzysztof