From: <Lewis.Hanly@microchip.com>
To: <andy.shevchenko@gmail.com>, <Conor.Dooley@microchip.com>,
<Lewis.Hanly@microchip.com>
Cc: <linux-riscv@lists.infradead.org>, <brgl@bgdev.pl>,
<linux-gpio@vger.kernel.org>, <linus.walleij@linaro.org>,
<palmer@dabbelt.com>, <maz@kernel.org>,
<linux-kernel@vger.kernel.org>, <Daire.McNamara@microchip.com>
Subject: Re: [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Wed, 13 Jul 2022 21:10:28 +0000 [thread overview]
Message-ID: <0a98678605def630303974e40da9990fffd2ad74.camel@microchip.com> (raw)
In-Reply-To: <CAHp75VcoiCVrdEMDrDC8qVZZwYgLTdi50tBxB4BQk=tWQWyOBA@mail.gmail.com>
On Wed, 2022-07-13 at 19:50 +0200, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Wed, Jul 13, 2022 at 7:44 PM <Conor.Dooley@microchip.com> wrote:
> > On 13/07/2022 12:59, Andy Shevchenko wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > know the content is safe
>
> ...
>
> > > > +#define BYTE_BOUNDARY 0x04
> > >
> > > Without namespace?
> >
> > Does byte_boundary even need to be defined?
> > is incrementing an address by 0x4 not kinda obvious on its own
> > as to what it is doing?
>
> The less magic is the better.
>
> Btw, have you considered gpio-regmap? Can it be utilized here?
Yes I have considered regmap, our register map is not mapped out to
fully utilize regmap. We could use for one/two registers but not fully.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2022-07-13 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 10:59 [PATCH v2 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-07-13 10:59 ` [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-07-13 11:26 ` Conor.Dooley
2022-07-13 21:00 ` Lewis.Hanly
2022-07-13 11:59 ` Andy Shevchenko
2022-07-13 17:44 ` Conor.Dooley
2022-07-13 17:50 ` Andy Shevchenko
2022-07-13 21:10 ` Lewis.Hanly [this message]
2022-07-13 20:44 ` Lewis.Hanly
2022-07-13 22:14 ` Andy Shevchenko
2022-07-14 6:19 ` Conor.Dooley
2022-07-15 7:56 ` Lewis.Hanly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a98678605def630303974e40da9990fffd2ad74.camel@microchip.com \
--to=lewis.hanly@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).