From: "Arnd Bergmann" <arnd@arndb.de>
To: "Julian Braha" <julianbraha@gmail.com>,
"Aisheng Dong" <aisheng.dong@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Frank Li" <Frank.Li@nxp.com>, "Jacky Bai" <ping.bai@nxp.com>,
"Linus Walleij" <linusw@kernel.org>
Cc: "Chester Lin" <chester62515@gmail.com>,
"Matthias Brugger" <mbrugger@suse.com>,
"Ghennadi Procopciuc" <ghennadi.procopciuc@oss.nxp.com>,
"NXP S32 Linux Team" <s32@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
"Andrei Stefanescu" <andrei.stefanescu@oss.nxp.com>,
"Khristine Andreea Barbulescu"
<khristineandreea.barbulescu@oss.nxp.com>,
linux-kernel@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC
Date: Wed, 22 Jul 2026 22:39:22 +0200 [thread overview]
Message-ID: <0a99e10e-b4c4-4a64-bcb4-fee8d777d0b7@app.fastmail.com> (raw)
In-Reply-To: <20260722202638.135277-1-julianbraha@gmail.com>
On Wed, Jul 22, 2026, at 22:26, Julian Braha wrote:
> Currently, PINCTRL_S32CC selects PINCTRL_S32CC which needs GPIOLIB, without
> selecting or depending on GPIOLIB.
>
> However, other similar options in this subsystem actually select GPIOLIB
> instead of depending, so I think we can do the same here.
>
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 94cb9e8f2707 ("pinctrl: s32cc: implement GPIO functionality")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
The patch looks fine, but I'm curious about what type of rule found
the mistake. Is this a heuristic that found that drivers/pinctrl/*
overwhelmingly uses select instead of depends, or did kconfirm
find a circular dependency that was caused by inconsistent
rules?
Arnd
next prev parent reply other threads:[~2026-07-22 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 20:26 [PATCH] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC Julian Braha
2026-07-22 20:39 ` Arnd Bergmann [this message]
2026-07-22 21:14 ` Julian Braha
2026-07-22 21:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a99e10e-b4c4-4a64-bcb4-fee8d777d0b7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andrei.stefanescu@oss.nxp.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=chester62515@gmail.com \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=julianbraha@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khristineandreea.barbulescu@oss.nxp.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=ping.bai@nxp.com \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox