* [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
@ 2013-09-11 8:46 José Miguel Gonçalves
2013-09-11 16:27 ` Heiko Stübner
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: José Miguel Gonçalves @ 2013-09-11 8:46 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-gpio, linux-kernel, José Miguel Gonçalves
Some GPIO line limits are incorrectly set which, for instance,
does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
---
arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
drivers/gpio/gpio-samsung.c | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/include/mach/gpio.h b/arch/arm/mach-s3c24xx/include/mach/gpio.h
index 1459156..a1435bc 100644
--- a/arch/arm/mach-s3c24xx/include/mach/gpio.h
+++ b/arch/arm/mach-s3c24xx/include/mach/gpio.h
@@ -31,17 +31,17 @@
* 2410 2412 2440 2443 2416
* 2442
* ---- ---- ---- ---- ----
- * A 23 22 25 16 25
- * B 11 11 11 11 9
- * C 16 15 16 16 16
+ * A 23 22 25 16 27
+ * B 11 11 11 11 11
+ * C 16 16 16 16 16
* D 16 16 16 16 16
* E 16 16 16 16 16
* F 8 8 8 8 8
* G 16 16 16 16 8
- * H 11 11 9 15 15
+ * H 11 11 11 15 15
* J -- -- 13 16 --
* K -- -- -- -- 16
- * L -- -- -- 15 7
+ * L -- -- -- 15 14
* M -- -- -- 2 2
*/
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index 358a21c..29c428b 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -1053,7 +1053,7 @@ struct samsung_gpio_chip s3c24xx_gpios[] = {
.base = S3C2410_GPA(0),
.owner = THIS_MODULE,
.label = "GPIOA",
- .ngpio = 24,
+ .ngpio = 27,
.direction_input = s3c24xx_gpiolib_banka_input,
.direction_output = s3c24xx_gpiolib_banka_output,
},
@@ -1062,7 +1062,7 @@ struct samsung_gpio_chip s3c24xx_gpios[] = {
.base = S3C2410_GPB(0),
.owner = THIS_MODULE,
.label = "GPIOB",
- .ngpio = 16,
+ .ngpio = 11,
},
}, {
.chip = {
@@ -1107,7 +1107,7 @@ struct samsung_gpio_chip s3c24xx_gpios[] = {
.base = S3C2410_GPH(0),
.owner = THIS_MODULE,
.label = "GPIOH",
- .ngpio = 11,
+ .ngpio = 15,
},
},
/* GPIOS for the S3C2443 and later devices. */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-09-11 8:46 [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX José Miguel Gonçalves
@ 2013-09-11 16:27 ` Heiko Stübner
2013-09-27 14:17 ` Linus Walleij
2014-01-02 12:53 ` Linus Walleij
2 siblings, 0 replies; 13+ messages in thread
From: Heiko Stübner @ 2013-09-11 16:27 UTC (permalink / raw)
To: José Miguel Gonçalves
Cc: linux-samsung-soc, linux-gpio, linux-kernel
Am Mittwoch, 11. September 2013, 10:46:13 schrieb José Miguel Gonçalves:
> Some GPIO line limits are incorrectly set which, for instance,
> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
>
> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
I thumbed thru the SoC manuals of s3c2410, s3c2416, s3c2440 and s3c2443 and
these number look correct.
It would be interesting to know where the old number 16 for GPIOB did come
from, as _all_ S3C SoCs only have the 11 pins in this bank.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
> drivers/gpio/gpio-samsung.c | 6 +++---
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/include/mach/gpio.h
> b/arch/arm/mach-s3c24xx/include/mach/gpio.h index 1459156..a1435bc 100644
> --- a/arch/arm/mach-s3c24xx/include/mach/gpio.h
> +++ b/arch/arm/mach-s3c24xx/include/mach/gpio.h
> @@ -31,17 +31,17 @@
> * 2410 2412 2440 2443 2416
> * 2442
> * ---- ---- ---- ---- ----
> - * A 23 22 25 16 25
> - * B 11 11 11 11 9
> - * C 16 15 16 16 16
> + * A 23 22 25 16 27
> + * B 11 11 11 11 11
> + * C 16 16 16 16 16
> * D 16 16 16 16 16
> * E 16 16 16 16 16
> * F 8 8 8 8 8
> * G 16 16 16 16 8
> - * H 11 11 9 15 15
> + * H 11 11 11 15 15
> * J -- -- 13 16 --
> * K -- -- -- -- 16
> - * L -- -- -- 15 7
> + * L -- -- -- 15 14
> * M -- -- -- 2 2
> */
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 358a21c..29c428b 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -1053,7 +1053,7 @@ struct samsung_gpio_chip s3c24xx_gpios[] = {
> .base = S3C2410_GPA(0),
> .owner = THIS_MODULE,
> .label = "GPIOA",
> - .ngpio = 24,
> + .ngpio = 27,
> .direction_input = s3c24xx_gpiolib_banka_input,
> .direction_output = s3c24xx_gpiolib_banka_output,
> },
> @@ -1062,7 +1062,7 @@ struct samsung_gpio_chip s3c24xx_gpios[] = {
> .base = S3C2410_GPB(0),
> .owner = THIS_MODULE,
> .label = "GPIOB",
> - .ngpio = 16,
> + .ngpio = 11,
> },
> }, {
> .chip = {
> @@ -1107,7 +1107,7 @@ struct samsung_gpio_chip s3c24xx_gpios[] = {
> .base = S3C2410_GPH(0),
> .owner = THIS_MODULE,
> .label = "GPIOH",
> - .ngpio = 11,
> + .ngpio = 15,
> },
> },
> /* GPIOS for the S3C2443 and later devices. */
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-09-11 8:46 [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX José Miguel Gonçalves
2013-09-11 16:27 ` Heiko Stübner
@ 2013-09-27 14:17 ` Linus Walleij
2013-12-13 1:55 ` José Miguel Gonçalves
2014-01-02 12:53 ` Linus Walleij
2 siblings, 1 reply; 13+ messages in thread
From: Linus Walleij @ 2013-09-27 14:17 UTC (permalink / raw)
To: José Miguel Gonçalves, Tomasz Figa, Kukjin Kim
Cc: linux-samsung-soc, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Heiko Stübner
On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
<jose.goncalves@inov.pt> wrote:
> Some GPIO line limits are incorrectly set which, for instance,
> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
>
> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> ---
> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
OK but grrrr!
What needs to happen to the s3c24xx is to get rid of this file.
- Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
ARCH_NR_GPIO like everyone else
- Get rid of the config symbol NEED_MACH_GPIO_H
- Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
or whatever and make it local...
I will try to do this myself if noone else helps out, so I'd like to
carry this patch in the GPIO tree provided I can get an ACK from
the S3C24xx maintainer. Tomasz, is that you or Kukjin?
(BTW the above maybe goes for S3c64xx as well .. and S5P
oh well I will get to it.)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-09-27 14:17 ` Linus Walleij
@ 2013-12-13 1:55 ` José Miguel Gonçalves
2013-12-13 8:12 ` Linus Walleij
2013-12-13 9:24 ` kgene
0 siblings, 2 replies; 13+ messages in thread
From: José Miguel Gonçalves @ 2013-12-13 1:55 UTC (permalink / raw)
To: Linus Walleij, Tomasz Figa, Kukjin Kim
Cc: linux-samsung-soc, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Heiko Stübner
On 27-09-2013 15:17, Linus Walleij wrote:
> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> <jose.goncalves@inov.pt> wrote:
>
>> Some GPIO line limits are incorrectly set which, for instance,
>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
>>
>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
>> ---
>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
> OK but grrrr!
>
> What needs to happen to the s3c24xx is to get rid of this file.
>
> - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
> ARCH_NR_GPIO like everyone else
>
> - Get rid of the config symbol NEED_MACH_GPIO_H
>
> - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
> or whatever and make it local...
>
> I will try to do this myself if noone else helps out, so I'd like to
> carry this patch in the GPIO tree provided I can get an ACK from
> the S3C24xx maintainer. Tomasz, is that you or Kukjin?
>
> (BTW the above maybe goes for S3c64xx as well .. and S5P
> oh well I will get to it.)
>
Was this patch forgotten?
José Gonçalves
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 1:55 ` José Miguel Gonçalves
@ 2013-12-13 8:12 ` Linus Walleij
2013-12-13 8:42 ` Heiko Stübner
2013-12-13 9:24 ` kgene
1 sibling, 1 reply; 13+ messages in thread
From: Linus Walleij @ 2013-12-13 8:12 UTC (permalink / raw)
To: José Miguel Gonçalves, Ben Dooks, Kukjin Kim
Cc: Tomasz Figa, linux-samsung-soc, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Heiko Stübner
On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves
<jose.goncalves@inov.pt> wrote:
> On 27-09-2013 15:17, Linus Walleij wrote:
>> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
>> <jose.goncalves@inov.pt> wrote:
>>
>>> Some GPIO line limits are incorrectly set which, for instance,
>>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
>>>
>>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
>>> ---
>>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
(...)
>
> Was this patch forgotten?
Not by me, I just never got an ACK from the Samsung maintainers,
so I can't apply it to the GPIO tree.
Ben, Kukjin: can one of you ACK this so I can take it through the
GPIO tree?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 8:12 ` Linus Walleij
@ 2013-12-13 8:42 ` Heiko Stübner
2013-12-13 9:38 ` José Miguel Gonçalves
0 siblings, 1 reply; 13+ messages in thread
From: Heiko Stübner @ 2013-12-13 8:42 UTC (permalink / raw)
To: Linus Walleij
Cc: José Miguel Gonçalves, Ben Dooks, Kukjin Kim,
Tomasz Figa, linux-samsung-soc, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Am Freitag, 13. Dezember 2013, 09:12:52 schrieb Linus Walleij:
> On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves
>
> <jose.goncalves@inov.pt> wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> >> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> >>
> >> <jose.goncalves@inov.pt> wrote:
> >>> Some GPIO line limits are incorrectly set which, for instance,
> >>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> >>>
> >>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> >>> ---
> >>>
> >>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
>
> (...)
>
> > Was this patch forgotten?
>
> Not by me, I just never got an ACK from the Samsung maintainers,
> so I can't apply it to the GPIO tree.
>
> Ben, Kukjin: can one of you ACK this so I can take it through the
> GPIO tree?
again not the maintainer :-), but I've looked through the manuals of s3c24xx
socs and the new values look correct [I had looked up the patch content in the
list archive], so
Acked-by: Heiko Stuebner <heiko@sntech.de>
But Jose, you should really really look into moving to devicetree with your
platform, if you're not already doing so. Pinctrl support is already present,
and I'm hopefull the move to the common clock framework I posted a few days
ago might make it too.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 8:42 ` Heiko Stübner
@ 2013-12-13 9:38 ` José Miguel Gonçalves
0 siblings, 0 replies; 13+ messages in thread
From: José Miguel Gonçalves @ 2013-12-13 9:38 UTC (permalink / raw)
To: Heiko Stübner, Linus Walleij
Cc: Ben Dooks, Kukjin Kim, Tomasz Figa, linux-samsung-soc,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Heiko,
On 13-12-2013 08:42, Heiko Stübner wrote:
>
> But Jose, you should really really look into moving to devicetree with your
> platform, if you're not already doing so. Pinctrl support is already present,
> and I'm hopefull the move to the common clock framework I posted a few days
> ago might make it too.
>
I'm currently maintaining a deployed equipment whose development started
some time ago, so I still need to use a 3.9 kernel with the traditional
hardware initialization. But, of course, for any new developments based
on the same S3C24XX platform, I will look in migrating to the device tree.
Best regards,
José Gonçalves
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 1:55 ` José Miguel Gonçalves
2013-12-13 8:12 ` Linus Walleij
@ 2013-12-13 9:24 ` kgene
2013-12-13 9:29 ` Heiko Stübner
2013-12-13 9:37 ` Linus Walleij
1 sibling, 2 replies; 13+ messages in thread
From: kgene @ 2013-12-13 9:24 UTC (permalink / raw)
To: 'José Miguel Gonçalves',
'Linus Walleij', 'Tomasz Figa'
Cc: 'linux-samsung-soc', linux-gpio, linux-kernel,
'Heiko Stübner'
José Miguel Gonçalves wrote:
>
> On 27-09-2013 15:17, Linus Walleij wrote:
> > On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> > <jose.goncalves@inov.pt> wrote:
> >
> >> Some GPIO line limits are incorrectly set which, for instance,
> >> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> >>
> >> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> >> ---
> >> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
> > OK but grrrr!
> >
> > What needs to happen to the s3c24xx is to get rid of this file.
> >
> > - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
> > ARCH_NR_GPIO like everyone else
> >
> > - Get rid of the config symbol NEED_MACH_GPIO_H
> >
> > - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
> > or whatever and make it local...
> >
> > I will try to do this myself if noone else helps out, so I'd like to
> > carry this patch in the GPIO tree provided I can get an ACK from
> > the S3C24xx maintainer. Tomasz, is that you or Kukjin?
> >
> > (BTW the above maybe goes for S3c64xx as well .. and S5P
> > oh well I will get to it.)
> >
>
> Was this patch forgotten?
>
Hi Jose,
Sorry about missing your patch. It's my fault :( and as you know, at this
moment the file will be removed by Linus' patch...
Anyway, let me look at the Samsung patches closely ;)
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 9:24 ` kgene
@ 2013-12-13 9:29 ` Heiko Stübner
2013-12-13 9:37 ` Linus Walleij
1 sibling, 0 replies; 13+ messages in thread
From: Heiko Stübner @ 2013-12-13 9:29 UTC (permalink / raw)
To: kgene
Cc: 'José Miguel Gonçalves',
'Linus Walleij', 'Tomasz Figa',
'linux-samsung-soc', linux-gpio, linux-kernel
Am Freitag, 13. Dezember 2013, 10:24:59 schrieb kgene@kernel.org:
> José Miguel Gonçalves wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> > > On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> > >
> > > <jose.goncalves@inov.pt> wrote:
> > >> Some GPIO line limits are incorrectly set which, for instance,
> > >> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> > >>
> > >> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> > >> ---
> > >>
> > >> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
> > >
> > > OK but grrrr!
> > >
> > > What needs to happen to the s3c24xx is to get rid of this file.
> > >
> > > - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
> > >
> > > ARCH_NR_GPIO like everyone else
> > >
> > > - Get rid of the config symbol NEED_MACH_GPIO_H
> > >
> > > - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
> > >
> > > or whatever and make it local...
> > >
> > > I will try to do this myself if noone else helps out, so I'd like to
> > > carry this patch in the GPIO tree provided I can get an ACK from
> > > the S3C24xx maintainer. Tomasz, is that you or Kukjin?
> > >
> > > (BTW the above maybe goes for S3c64xx as well .. and S5P
> > > oh well I will get to it.)
> >
> > Was this patch forgotten?
>
> Hi Jose,
>
> Sorry about missing your patch. It's my fault :( and as you know, at this
> moment the file will be removed by Linus' patch...
>
> Anyway, let me look at the Samsung patches closely ;)
The comment that is changed in the header is removed by Linus' patch, but the
change to the gpio driver is still relevant for the time being I'd think.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 9:24 ` kgene
2013-12-13 9:29 ` Heiko Stübner
@ 2013-12-13 9:37 ` Linus Walleij
2013-12-20 9:12 ` Linus Walleij
1 sibling, 1 reply; 13+ messages in thread
From: Linus Walleij @ 2013-12-13 9:37 UTC (permalink / raw)
To: Kukjin Kim
Cc: José Miguel Gonçalves, Tomasz Figa, linux-samsung-soc,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Stübner
On Fri, Dec 13, 2013 at 10:24 AM, <kgene@kernel.org> wrote:
> José Miguel Gonçalves wrote:
(..)
>> Was this patch forgotten?
>>
> Hi Jose,
>
> Sorry about missing your patch. It's my fault :( and as you know, at this
> moment the file will be removed by Linus' patch...
Oh I can certainly rebase the patch onto my tree if I just
get an ACK for it...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-13 9:37 ` Linus Walleij
@ 2013-12-20 9:12 ` Linus Walleij
2013-12-20 20:57 ` Kukjin Kim
0 siblings, 1 reply; 13+ messages in thread
From: Linus Walleij @ 2013-12-20 9:12 UTC (permalink / raw)
To: Kukjin Kim
Cc: José Miguel Gonçalves, Tomasz Figa, linux-samsung-soc,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Stübner
On Fri, Dec 13, 2013 at 10:37 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Fri, Dec 13, 2013 at 10:24 AM, <kgene@kernel.org> wrote:
>> José Miguel Gonçalves wrote:
> (..)
>>> Was this patch forgotten?
>>>
>> Hi Jose,
>>
>> Sorry about missing your patch. It's my fault :( and as you know, at this
>> moment the file will be removed by Linus' patch...
>
> Oh I can certainly rebase the patch onto my tree if I just
> get an ACK for it...
Kukjin, can I have your ACK for this patch?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-12-20 9:12 ` Linus Walleij
@ 2013-12-20 20:57 ` Kukjin Kim
0 siblings, 0 replies; 13+ messages in thread
From: Kukjin Kim @ 2013-12-20 20:57 UTC (permalink / raw)
To: Linus Walleij
Cc: Kukjin Kim, José Miguel Gonçalves, Tomasz Figa,
linux-samsung-soc, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Heiko Stübner
On 12/20/13 18:12, Linus Walleij wrote:
> On Fri, Dec 13, 2013 at 10:37 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> On Fri, Dec 13, 2013 at 10:24 AM,<kgene@kernel.org> wrote:
>>> José Miguel Gonçalves wrote:
>> (..)
>>>> Was this patch forgotten?
>>>>
>>> Hi Jose,
>>>
>>> Sorry about missing your patch. It's my fault :( and as you know, at this
>>> moment the file will be removed by Linus' patch...
>>
>> Oh I can certainly rebase the patch onto my tree if I just
>> get an ACK for it...
>
> Kukjin, can I have your ACK for this patch?
>
Sure, please go ahead with my ack.
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks and Merry Christmas :-)
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
2013-09-11 8:46 [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX José Miguel Gonçalves
2013-09-11 16:27 ` Heiko Stübner
2013-09-27 14:17 ` Linus Walleij
@ 2014-01-02 12:53 ` Linus Walleij
2 siblings, 0 replies; 13+ messages in thread
From: Linus Walleij @ 2014-01-02 12:53 UTC (permalink / raw)
To: José Miguel Gonçalves
Cc: linux-samsung-soc, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
<jose.goncalves@inov.pt> wrote:
> Some GPIO line limits are incorrectly set which, for instance,
> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
>
> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
Patch applied with Kukjin's ACK and Heiko's review tag.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-01-02 12:53 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 8:46 [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX José Miguel Gonçalves
2013-09-11 16:27 ` Heiko Stübner
2013-09-27 14:17 ` Linus Walleij
2013-12-13 1:55 ` José Miguel Gonçalves
2013-12-13 8:12 ` Linus Walleij
2013-12-13 8:42 ` Heiko Stübner
2013-12-13 9:38 ` José Miguel Gonçalves
2013-12-13 9:24 ` kgene
2013-12-13 9:29 ` Heiko Stübner
2013-12-13 9:37 ` Linus Walleij
2013-12-20 9:12 ` Linus Walleij
2013-12-20 20:57 ` Kukjin Kim
2014-01-02 12:53 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).