From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: linus.walleij@linaro.org, andreas@gaisler.com
Cc: linux-gpio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] drivers/gpio: some possible sleep-in-atomic bugs
Date: Tue, 12 Dec 2017 11:59:26 +0800 [thread overview]
Message-ID: <0bcab5c0-d938-9eb6-d21d-6b8416d75a65@gmail.com> (raw)
According to drivers/gpio/gpio-grgpio.c, the kernel module may sleep
under a spinlock.
The function call paths are:
grgpio_remove (acquire the spinlock)
gpiochip_remove
gpiochip_sysfs_unregister
device_unregister --> may sleep
mutex_lock --> may sleep
grgpio_remove (acquire the spinlock)
gpiochip_remove
gpiochip_sysfs_unregister
gpiod_free
__gpiod_free
gpiod_unexport
device_unregister --> may sleep
mutex_lock --> may sleep
grgpio_remove (acquire the spinlock)
irq_domain_remove
mutex_lock --> may sleep
grgpio_irq_map (acquire the spinlock)
request_irq --> may sleep
grgpio_irq_unmap (acquire the spinlock)
free_irq --> may sleep
I do not find a good way to fix them, so I only report.
These possible bugs is found by my static analysis tool (DSAC) and
checked by my code review.
Thanks,
Jia-Ju Bai
next reply other threads:[~2017-12-12 3:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 3:59 Jia-Ju Bai [this message]
2017-12-13 16:18 ` [BUG] drivers/gpio: some possible sleep-in-atomic bugs Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bcab5c0-d938-9eb6-d21d-6b8416d75a65@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=andreas@gaisler.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).