From: Cosmin Tanislav <demonsingur@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Cosmin Tanislav <cosmin.tanislav@analog.com>
Subject: Re: [PATCH v1 2/3] iio: ABI: adc: ad4130: document filter_mode{,_available}
Date: Thu, 14 Apr 2022 10:41:09 +0300 [thread overview]
Message-ID: <0de7fcb5-0d5f-d8b3-448a-2bc14cef21ee@gmail.com> (raw)
In-Reply-To: <CAHp75VexJBnAqoQ53=_nif=bso0-cNj4EsTbUwKGKxfNq_Fvyw@mail.gmail.com>
On 4/13/22 17:51, Andy Shevchenko wrote:
> On Wed, Apr 13, 2022 at 4:17 PM Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
> It's good you provided documentation, but I think the part "ABI:" is
> not needed in the Subject.
>
Then I guess I could merge this patch into the driver patch?
>> AD4130-8 is an ultra-low power, high precision,
>> measurement solution for low bandwidth battery
>> operated applications.
>>
>> The fully integrated AFE (Analog Front-End)
>> includes a multiplexer for up to 16 single-ended
>> or 8 differential inputs, PGA (Programmable Gain
>> Amplifier), 24-bit Sigma-Delta ADC, on-chip
>> reference and oscillator, selectable filter
>> options, smart sequencer, sensor biasing and
>> excitation options, diagnostics, and a FIFO
>> buffer.
>
> Indentation issue as per patch 1.
>
> ...
>
>> + Set the filter mode of the differential channel. When the filter
>> + mode changes, the in_voltageY-voltageZ_sampling_frequency and
>> + in_voltageY-voltageZ_sampling_frequency_available attributes
>> + might also change to accomodate the new filter mode.
>
> accommodate
>
>> + If the current sampling frequency is out of range for the new
>> + filter mode, the sampling frequency will be changed to the
>> + closest valid one.
>
>
next prev parent reply other threads:[~2022-04-14 7:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:40 [PATCH v1 1/3] dt-bindings: iio: adc: add AD4130 Cosmin Tanislav
2022-04-13 9:40 ` [PATCH v1 2/3] iio: ABI: adc: ad4130: document filter_mode{,_available} Cosmin Tanislav
2022-04-13 14:51 ` Andy Shevchenko
2022-04-14 7:41 ` Cosmin Tanislav [this message]
2022-04-16 15:02 ` Jonathan Cameron
2022-04-13 9:40 ` [PATCH v1 3/3] iio: adc: ad4130: add AD4130 driver Cosmin Tanislav
2022-04-13 15:41 ` Andy Shevchenko
2022-04-14 11:06 ` Cosmin Tanislav
2022-04-14 13:45 ` Andy Shevchenko
2022-04-14 14:53 ` Cosmin Tanislav
2022-04-14 15:37 ` Andy Shevchenko
2022-04-16 15:07 ` Jonathan Cameron
2022-04-16 16:21 ` Jonathan Cameron
2022-04-17 10:26 ` Cosmin Tanislav
2022-04-24 15:51 ` Jonathan Cameron
2022-04-13 12:26 ` [PATCH v1 1/3] dt-bindings: iio: adc: add AD4130 Rob Herring
2022-04-13 14:50 ` Andy Shevchenko
2022-04-16 15:00 ` Jonathan Cameron
2022-04-17 10:16 ` Cosmin Tanislav
2022-04-24 16:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0de7fcb5-0d5f-d8b3-448a-2bc14cef21ee@gmail.com \
--to=demonsingur@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=cosmin.tanislav@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).