Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Dipen Patel <dipenp@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] hte: tegra-194: Use proper includes
Date: Thu, 20 Apr 2023 13:19:53 -0700	[thread overview]
Message-ID: <0ec147e4-7be8-3187-0a37-249f42533724@nvidia.com> (raw)
In-Reply-To: <20230117084159.485234-1-linus.walleij@linaro.org>

On 1/17/23 12:41 AM, Linus Walleij wrote:
> The test driver uses the gpiod consumer API so include the right
> <linux/gpio/consumer.h> header. This may cause a problem with
> struct of_device_id being implcitly pulled in by the legacy
> header <linux/gpio.h> so include <linux/mod_devicetable.h>
> explicitly as well.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Its mod_devicetable not mod_device_table oops.
> ---
>  drivers/hte/hte-tegra194-test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
> index 5d776a185bd6..79eb866558d3 100644
> --- a/drivers/hte/hte-tegra194-test.c
> +++ b/drivers/hte/hte-tegra194-test.c
> @@ -6,10 +6,11 @@
>   */
>  
>  #include <linux/err.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
>  #include <linux/interrupt.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/timer.h>
>  #include <linux/platform_device.h>
>  #include <linux/workqueue.h>

I am not sure if I have followed up on this patchset. It seems this gives an error mod_devicetable.h not found. Perhaps you meant, linux/mod_devicetable.h instead?


  reply	other threads:[~2023-04-20 20:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17  8:41 [PATCH v2] hte: tegra-194: Use proper includes Linus Walleij
2023-04-20 20:19 ` Dipen Patel [this message]
2023-04-20 20:48   ` Linus Walleij
2023-04-20 20:54     ` Dipen Patel
2023-04-20 21:22 ` Dipen Patel
2023-04-20 21:48   ` Dipen Patel
2023-04-21  7:42     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ec147e4-7be8-3187-0a37-249f42533724@nvidia.com \
    --to=dipenp@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox