From: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
stable@vger.kernel.org,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v2] gpio: pca953x: fix IRQ storm on system wake up
Date: Mon, 12 May 2025 11:38:40 +0200 [thread overview]
Message-ID: <10caddc8-7dc1-4579-9edb-4514efa540cd@gmail.com> (raw)
In-Reply-To: <aCG-DZI4fexZGy2H@smile.fi.intel.com>
On 12/05/2025 11:23, Andy Shevchenko wrote:
> On Mon, May 12, 2025 at 11:17:48AM +0200, Geert Uytterhoeven wrote:
>> On Fri, 9 May 2025 at 16:18, Francesco Dolcini <francesco@dolcini.it> wrote:
>>> An irq can be disabled with disable_irq() and still wake the system as
>>> long as the irq has wake enabled, so the wake-up functionality is
>>> preserved.
>
> ...
>
>> While this does not cause the regression seen on Salvator-XS with
>> the earlier approach[1], I expect this will break using a GPIO as a
>> wake-up source?
>
> Good point! Have this code been checked for that kind of scenarios?
>
>> [1] https://lore.kernel.org/linux-gpio/CAMuHMdVnKX23yi7ir1LVxfXAMeeWMFzM+cdgSSTNjpn1OnC2xw@mail.gmail.com
>
Yes, I tested this specific scenario with its GPIOs as wake-up sources, and it
worked as expected. I already included the note in the commit message.
Kind regards,
Emanuele
next prev parent reply other threads:[~2025-05-12 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 14:18 [PATCH v2] gpio: pca953x: fix IRQ storm on system wake up Francesco Dolcini
2025-05-09 15:08 ` Andy Shevchenko
2025-05-12 9:17 ` Geert Uytterhoeven
2025-05-12 9:23 ` Andy Shevchenko
2025-05-12 9:38 ` Emanuele Ghidoli [this message]
2025-05-12 9:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10caddc8-7dc1-4579-9edb-4514efa540cd@gmail.com \
--to=ghidoliemanuele@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=emanuele.ghidoli@toradex.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).