Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Robert Schwebel <r.schwebel@pengutronix.de>,
	Sascha Hauer <sha@pengutronix.de>,
	bartosz.golaszewski@linaro.org,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	christophe.leroy@csgroup.eu, linux-gpio@vger.kernel.org,
	kernel@pengutronix.de, shawnguo@kernel.org
Subject: Re: GPIO static allocation warning with v6.2-rcX
Date: Tue, 31 Jan 2023 08:21:08 +0100	[thread overview]
Message-ID: <12150419.O9o76ZdvQC@steina-w> (raw)
In-Reply-To: <CAL_JsqJofZ5386oS1hkme2n_pbQVe3OAVxusQvs43wzKCM2LZw@mail.gmail.com>

Hi Rob,

Am Montag, 30. Januar 2023, 16:45:57 CET schrieb Rob Herring:
> On Mon, Jan 30, 2023 at 9:02 AM Linus Walleij <linus.walleij@linaro.org> 
wrote:
> > On Mon, Jan 30, 2023 at 12:02 PM Marco Felsch <m.felsch@pengutronix.de> 
wrote:
> > > On 23-01-30, Linus Walleij wrote:
> > > > On Sun, Jan 29, 2023 at 7:33 PM Robert Schwebel
> > > > 
> > > > <r.schwebel@pengutronix.de> wrote:
> > > > > While this could also be done with a daemon offering a dbus api,
> > > > > this
> > > > > would be significantly more complex. In a critical environment, one
> > > > > needs to make sure that the daemon process never fails, otherwhise
> > > > > the
> > > > > power of the DuT would maybe be in a random state. Then of course
> > > > > one
> > > > > can add a watchdog, but with the current sysfs interface it's really
> > > > > simple. Of course that would also work if the new interface would
> > > > > offer
> > > > > a "keep this line as it is" feature, but adding a dbus daemon just
> > > > > for
> > > > > keeping the state of a pin sounds overcomplex when the kernel could
> > > > > also
> > > > > provide that functionality.
> > > > 
> > > > One issue we face as developers is scaleability. Things that
> > > > seem straight forward on a single board computer in a lab get
> > > > really complex in a big system with man GPIO chips.
> > > > 
> > > > One of the big dangers of the sysfs ABI is that it is dependent on
> > > > probe order which the kernel sadly does not really guarantee.
> > > 
> > > Does it? At least the drive I listed (e.g. the imx gpio driver) uses
> > > aliases to make it reliable.
> > 
> > I'm not sure that is the intended use of the aliases in device tree.
> > (Rob can maybe answer this.)
> 
> The kernel community's position on stable device numbers for userspace
> is quite clear.

Sorry for this stupid question: What position is it? Is it documented 
somewhere?

> That is how aliases get used by the kernel though. IMO, they should be
> limited to a documented set of alias names, and GPIO is not one of
> them. We replaced the whole GPIO sysfs API for this reason (among
> others).

So in which case, or under which circumstances, aliases are acceptable?

Best regards,
Alexander

> IIRC, i.MX is one of the worst abusers with aliases for everything,
> most of which should be removed.
> 
> Rob




  reply	other threads:[~2023-01-31  7:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 10:46 GPIO static allocation warning with v6.2-rcX Marco Felsch
2023-01-23 14:55 ` Bartosz Golaszewski
2023-01-23 14:56   ` Bartosz Golaszewski
2023-01-25  9:35   ` Sascha Hauer
2023-01-25 13:56     ` Bartosz Golaszewski
2023-01-26 10:27       ` Sascha Hauer
2023-01-26  1:57     ` Kent Gibson
2023-01-26 10:14       ` Sascha Hauer
2023-01-26 10:26         ` Kent Gibson
2023-01-26  9:35     ` Linus Walleij
2023-01-26 10:49       ` Sascha Hauer
2023-01-29 18:33         ` Robert Schwebel
2023-01-30 10:19           ` Linus Walleij
2023-01-30 11:02             ` Marco Felsch
2023-01-30 15:01               ` Linus Walleij
2023-01-30 15:45                 ` Rob Herring
2023-01-31  7:21                   ` Alexander Stein [this message]
2023-01-30 17:26                 ` Andy Shevchenko
2023-01-30 16:48             ` Uwe Kleine-König
2023-01-30 17:21               ` Bartosz Golaszewski
2023-01-30 23:26               ` Linus Walleij
2023-03-02  2:19           ` Kent Gibson
2023-03-02 15:40             ` Andy Shevchenko
2023-01-26  9:42     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12150419.O9o76ZdvQC@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=christophe.leroy@csgroup.eu \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=r.schwebel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sha@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox