linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Levente Révész" <levente.revesz@eilabs.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Martyn Welch" <martyn.welch@collabora.com>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Puyou Lu" <puyou.lu@gmail.com>,
	"Justin Chen" <justinpopo6@gmail.com>,
	"Andrey Gusakov" <andrey.gusakov@cogentembedded.com>,
	"Nate Drude" <nate.d@variscite.com>,
	"Dávid Jenei" <david.jenei@eilabs.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 2/6] gpio: pca953x: Add PCAL953X as a separate chip type
Date: Wed, 16 Nov 2022 14:51:09 +0100	[thread overview]
Message-ID: <12c33c55-a0ec-3dc0-2416-f3dcd7f74f44@eilabs.com> (raw)
In-Reply-To: <67bba210-09ac-32fb-bb97-8bfc40c2c200@eilabs.com>

On Thu, 28 Oct 2022 20:57 +0200, Levente Révész wrote:
> I went through all the datasheets and created this note listing
> chip functions and register layouts.

On Thu, 27 Oct 2022 20:03:21 +0300, Andy Shevchenko wrote
> PCA_PCAL is about having latched interrupts, it doesn't suggest
> the layout. So, somebody needs to take a pen and draw the current
> list of possible combinations of the features and layouts and then
> we can see what can be done as a type and what's not.

The note in my previous email lists the functions of each chip this
driver supports. The currently supported features are the following:

    - basic interrupt (no registers)
    - interrupt status and mask registers
    - bias (pull-up, pull-down)
    - input latch

Proposed chip types to allow implementing these functions for all chips
that have them:

    1. PCA953X without interrupt
        also covers some MAX731X chips
    2. PCA953X
        also covers some MAX731X chips
    3. PCA950X
        also covers PCA9698
    4. PCAL953X
        also covers PCAL652X
    5. PCAL653X
    6. PCA957X
    7. XRA120X

Other functions which could be used for pinconfig, but are not currently
implemented for any of the chips in the driver:

    - interrupt on specific edges
    - drive mode (push-pull or open-drain)
    - drive strength
    - debounce

Proposed chip types to allow implementing all of these functions for
all chips that support them:

    1. PCA953X without interrupt
        also covers some MAX731X chips
    2. PCA953X
        also covers some MAX731X chips
    3. PCA950X
    4. PCA9698
    5. PCAL953X
    6. PCAL652X
    7. PCAL653X
    8. PCA957X
    9. XRA120X

Should the chip type take all relevant chip functions into account, or
just the currently implemented functions?


---
Best Regards,
Levente


  reply	other threads:[~2022-11-16 13:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 11:17 [PATCH v2 0/6] gpio: pca953x: Add interrupt mask support for pca953x chips Levente Révész
2022-10-26 11:18 ` [PATCH v2 1/6] gpio: pca953x: Convert PCA_TYPE from bits to number Levente Révész
2022-10-26 17:18   ` Andy Shevchenko
2022-10-26 17:21     ` Andy Shevchenko
2022-10-26 11:21 ` [PATCH v2 2/6] gpio: pca953x: Add PCAL953X as a separate chip type Levente Révész
2022-10-26 17:25   ` Andy Shevchenko
2022-10-26 17:28   ` Andy Shevchenko
2022-10-27 13:36     ` Levente Révész
2022-10-27 13:54       ` Martyn Welch
2022-10-27 17:03         ` Andy Shevchenko
2022-10-28 18:57           ` Levente Révész
2022-11-16 13:51             ` Levente Révész [this message]
2025-02-26 14:02             ` Andy Shevchenko
2022-10-26 11:22 ` [PATCH v2 3/6] gpio: pca953x: Add helper function to check if chip has interrupts Levente Révész
2022-10-26 11:23 ` [PATCH v2 4/6] gpio: pca953x: Generalize interrupt mask register handling Levente Révész
2022-10-26 17:31   ` Andy Shevchenko
2022-10-26 11:25 ` [PATCH v2 5/6] gpio: pca953x: Add interrupt mask support for chips with the standard register set Levente Révész
2022-10-26 16:49   ` kernel test robot
2022-10-26 17:32   ` Andy Shevchenko
2022-10-26 22:13   ` kernel test robot
2022-10-26 22:13   ` kernel test robot
2022-10-26 11:26 ` [PATCH v2 6/6] gpio: pca953x: Enable interrupt for pca9698 Levente Révész

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c33c55-a0ec-3dc0-2416-f3dcd7f74f44@eilabs.com \
    --to=levente.revesz@eilabs.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=david.jenei@eilabs.com \
    --cc=haibo.chen@nxp.com \
    --cc=justinpopo6@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=martyn.welch@collabora.com \
    --cc=nate.d@variscite.com \
    --cc=puyou.lu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).