Re: [PATCH] emev2: GPIOLIB: Enable support for OF

Re: [PATCH] emev2: GPIOLIB: Enable support for OF

[Linus Walleij]

On Tue, Aug 27, 2013 at 7:04 PM, Ian Molton <ian.molton@codethink.co.uk> wrote:

> Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
> ---
>  drivers/gpio/gpio-em.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
> index 5cba855..279821e 100644
> --- a/drivers/gpio/gpio-em.c
> +++ b/drivers/gpio/gpio-em.c
> @@ -303,6 +303,7 @@ static int em_gio_probe(struct platform_device *pdev)
>         }
>
>         gpio_chip = &p->gpio_chip;
> +       gpio_chip->of_node = pdev->dev.of_node;

This doesn't work on non-DT compiles.

Look at struct gpio_chip:

#if defined(CONFIG_OF_GPIO)
        /*
         * If CONFIG_OF is enabled, then all GPIO controllers described in the
         * device tree automatically may have an OF translation
         */
        struct device_node *of_node;
        int of_gpio_n_cells;
        int (*of_xlate)(struct gpio_chip *gc,
                        const struct of_phandle_args *gpiospec, u32 *flags);
#endif

Either the statement needs to be inside #ifdef CONFIG_OF_GPIO
or the Emma driver need to select OF_GPIO in its Kconfig
entry.

Yours,
Linus Walleij

Re: [PATCH] emev2: GPIOLIB: Enable support for OF

[Simon Horman]

On Thu, Aug 29, 2013 at 07:41:42PM +0200, Linus Walleij wrote:
> On Tue, Aug 27, 2013 at 7:04 PM, Ian Molton <ian.molton@codethink.co.uk> wrote:
> 
> > Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
> > ---
> >  drivers/gpio/gpio-em.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
> > index 5cba855..279821e 100644
> > --- a/drivers/gpio/gpio-em.c
> > +++ b/drivers/gpio/gpio-em.c
> > @@ -303,6 +303,7 @@ static int em_gio_probe(struct platform_device *pdev)
> >         }
> >
> >         gpio_chip = &p->gpio_chip;
> > +       gpio_chip->of_node = pdev->dev.of_node;
> 
> This doesn't work on non-DT compiles.
> 
> Look at struct gpio_chip:
> 
> #if defined(CONFIG_OF_GPIO)
>         /*
>          * If CONFIG_OF is enabled, then all GPIO controllers described in the
>          * device tree automatically may have an OF translation
>          */
>         struct device_node *of_node;
>         int of_gpio_n_cells;
>         int (*of_xlate)(struct gpio_chip *gc,
>                         const struct of_phandle_args *gpiospec, u32 *flags);
> #endif
> 
> Either the statement needs to be inside #ifdef CONFIG_OF_GPIO
> or the Emma driver need to select OF_GPIO in its Kconfig
> entry.

This may be somewhat naieve, but it seems to me that the latter would be a
better choice at this stage because AFIK the only in-tree emev2 board is
the kzm9d and it uses USE_OF.

Re: [PATCH] emev2: GPIOLIB: Enable support for OF

[Linus Walleij]

On Fri, Aug 30, 2013 at 5:47 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Aug 29, 2013 at 07:41:42PM +0200, Linus Walleij wrote:

>> Either the statement needs to be inside #ifdef CONFIG_OF_GPIO
>> or the Emma driver need to select OF_GPIO in its Kconfig
>> entry.
>
> This may be somewhat naieve, but it seems to me that the latter would be a
> better choice at this stage because AFIK the only in-tree emev2 board is
> the kzm9d and it uses USE_OF.

I think you're right. Ian can you cook a patch that also selects
OF_GPIO for this controller in Kconfig?

Yours,
Linus Walleij

(unknown),

[Ian Molton]

Patch updated to depend on OF_GPIO as suggested. The only other driver using
OF_GPIO depends, rather than selects the symbol, so I have also.

-Ian

[PATCH] emev2: GPIOLIB: Enable support for OF

[Ian Molton]

EMEV2 is now a DT platform, however the GPIO driver cannot be used
from a DT file since it does not fill out the of_node field in its
gpio_chip structure.

Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
---
 drivers/gpio/Kconfig   |    2 +-
 drivers/gpio/gpio-em.c |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index b2450ba..58e043d 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -129,7 +129,7 @@ config GPIO_IT8761E
 
 config GPIO_EM
 	tristate "Emma Mobile GPIO"
-	depends on ARM
+	depends on ARM && OF_GPIO
 	help
 	  Say yes here to support GPIO on Renesas Emma Mobile SoCs.
 
diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index 5cba855..279821e 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -303,6 +303,7 @@ static int em_gio_probe(struct platform_device *pdev)
 	}
 
 	gpio_chip = &p->gpio_chip;
+	gpio_chip->of_node = pdev->dev.of_node;
 	gpio_chip->direction_input = em_gio_direction_input;
 	gpio_chip->get = em_gio_get;
 	gpio_chip->direction_output = em_gio_direction_output;
-- 
1.7.10.4

Re: [PATCH] emev2: GPIOLIB: Enable support for OF

[Simon Horman]

[ CC Magnus ]

On Mon, Sep 02, 2013 at 04:44:55PM +0100, Ian Molton wrote:
> EMEV2 is now a DT platform, however the GPIO driver cannot be used
> from a DT file since it does not fill out the of_node field in its
> gpio_chip structure.
> 
> Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>

I have no objections to this.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


> ---
>  drivers/gpio/Kconfig   |    2 +-
>  drivers/gpio/gpio-em.c |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index b2450ba..58e043d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -129,7 +129,7 @@ config GPIO_IT8761E
>  
>  config GPIO_EM
>  	tristate "Emma Mobile GPIO"
> -	depends on ARM
> +	depends on ARM && OF_GPIO
>  	help
>  	  Say yes here to support GPIO on Renesas Emma Mobile SoCs.
>  
> diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
> index 5cba855..279821e 100644
> --- a/drivers/gpio/gpio-em.c
> +++ b/drivers/gpio/gpio-em.c
> @@ -303,6 +303,7 @@ static int em_gio_probe(struct platform_device *pdev)
>  	}
>  
>  	gpio_chip = &p->gpio_chip;
> +	gpio_chip->of_node = pdev->dev.of_node;
>  	gpio_chip->direction_input = em_gio_direction_input;
>  	gpio_chip->get = em_gio_get;
>  	gpio_chip->direction_output = em_gio_direction_output;
> -- 
> 1.7.10.4
> 

Re: [PATCH] emev2: GPIOLIB: Enable support for OF

[Linus Walleij]

On Mon, Sep 2, 2013 at 5:44 PM, Ian Molton <ian.molton@codethink.co.uk> wrote:

> EMEV2 is now a DT platform, however the GPIO driver cannot be used
> from a DT file since it does not fill out the of_node field in its
> gpio_chip structure.
>
> Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>

This v2 version applied with Simon's ACK.

Yours,
Linus Walleij

(unknown)

[MRS GRACE MANDA]

[-- Attachment #1: Type: text/plain, Size: 71 bytes --]









This is Mrs Grace Manda (  Please I need your Help is Urgent). 

[-- Attachment #2: Mrs Grace Manda.rtf --]
[-- Type: application/rtf, Size: 35796 bytes --]

(unknown),

[Alfred Cheuk Chow]

-- 
Good Day,

I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong
Hing Bank, Hong Kong, Chong Hing Bank Centre, 24 Des Voeux Road Central,
Hong Kong. I have a business proposal of $38,980,369.00 (Thirty Eight
Million, Nine Hundred and Eighty Thousand, Three Hundred and Sixty Nine
USD) only for you to transact with me from my bank to your country.

All confirmable documents to back up the claims will be made available to
you prior to your acceptance and as soon as I receive your return mail Via
my email address: alfred.chow101@gmail.com and I will let you know what is
required of you.

Your earliest response to this letter will be appreciated.

Best Regards,
Alfred Chow

(unknown),

[Alfred Cheuk Chow]

-- 
I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Centre, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $38,980,369.00All conformable documents to back up the claims will be made available to you prior to your acceptance and as soon as I receive your return mail and I will let you know what is required of you.

Best Regards,
Alfred Chow
Tel: +85258032828

(unknown),

[Alfred Cheuk Chow]

Good Day,

I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Centre, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $38,980,369.00 (Thirty Eight Million, Nine Hundred and Eighty Thousand, Three Hundred and Sixty Nine USD) only for you to transact with me from my bank to your country.

All confirmable documents to back up the claims will be made available to you prior to your acceptance and as soon as I receive your return mail Via my email address: alfred.chow101@gmail.com and I will let you know what is required of you.

Your earliest response to this letter will be appreciated.
 
Best Regards,
Alfred Chow

(unknown),

[Alicia Polanco]

This is to re-notify you of the $8,564 USD that was deposited here in
the Western Union office in your name.We have successfully complete
your fund transfer to you, You should contact Transaction Manager
Monica Winks to collect your money transfer control number (M.T.C.N).

Contact Email: mvv.dept@gmail.com
Contact Person: Monica Winks

Awaiting your quick response.

(unknown),

[Charles Ethan]

Excuse me please;Did you receive my previous email.Charles Ethan

(unknown),

[Aisha Aisha]

I pray this mail reach you in good faith, I need you to assist me
relocate $9 Million to your country through your bank account and you
will be rewarded with 30% of the sum once the transaction is
successfully done, let me know if you are capable to handle the
project so that i will give you details.

Regards,
Aisha G.

(unknown),

[Anatolij Gustschin]

Subject: [PATCH v3] gpiolib: Add stubs for gpiod lookup table interface

Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
for the !GPIOLIB case to prevent build errors. Also add prototypes.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
Changes in v3:
 - add stubs for !GPIOLIB case. Drop prototypes, these are
   already in gpio/machine.h

Changes in v2:
 - move gpiod_lookup_table out of #ifdef

 include/linux/gpio/consumer.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index 8f702fc..cf3fee2 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -41,6 +41,8 @@ enum gpiod_flags {
 			  GPIOD_FLAGS_BIT_DIR_VAL,
 };
 
+struct gpiod_lookup_table;
+
 #ifdef CONFIG_GPIOLIB
 
 /* Return the number of GPIOs associated with a device / function */
@@ -435,6 +437,12 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
 	return ERR_PTR(-ENOSYS);
 }
 
+static inline
+void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
+
+static inline
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
+
 #endif /* CONFIG_GPIOLIB */
 
 static inline
-- 
2.7.4

(unknown),

[hastpass]

[-- Attachment #1: EMAIL_847312_linux-gpio.zip --]
[-- Type: application/zip, Size: 3509 bytes --]

(unknown)

[Chris Ruehl]

unsubscribe linux-gpio

(unknown),

[Andrew Clement]

I sent a message to you before which i am still waiting for your
respones please do reply me.

(unknown),

[Alfred Cheuk Chow]

Good Day,

I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong
Hing Bank, Hong Kong, Chong Hing Bank Center, 24 Des Voeux Road Central,
Hong Kong. I have a business proposal of $ 38,980,369.00.

All confirmable documents to back up the claims will be made available
to you prior to your acceptance and as soon as I receive your return
mail.

Best Regards,
Alfred Chow.

(unknown)

[zhuchangchun]

subscribe linux-kernel