* [PATCH 1/1] gpio: gpio-mc33880: Remove redundant spi_set_drvdata
@ 2013-09-19 12:00 Sachin Kamat
2013-09-23 10:53 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-09-19 12:00 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, sachin.kamat
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/gpio/gpio-mc33880.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c
index 3fd2caa..c0b7835 100644
--- a/drivers/gpio/gpio-mc33880.c
+++ b/drivers/gpio/gpio-mc33880.c
@@ -142,7 +142,6 @@ static int mc33880_probe(struct spi_device *spi)
return ret;
exit_destroy:
- spi_set_drvdata(spi, NULL);
mutex_destroy(&mc->lock);
return ret;
}
@@ -156,8 +155,6 @@ static int mc33880_remove(struct spi_device *spi)
if (mc == NULL)
return -ENODEV;
- spi_set_drvdata(spi, NULL);
-
ret = gpiochip_remove(&mc->chip);
if (!ret)
mutex_destroy(&mc->lock);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] gpio: gpio-mc33880: Remove redundant spi_set_drvdata
2013-09-19 12:00 [PATCH 1/1] gpio: gpio-mc33880: Remove redundant spi_set_drvdata Sachin Kamat
@ 2013-09-23 10:53 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-09-23 10:53 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-gpio@vger.kernel.org
On Thu, Sep 19, 2013 at 2:00 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-23 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 12:00 [PATCH 1/1] gpio: gpio-mc33880: Remove redundant spi_set_drvdata Sachin Kamat
2013-09-23 10:53 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).